From: Nishanth Menon <nm@ti.com> To: Lukasz Luba <lukasz.luba@arm.com> Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <vireshk@kernel.org>, <robh+dt@kernel.org>, <sboyd@kernel.org>, <rafael@kernel.org>, <sudeep.holla@arm.com>, <daniel.lezcano@linaro.org>, <Dietmar.Eggemann@arm.com> Subject: Re: [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings Date: Thu, 29 Oct 2020 07:59:32 -0500 [thread overview] Message-ID: <20201029125932.fvhaj6fsgt3qvmoc@gloomily> (raw) In-Reply-To: <5b3a99a8-6972-5c60-6cc5-00ec84387b97@arm.com> On 10:04-20201029, Lukasz Luba wrote: > > > On 10/28/20 9:47 PM, Nishanth Menon wrote: > > On 14:08-20201028, Lukasz Luba wrote: > > > Add opp-sustainable as an additional property in the OPP node to describe > > > the sustainable performance level of the device. This will help to > > > estimate the sustainable performance of the whole system. > > > > > > Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> > > > --- > > > Documentation/devicetree/bindings/opp/opp.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > > index 9847dfeeffcb..cd01028de305 100644 > > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > > @@ -154,6 +154,10 @@ Optional properties: > > > - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs > > > in the table have this, the OPP with highest opp-hz will be used. > > > +- opp-sustainable: Marks the OPP as sustainable. This property can be used for > > > + estimating sustainable performance of the whole system. If multiple OPPs in > > > + the table have this, the OPP with highest opp-hz will be used. > > > > > > By "sustainable", do you mean sustainable across Process, Voltage and > > Temperature corners upto the max rated operational Power-ON hours > > without IDLE state being achieved on the processor? > > Yes, in case of CPU: running 100% without idle at that particular OPP. > Running above that OPP would lead to cross control temperature. We need to tighten the definitions a lot more here and add that to the binding. What we are stating, if I am not misunderstanding is an OPP that is guaranteed by SoC vendor that across Process Voltage and Temperature corners - aka across the entire production spectrum for the part number, *all* devices will operate at this OPP for the mandated power-on-hours rating without hitting IDLE. Example: So -40C to 125C, across the process (hot/cold/nominal), 100s of thousands/millions of units can operate upto 125,0000 power-on-hours while running a tight deadloop OR maybe high processing function or even cpuburn[1]? Can you give me one SoC vendor and part that guarantees this? I am wondering if this is all theoretical... There are tons of parameters that come into play for "reliability" "sustainability" etc. Those are tricky terminology that typically makes legal folks pretty happy to debate for decades.. just my 2 cents. > > > > > OR do you mean to leave it up to interpretation? > > I can tell how I would use them. There is thermal governor IPA, which > needs sustainable power either form DT or uses internal algorithm to > estimate it based on lowest allowed freq OPPs. Then it estimated > internal coefficients based on that value, which is not optimal > for lowest OPPs. When some higher OPP could be marked as sustainable, > it would lead to better estimation and better power budget split. Seeing your series, I got an idea about how you plan on using it, I just think we need to be more precise in our definition.. [1] https://patrickmn.com/projects/cpuburn/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com> To: Lukasz Luba <lukasz.luba@arm.com> Cc: devicetree@vger.kernel.org, daniel.lezcano@linaro.org, linux-pm@vger.kernel.org, sboyd@kernel.org, vireshk@kernel.org, rafael@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, sudeep.holla@arm.com, Dietmar.Eggemann@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings Date: Thu, 29 Oct 2020 07:59:32 -0500 [thread overview] Message-ID: <20201029125932.fvhaj6fsgt3qvmoc@gloomily> (raw) In-Reply-To: <5b3a99a8-6972-5c60-6cc5-00ec84387b97@arm.com> On 10:04-20201029, Lukasz Luba wrote: > > > On 10/28/20 9:47 PM, Nishanth Menon wrote: > > On 14:08-20201028, Lukasz Luba wrote: > > > Add opp-sustainable as an additional property in the OPP node to describe > > > the sustainable performance level of the device. This will help to > > > estimate the sustainable performance of the whole system. > > > > > > Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> > > > --- > > > Documentation/devicetree/bindings/opp/opp.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > > index 9847dfeeffcb..cd01028de305 100644 > > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > > @@ -154,6 +154,10 @@ Optional properties: > > > - opp-suspend: Marks the OPP to be used during device suspend. If multiple OPPs > > > in the table have this, the OPP with highest opp-hz will be used. > > > +- opp-sustainable: Marks the OPP as sustainable. This property can be used for > > > + estimating sustainable performance of the whole system. If multiple OPPs in > > > + the table have this, the OPP with highest opp-hz will be used. > > > > > > By "sustainable", do you mean sustainable across Process, Voltage and > > Temperature corners upto the max rated operational Power-ON hours > > without IDLE state being achieved on the processor? > > Yes, in case of CPU: running 100% without idle at that particular OPP. > Running above that OPP would lead to cross control temperature. We need to tighten the definitions a lot more here and add that to the binding. What we are stating, if I am not misunderstanding is an OPP that is guaranteed by SoC vendor that across Process Voltage and Temperature corners - aka across the entire production spectrum for the part number, *all* devices will operate at this OPP for the mandated power-on-hours rating without hitting IDLE. Example: So -40C to 125C, across the process (hot/cold/nominal), 100s of thousands/millions of units can operate upto 125,0000 power-on-hours while running a tight deadloop OR maybe high processing function or even cpuburn[1]? Can you give me one SoC vendor and part that guarantees this? I am wondering if this is all theoretical... There are tons of parameters that come into play for "reliability" "sustainability" etc. Those are tricky terminology that typically makes legal folks pretty happy to debate for decades.. just my 2 cents. > > > > > OR do you mean to leave it up to interpretation? > > I can tell how I would use them. There is thermal governor IPA, which > needs sustainable power either form DT or uses internal algorithm to > estimate it based on lowest allowed freq OPPs. Then it estimated > internal coefficients based on that value, which is not optimal > for lowest OPPs. When some higher OPP could be marked as sustainable, > it would lead to better estimation and better power budget split. Seeing your series, I got an idea about how you plan on using it, I just think we need to be more precise in our definition.. [1] https://patrickmn.com/projects/cpuburn/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-29 12:59 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-28 14:08 [PATCH 0/4] Add sustainable OPP concept Lukasz Luba 2020-10-28 14:08 ` Lukasz Luba 2020-10-28 14:08 ` [PATCH 1/4] dt-bindings: opp: Introduce opp-sustainable bindings Lukasz Luba 2020-10-28 14:08 ` Lukasz Luba 2020-10-28 21:47 ` Nishanth Menon 2020-10-28 21:47 ` Nishanth Menon 2020-10-29 10:04 ` Lukasz Luba 2020-10-29 10:04 ` Lukasz Luba 2020-10-29 12:59 ` Nishanth Menon [this message] 2020-10-29 12:59 ` Nishanth Menon 2020-10-29 13:33 ` Lukasz Luba 2020-10-29 13:33 ` Lukasz Luba 2020-10-29 13:49 ` Nishanth Menon 2020-10-29 13:49 ` Nishanth Menon 2020-10-29 14:20 ` Lukasz Luba 2020-10-29 14:20 ` Lukasz Luba 2020-10-30 19:34 ` Rob Herring 2020-10-30 19:34 ` Rob Herring 2020-11-02 8:40 ` Lukasz Luba 2020-11-02 8:40 ` Lukasz Luba 2020-10-28 14:08 ` [PATCH 2/4] OPP: Add support for parsing the 'opp-sustainable' property Lukasz Luba 2020-10-28 14:08 ` Lukasz Luba 2020-10-30 11:47 ` Quentin Perret 2020-10-30 11:47 ` Quentin Perret 2020-10-30 12:53 ` Lukasz Luba 2020-10-30 12:53 ` Lukasz Luba 2020-10-28 14:08 ` [PATCH 3/4] OPP: Add dev_pm_opp_set_sustainable_opp_freq() Lukasz Luba 2020-10-28 14:08 ` Lukasz Luba 2020-10-28 14:08 ` [PATCH 4/4] firmware: arm_scmi/perf: Mark sustainable OPP Lukasz Luba 2020-10-28 14:08 ` Lukasz Luba 2020-10-29 7:40 ` [PATCH 0/4] Add sustainable OPP concept Viresh Kumar 2020-10-29 7:40 ` Viresh Kumar 2020-10-29 7:53 ` Viresh Kumar 2020-10-29 7:53 ` Viresh Kumar 2020-10-29 9:56 ` Lukasz Luba 2020-10-29 9:56 ` Lukasz Luba 2020-10-30 8:29 ` Viresh Kumar 2020-10-30 8:29 ` Viresh Kumar 2020-10-30 9:19 ` Lukasz Luba 2020-10-30 9:19 ` Lukasz Luba 2020-10-30 9:52 ` Viresh Kumar 2020-10-30 9:52 ` Viresh Kumar 2020-10-30 10:56 ` Lukasz Luba 2020-10-30 10:56 ` Lukasz Luba 2020-10-30 11:17 ` Viresh Kumar 2020-10-30 11:17 ` Viresh Kumar 2020-10-30 12:40 ` Lukasz Luba 2020-10-30 12:40 ` Lukasz Luba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201029125932.fvhaj6fsgt3qvmoc@gloomily \ --to=nm@ti.com \ --cc=Dietmar.Eggemann@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lukasz.luba@arm.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.