From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
David Runge <dave@sleepmap.de>,
linux-rt-users@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Daniel Wagner <dwagner@suse.de>, Mike Galbraith <efault@gmx.de>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done
Date: Thu, 29 Oct 2020 14:57:43 +0000 [thread overview]
Message-ID: <20201029145743.GA19379@infradead.org> (raw)
In-Reply-To: <20201029145623.3zry7o6nh6ks5tjj@linutronix.de>
On Thu, Oct 29, 2020 at 03:56:23PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-10-29 14:05:36 [+0000], Christoph Hellwig wrote:
> > Well, usb-storage obviously seems to do it, and the block layer
> > does not prohibit it.
>
> Also loop, nvme-tcp and then I stopped looking.
> Any objections about adding local_bh_disable() around it?
To me it seems like the whole IPI plus potentially softirq dance is
a little pointless when completing from process context.
Sagi, any opinion on that from the nvme-tcp POV?
next prev parent reply other threads:[~2020-10-29 14:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 17:50 5.9.1-rt18: issues with Firewire card on AMD hardware David Runge
2020-10-23 11:04 ` [PATCH RFC] blk-mq: Don't IPI requests on PREEMPT_RT Sebastian Andrzej Siewior
2020-10-23 11:21 ` Christoph Hellwig
2020-10-23 13:52 ` Sebastian Andrzej Siewior
2020-10-27 9:26 ` Christoph Hellwig
2020-10-27 10:11 ` Sebastian Andrzej Siewior
2020-10-27 16:07 ` Christoph Hellwig
2020-10-27 17:05 ` Thomas Gleixner
2020-10-27 17:23 ` Christoph Hellwig
2020-10-27 17:59 ` Sebastian Andrzej Siewior
2020-10-27 20:58 ` Sebastian Andrzej Siewior
2020-10-28 6:56 ` Christoph Hellwig
2020-10-28 14:12 ` [PATCH 1/3] blk-mq: Don't complete on a remote CPU in force threaded mode Sebastian Andrzej Siewior
2020-10-28 14:12 ` [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq Sebastian Andrzej Siewior
2020-10-28 14:12 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2020-10-28 14:44 ` Christoph Hellwig
2020-10-28 14:47 ` Sebastian Andrzej Siewior
2020-10-29 13:12 ` Sebastian Andrzej Siewior
2020-10-29 14:05 ` Christoph Hellwig
2020-10-29 14:56 ` Sebastian Andrzej Siewior
2020-10-29 14:57 ` Christoph Hellwig [this message]
2020-10-29 20:03 ` Sagi Grimberg
2020-10-29 21:01 ` Sebastian Andrzej Siewior
2020-10-29 21:07 ` Sagi Grimberg
2020-10-31 10:41 ` Sebastian Andrzej Siewior
2020-10-31 15:00 ` Jens Axboe
2020-10-31 15:01 ` Jens Axboe
2020-10-31 18:09 ` Christoph Hellwig
2020-11-02 9:55 ` Sebastian Andrzej Siewior
2020-11-02 18:12 ` Christoph Hellwig
2020-11-04 19:15 ` Sagi Grimberg
2020-11-06 15:23 ` Sebastian Andrzej Siewior
2020-10-28 10:04 ` [PATCH RFC] blk-mq: Don't IPI requests on PREEMPT_RT Peter Zijlstra
2020-10-26 0:37 ` 5.9.1-rt18: issues with Firewire card on AMD hardware David Runge
2020-12-04 19:13 [PATCH 0/3 v2] blk-mq: Don't complete in IRQ, use llist_head Sebastian Andrzej Siewior
2020-12-04 19:13 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2020-12-08 13:20 ` Christoph Hellwig
2020-12-08 13:28 ` Christoph Hellwig
2020-12-14 20:20 ` Sebastian Andrzej Siewior
2021-01-23 20:10 [PATCH v3 0/3] blk-mq: Don't complete in IRQ, use llist_head Sebastian Andrzej Siewior
2021-01-23 20:10 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2021-01-25 8:30 ` Christoph Hellwig
2021-01-25 8:32 ` Sebastian Andrzej Siewior
2021-01-25 8:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029145743.GA19379@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=dave@sleepmap.de \
--cc=dwagner@suse.de \
--cc=efault@gmx.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.