From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done
Date: Mon, 25 Jan 2021 09:32:04 +0100 [thread overview]
Message-ID: <20210125083204.ahddujk5m6njwbju@linutronix.de> (raw)
In-Reply-To: <20210125083012.GD942655@infradead.org>
On 2021-01-25 08:30:12 [+0000], Christoph Hellwig wrote:
> > +static void blk_mq_complete_send_ipi(struct request *rq)
> > +{
> > + struct llist_head *list;
> > + unsigned int cpu;
> > +
> > + cpu = rq->mq_ctx->cpu;
> > + list = &per_cpu(blk_cpu_done, cpu);
> > + if (llist_add(&rq->ipi_list, list)) {
> > + INIT_CSD(&rq->csd, __blk_mq_complete_request_remote, rq);
> > + smp_call_function_single_async(cpu, &rq->csd);
> > + }
> > +}
>
> Nit: it would be nice to initialize cpu and list in the declaration
> lines.
Why? They get initialized later.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Sebastian
next prev parent reply other threads:[~2021-01-25 9:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 20:10 [PATCH v3 0/3] blk-mq: Don't complete in IRQ, use llist_head Sebastian Andrzej Siewior
2021-01-23 20:10 ` [PATCH 1/3] smp: Process pending softirqs in flush_smp_call_function_from_idle() Sebastian Andrzej Siewior
2021-02-01 19:35 ` Sebastian Andrzej Siewior
2021-02-09 10:02 ` Peter Zijlstra
2021-02-09 11:35 ` Sebastian Andrzej Siewior
2021-02-10 13:53 ` [tip: sched/core] " tip-bot2 for Sebastian Andrzej Siewior
2021-02-17 13:17 ` tip-bot2 for Sebastian Andrzej Siewior
2021-01-23 20:10 ` [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq Sebastian Andrzej Siewior
2021-01-25 7:10 ` Hannes Reinecke
2021-01-25 8:25 ` Christoph Hellwig
2021-01-25 8:30 ` Sebastian Andrzej Siewior
2021-01-25 8:32 ` Christoph Hellwig
2021-01-25 9:29 ` Sebastian Andrzej Siewior
2021-01-25 8:22 ` Christoph Hellwig
2021-01-25 8:49 ` Christoph Hellwig
2021-01-27 11:22 ` Daniel Wagner
2021-01-23 20:10 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2021-01-25 8:30 ` Christoph Hellwig
2021-01-25 8:32 ` Sebastian Andrzej Siewior [this message]
2021-01-25 8:39 ` Christoph Hellwig
2021-01-25 9:54 ` [PATCH 3/3 v2] " Sebastian Andrzej Siewior
2021-01-25 10:14 ` Christoph Hellwig
2021-01-27 11:23 ` Daniel Wagner
2021-01-25 4:27 ` [PATCH v3 0/3] blk-mq: Don't complete in IRQ, use llist_head Jens Axboe
2021-02-10 14:43 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-12-04 19:13 [PATCH 0/3 v2] " Sebastian Andrzej Siewior
2020-12-04 19:13 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2020-12-08 13:20 ` Christoph Hellwig
2020-12-08 13:28 ` Christoph Hellwig
2020-12-14 20:20 ` Sebastian Andrzej Siewior
2020-10-28 6:56 [PATCH RFC] blk-mq: Don't IPI requests on PREEMPT_RT Christoph Hellwig
2020-10-28 14:12 ` [PATCH 1/3] blk-mq: Don't complete on a remote CPU in force threaded mode Sebastian Andrzej Siewior
2020-10-28 14:12 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2020-10-28 14:44 ` Christoph Hellwig
2020-10-28 14:47 ` Sebastian Andrzej Siewior
2020-10-29 13:12 ` Sebastian Andrzej Siewior
2020-10-29 14:05 ` Christoph Hellwig
2020-10-29 14:56 ` Sebastian Andrzej Siewior
2020-10-29 14:57 ` Christoph Hellwig
2020-10-29 20:03 ` Sagi Grimberg
2020-10-29 21:01 ` Sebastian Andrzej Siewior
2020-10-29 21:07 ` Sagi Grimberg
2020-10-31 10:41 ` Sebastian Andrzej Siewior
2020-10-31 15:00 ` Jens Axboe
2020-10-31 15:01 ` Jens Axboe
2020-10-31 18:09 ` Christoph Hellwig
2020-11-02 9:55 ` Sebastian Andrzej Siewior
2020-11-02 18:12 ` Christoph Hellwig
2020-11-04 19:15 ` Sagi Grimberg
2020-11-06 15:23 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125083204.ahddujk5m6njwbju@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.