From: "Michael S. Tsirkin" <mst@redhat.com>
To: si-wei liu <si-wei.liu@oracle.com>
Cc: Jason Wang <jasowang@redhat.com>,
lingshan.zhu@intel.com, joao.m.martins@oracle.com,
boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path
Date: Thu, 29 Oct 2020 17:53:12 -0400 [thread overview]
Message-ID: <20201029175305-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5F88AE4A.9030300@oracle.com>
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
>
> On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
> > > On 2020/10/14 上午7:42, si-wei liu wrote:
> > > > >
> > > > > So what I suggest is to fix the pinning leakage first and do the
> > > > > possible optimization on top (which is still questionable to me).
> > > > OK. Unfortunately, this was picked and got merged in upstream. So I will
> > > > post a follow up patch set to 1) revert the commit to the original
> > > > __get_free_page() implementation, and 2) fix the accounting and leakage
> > > > on top. Will it be fine?
> > >
> > > Fine.
> > >
> > > Thanks
> > Fine by me too.
> >
> Thanks, Michael & Jason. I will post the fix shortly. Stay tuned.
>
> -Siwei
did I miss the patch?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: si-wei liu <si-wei.liu@oracle.com>
Cc: lingshan.zhu@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path
Date: Thu, 29 Oct 2020 17:53:12 -0400 [thread overview]
Message-ID: <20201029175305-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <5F88AE4A.9030300@oracle.com>
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
>
> On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
> > > On 2020/10/14 上午7:42, si-wei liu wrote:
> > > > >
> > > > > So what I suggest is to fix the pinning leakage first and do the
> > > > > possible optimization on top (which is still questionable to me).
> > > > OK. Unfortunately, this was picked and got merged in upstream. So I will
> > > > post a follow up patch set to 1) revert the commit to the original
> > > > __get_free_page() implementation, and 2) fix the accounting and leakage
> > > > on top. Will it be fine?
> > >
> > > Fine.
> > >
> > > Thanks
> > Fine by me too.
> >
> Thanks, Michael & Jason. I will post the fix shortly. Stay tuned.
>
> -Siwei
did I miss the patch?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-10-29 21:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 5:02 [PATCH v3 0/2] vhost-vdpa mapping error path fixes Si-Wei Liu
2020-10-03 5:02 ` Si-Wei Liu
2020-10-03 5:02 ` [PATCH v3 1/2] vhost-vdpa: fix vhost_vdpa_map() on error condition Si-Wei Liu
2020-10-03 5:02 ` Si-Wei Liu
2020-10-10 1:48 ` Jason Wang
2020-10-10 1:48 ` Jason Wang
2020-10-11 6:45 ` Michael S. Tsirkin
2020-10-11 6:45 ` Michael S. Tsirkin
2020-10-03 5:02 ` [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path Si-Wei Liu
2020-10-03 5:02 ` Si-Wei Liu
2020-10-10 2:27 ` Jason Wang
2020-10-10 2:27 ` Jason Wang
2020-10-13 23:42 ` si-wei liu
2020-10-13 23:42 ` si-wei liu
2020-10-14 6:52 ` Michael S. Tsirkin
2020-10-14 6:52 ` Michael S. Tsirkin
2020-10-14 11:41 ` Jason Wang
2020-10-14 11:41 ` Jason Wang
2020-10-15 6:15 ` Jason Wang
2020-10-15 6:15 ` Jason Wang
2020-10-15 13:11 ` Michael S. Tsirkin
2020-10-15 13:11 ` Michael S. Tsirkin
2020-10-15 20:17 ` si-wei liu
2020-10-15 20:17 ` si-wei liu
2020-10-29 21:53 ` Michael S. Tsirkin [this message]
2020-10-29 21:53 ` Michael S. Tsirkin
2020-10-29 23:22 ` si-wei liu
2020-10-29 23:22 ` si-wei liu
2020-11-03 5:34 ` si-wei liu
2020-11-03 5:34 ` si-wei liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029175305-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jasowang@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.