From: 赵仪峰 <yifeng.zhao@rock-chips.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: "Johan Jonker" <jbx6244@gmail.com>, richard <richard@nod.at>,
vigneshr <vigneshr@ti.com>, robh+dt <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
HeikoStübner <heiko@sntech.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 16:14:01 +0800 [thread overview]
Message-ID: <20201102161300764203144@rock-chips.com> (raw)
In-Reply-To: 20201102083258.3a748c44@xps13
Hi Miquel,
The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
but the nand controller do nothing and the cs of the NAND device is still selected,
so the NAND device will not enter auto power save mode.
--------------
Thanks,
Yifeng
>Hello,
>
>赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 11:46:04
>+0800:
>
>> Hi Johan,
>>
>> void nand_deselect_target(struct nand_chip *chip)
>> {
>> if (chip->legacy.select_chip)
>> chip->legacy.select_chip(chip, -1);
>>
>> chip->cur_cs = -1;
>> }
>>
>> I need add the code below and it work.
>>
>> chip->legacy.select_chip = rk_nfc_select_chip;
>>
>> But I found almost all nandc drivers do not add this code. Is there any other way to implement it？
>
>Indeed, we don't accept new code we legacy bindings.
>
>I don't understand what extra consumption you are trying to avoid,
>because if it is the NAND device itself that is able to save power when
>it gets unselected, it's really none of you controller's business.
>
>Perhaps it's the time to focus on the controller support and tune the
>code base later in a bid to reduce consumption.
>
>Thanks,
>Miquèl
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: 赵仪峰 <yifeng.zhao@rock-chips.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: devicetree <devicetree@vger.kernel.org>,
HeikoStübner <heiko@sntech.de>, richard <richard@nod.at>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
robh+dt <robh+dt@kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
"Johan Jonker" <jbx6244@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
vigneshr <vigneshr@ti.com>
Subject: Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 16:14:01 +0800 [thread overview]
Message-ID: <20201102161300764203144@rock-chips.com> (raw)
In-Reply-To: 20201102083258.3a748c44@xps13
Hi Miquel,
The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
but the nand controller do nothing and the cs of the NAND device is still selected,
so the NAND device will not enter auto power save mode.
--------------
Thanks,
Yifeng
>Hello,
>
>赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 11:46:04
>+0800:
>
>> Hi Johan,
>>
>> void nand_deselect_target(struct nand_chip *chip)
>> {
>> if (chip->legacy.select_chip)
>> chip->legacy.select_chip(chip, -1);
>>
>> chip->cur_cs = -1;
>> }
>>
>> I need add the code below and it work.
>>
>> chip->legacy.select_chip = rk_nfc_select_chip;
>>
>> But I found almost all nandc drivers do not add this code. Is there any other way to implement it？
>
>Indeed, we don't accept new code we legacy bindings.
>
>I don't understand what extra consumption you are trying to avoid,
>because if it is the NAND device itself that is able to save power when
>it gets unselected, it's really none of you controller's business.
>
>Perhaps it's the time to focus on the controller support and tune the
>code base later in a bid to reduce consumption.
>
>Thanks,
>Miquèl
>
>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: 赵仪峰 <yifeng.zhao@rock-chips.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: devicetree <devicetree@vger.kernel.org>,
HeikoStübner <heiko@sntech.de>, richard <richard@nod.at>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
robh+dt <robh+dt@kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
"Johan Jonker" <jbx6244@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
vigneshr <vigneshr@ti.com>
Subject: Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 16:14:01 +0800 [thread overview]
Message-ID: <20201102161300764203144@rock-chips.com> (raw)
In-Reply-To: 20201102083258.3a748c44@xps13
Hi Miquel,
The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
but the nand controller do nothing and the cs of the NAND device is still selected,
so the NAND device will not enter auto power save mode.
--------------
Thanks,
Yifeng
>Hello,
>
>赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 11:46:04
>+0800:
>
>> Hi Johan,
>>
>> void nand_deselect_target(struct nand_chip *chip)
>> {
>> if (chip->legacy.select_chip)
>> chip->legacy.select_chip(chip, -1);
>>
>> chip->cur_cs = -1;
>> }
>>
>> I need add the code below and it work.
>>
>> chip->legacy.select_chip = rk_nfc_select_chip;
>>
>> But I found almost all nandc drivers do not add this code. Is there any other way to implement it？
>
>Indeed, we don't accept new code we legacy bindings.
>
>I don't understand what extra consumption you are trying to avoid,
>because if it is the NAND device itself that is able to save power when
>it gets unselected, it's really none of you controller's business.
>
>Perhaps it's the time to focus on the controller support and tune the
>code base later in a bid to reduce consumption.
>
>Thanks,
>Miquèl
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: 赵仪峰 <yifeng.zhao@rock-chips.com>
To: "Miquel Raynal" <miquel.raynal@bootlin.com>
Cc: devicetree <devicetree@vger.kernel.org>,
HeikoStübner <heiko@sntech.de>, richard <richard@nod.at>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
robh+dt <robh+dt@kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
"Johan Jonker" <jbx6244@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
vigneshr <vigneshr@ti.com>
Subject: Re: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 16:14:01 +0800 [thread overview]
Message-ID: <20201102161300764203144@rock-chips.com> (raw)
In-Reply-To: 20201102083258.3a748c44@xps13
Hi Miquel,
The nand_base.c will call nand_deselect_target after NAND read/program... ops done, and set variable chip->cur_cs = -1,
but the nand controller do nothing and the cs of the NAND device is still selected,
so the NAND device will not enter auto power save mode.
--------------
Thanks,
Yifeng
>Hello,
>
>赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 11:46:04
>+0800:
>
>> Hi Johan,
>>
>> void nand_deselect_target(struct nand_chip *chip)
>> {
>> if (chip->legacy.select_chip)
>> chip->legacy.select_chip(chip, -1);
>>
>> chip->cur_cs = -1;
>> }
>>
>> I need add the code below and it work.
>>
>> chip->legacy.select_chip = rk_nfc_select_chip;
>>
>> But I found almost all nandc drivers do not add this code. Is there any other way to implement it？
>
>Indeed, we don't accept new code we legacy bindings.
>
>I don't understand what extra consumption you are trying to avoid,
>because if it is the NAND device itself that is able to save power when
>it gets unselected, it's really none of you controller's business.
>
>Perhaps it's the time to focus on the controller support and tune the
>code base later in a bid to reduce consumption.
>
>Thanks,
>Miquèl
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-02 8:20 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:53 [PATCH v13 0/8] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 10:48 ` Miquel Raynal
2020-10-28 10:48 ` Miquel Raynal
2020-10-28 10:48 ` Miquel Raynal
2020-10-28 10:48 ` Miquel Raynal
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:26 ` Miquel Raynal
2020-10-30 10:26 ` Miquel Raynal
2020-10-30 10:26 ` Miquel Raynal
2020-10-30 10:26 ` Miquel Raynal
2020-10-31 11:58 ` Johan Jonker
2020-10-31 11:58 ` Johan Jonker
2020-10-31 11:58 ` Johan Jonker
2020-10-31 11:58 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-11-02 3:46 ` 赵仪峰
2020-11-02 3:46 ` 赵仪峰
2020-11-02 3:46 ` 赵仪峰
2020-11-02 3:46 ` 赵仪峰
2020-11-02 7:32 ` Miquel Raynal
2020-11-02 7:32 ` Miquel Raynal
2020-11-02 7:32 ` Miquel Raynal
2020-11-02 7:32 ` Miquel Raynal
2020-11-02 8:14 ` 赵仪峰 [this message]
2020-11-02 8:14 ` 赵仪峰
2020-11-02 8:14 ` 赵仪峰
2020-11-02 8:14 ` 赵仪峰
2020-11-02 8:20 ` Miquel Raynal
2020-11-02 8:20 ` Miquel Raynal
2020-11-02 8:20 ` Miquel Raynal
2020-11-02 8:20 ` Miquel Raynal
[not found] ` <e02e13a0-769d-6b73-c87e-5b7d75fd4254@rock-chips.com>
2020-11-02 12:57 ` Johan Jonker
2020-11-02 12:57 ` Johan Jonker
2020-11-02 12:57 ` Johan Jonker
2020-11-02 12:57 ` Johan Jonker
2020-11-02 13:07 ` Miquel Raynal
2020-11-02 13:07 ` Miquel Raynal
2020-11-02 13:07 ` Miquel Raynal
2020-11-02 13:07 ` Miquel Raynal
2020-11-02 13:11 ` Johan Jonker
2020-11-02 13:11 ` Johan Jonker
2020-11-02 13:11 ` Johan Jonker
2020-11-02 13:11 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:11 ` Johan Jonker
2020-11-02 17:11 ` Johan Jonker
2020-11-02 17:11 ` Johan Jonker
2020-11-02 17:11 ` Johan Jonker
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
2020-10-28 9:53 ` [PATCH v13 3/8] MAINTAINERS: add maintainers to ROCKCHIP NFC Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` [PATCH v13 4/8] arm64: dts: rockchip: Add NFC node for RK3308 SoC Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:53 ` Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 5/8] arm64: dts: rockchip: Add NFC node for PX30 SoC Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 6/8] arm: dts: rockchip: Add NFC node for RV1108 SoC Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 7/8] arm: dts: rockchip: Add NFC node for RK2928 and other SoCs Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` [PATCH v13 8/8] arm: dts: rockchip: Add NFC node for RK3036 SoC Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
2020-10-28 9:54 ` Yifeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102161300764203144@rock-chips.com \
--to=yifeng.zhao@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.