Re: [PATCH 01/18] powerpc/pci: Add ppc_md.discover_phbs()

From: kernel test robot <lkp@intel.com>
To: Oliver O'Halloran <oohall@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: clang-built-linux@googlegroups.com,
	Oliver O'Halloran <oohall@gmail.com>,
	kbuild-all@lists.01.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 01/18] powerpc/pci: Add ppc_md.discover_phbs()
Date: Wed, 4 Nov 2020 12:07:22 +0800	[thread overview]
Message-ID: <202011041247.j9BQqN4Z-lkp@intel.com> (raw)
In-Reply-To: <20201103043523.916109-1-oohall@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

Hi Oliver,

I love your patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.10-rc2 next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oliver-O-Halloran/powerpc-pci-Add-ppc_md-discover_phbs/20201103-130935
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r024-20201103 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1fcd5d5655e29f85e12b402e32974f207cfedf32)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/76dcfc8e7ec9ceaee251e156ffe07140bf1f1a5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oliver-O-Halloran/powerpc-pci-Add-ppc_md-discover_phbs/20201103-130935
        git checkout 76dcfc8e7ec9ceaee251e156ffe07140bf1f1a5d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/powerpc/kernel/pci-common.c:1630:12: warning: no previous prototype for function 'discover_phbs' [-Wmissing-prototypes]
   int __init discover_phbs(void)
              ^
   arch/powerpc/kernel/pci-common.c:1630:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int __init discover_phbs(void)
   ^
   static 
   1 warning generated.

vim +/discover_phbs +1630 arch/powerpc/kernel/pci-common.c

  1628	
  1629	
> 1630	int __init discover_phbs(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34042 bytes --]