From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com,
thuth@redhat.com, cohuck@redhat.com, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 3/7] lib/asm: Add definitions of memory areas
Date: Fri, 6 Nov 2020 13:58:30 +0100 [thread overview]
Message-ID: <20201106135830.53f027b5@ibm-vm> (raw)
In-Reply-To: <1429868e-2348-e7a3-0668-4fc2439052f2@redhat.com>
On Fri, 6 Nov 2020 12:34:10 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 02/10/20 17:44, Claudio Imbrenda wrote:
> > x86 gets
> > * lowest area (24-bit addresses)
> > * low area (32-bit addresses)
> > * the rest
>
> x86 if anything could use a 36-bit area; the 24-bit one is out of
> scope for what kvm-unit-tests does.
sure... I went with what I remembered about the x86 architecture, but
I'm not an expert
my patch was meant to be some "sensible defaults" that people with
more knowledge should override anyway :)
> So something like this:
>
> diff --git a/lib/x86/asm/memory_areas.h b/lib/x86/asm/memory_areas.h
> index d704df3..952f5bd 100644
> --- a/lib/x86/asm/memory_areas.h
> +++ b/lib/x86/asm/memory_areas.h
> @@ -1,20 +1,19 @@
> #ifndef MEMORY_AREAS_H
> #define MEMORY_AREAS_H
>
> -#define AREA_NORMAL_PFN BIT(32-12)
> +#define AREA_NORMAL_PFN BIT(36-12)
> #define AREA_NORMAL_NUMBER 0
> #define AREA_NORMAL 1
>
> -#define AREA_LOW_PFN BIT(24-12)
> -#define AREA_LOW_NUMBER 1
> -#define AREA_LOW 2
> +#define AREA_PAE_HIGH_PFN BIT(32-12)
> +#define AREA_PAE_HIGH_NUMBER 1
> +#define AREA_PAE_HIGH 2
>
> -#define AREA_LOWEST_PFN 0
> -#define AREA_LOWEST_NUMBER 2
> -#define AREA_LOWEST 4
> +#define AREA_LOW_PFN 0
> +#define AREA_LOW_NUMBER 2
> +#define AREA_LOW 4
>
> -#define AREA_DMA24 AREA_LOWEST
> -#define AREA_DMA32 (AREA_LOWEST | AREA_LOW)
> +#define AREA_PAE (AREA_PAE | AREA_LOW)
>
> #define AREA_ANY -1
> #define AREA_ANY_NUMBER 0xff
>
> Paolo
>
next prev parent reply other threads:[~2020-11-06 12:58 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 15:44 [kvm-unit-tests PATCH v2 0/7] Rewrite the allocators Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 1/7] lib/list: Add double linked list management functions Claudio Imbrenda
2020-10-02 18:18 ` Andrew Jones
2020-10-05 6:57 ` Claudio Imbrenda
2020-11-06 11:29 ` Paolo Bonzini
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 2/7] lib/vmalloc: vmalloc support for handling allocation metadata Claudio Imbrenda
2020-10-03 8:46 ` Andrew Jones
2020-10-05 7:00 ` Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 3/7] lib/asm: Add definitions of memory areas Claudio Imbrenda
2020-10-03 9:23 ` Andrew Jones
2020-10-05 7:10 ` Claudio Imbrenda
2020-11-06 11:34 ` Paolo Bonzini
2020-11-06 12:58 ` Claudio Imbrenda [this message]
2020-11-06 13:04 ` Paolo Bonzini
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 4/7] lib/alloc_page: complete rewrite of the page allocator Claudio Imbrenda
2020-10-05 12:40 ` Andrew Jones
2020-10-05 15:56 ` Claudio Imbrenda
2020-10-05 16:53 ` Andrew Jones
2020-10-05 17:18 ` Claudio Imbrenda
2020-10-05 18:04 ` Andrew Jones
2020-12-08 0:41 ` Nadav Amit
2020-12-08 1:10 ` Nadav Amit
2020-12-08 9:15 ` Claudio Imbrenda
2020-12-08 9:23 ` Nadav Amit
2020-12-08 10:00 ` Claudio Imbrenda
2020-12-08 12:48 ` Nadav Amit
2020-12-08 13:41 ` Claudio Imbrenda
2020-12-08 14:26 ` Andrew Jones
2020-12-09 8:53 ` Claudio Imbrenda
2020-12-08 9:11 ` Claudio Imbrenda
2020-12-08 9:16 ` Nadav Amit
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 5/7] lib/alloc: simplify free and malloc Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 6/7] lib/alloc.h: remove align_min from struct alloc_ops Claudio Imbrenda
2020-11-06 11:35 ` Paolo Bonzini
2020-11-06 12:56 ` Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 7/7] lib/alloc_page: allow reserving arbitrary memory ranges Claudio Imbrenda
2020-10-05 11:54 ` [kvm-unit-tests PATCH v2 0/7] Rewrite the allocators Pierre Morel
2020-10-05 12:35 ` Claudio Imbrenda
2020-10-05 12:49 ` Andrew Jones
2020-10-05 12:57 ` Pierre Morel
2020-10-05 14:59 ` Claudio Imbrenda
2020-11-06 11:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106135830.53f027b5@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.