From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: KVM <kvm@vger.kernel.org>,
pbonzini@redhat.com, frankja@linux.ibm.com, david@redhat.com,
thuth@redhat.com, cohuck@redhat.com, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 4/7] lib/alloc_page: complete rewrite of the page allocator
Date: Tue, 8 Dec 2020 10:11:55 +0100 [thread overview]
Message-ID: <20201208101155.0e2de3c9@ibm-vm> (raw)
In-Reply-To: <C812A718-DCD6-4485-BB5A-B24DE73A0FD3@gmail.com>
On Mon, 7 Dec 2020 16:41:18 -0800
Nadav Amit <nadav.amit@gmail.com> wrote:
> > On Oct 2, 2020, at 8:44 AM, Claudio Imbrenda
> > <imbrenda@linux.ibm.com> wrote:
> >
> > This is a complete rewrite of the page allocator.
>
> This patch causes me crashes:
>
> lib/alloc_page.c:433: assert failed: !(areas_mask & BIT(n))
>
> It appears that two areas are registered on AREA_LOW_NUMBER, as
> setup_vm() can call (and calls on my system) page_alloc_init_area()
> twice.
which system is that? page_alloc_init_area should not be called twice
on the same area!
> setup_vm() uses AREA_ANY_NUMBER as the area number argument but
> eventually this means, according to the code, that
> __page_alloc_init_area() would use AREA_LOW_NUMBER.
>
> I do not understand the rationale behind these areas well enough to
> fix it.
I'll see what I can fix
Claudio
next prev parent reply other threads:[~2020-12-08 9:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 15:44 [kvm-unit-tests PATCH v2 0/7] Rewrite the allocators Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 1/7] lib/list: Add double linked list management functions Claudio Imbrenda
2020-10-02 18:18 ` Andrew Jones
2020-10-05 6:57 ` Claudio Imbrenda
2020-11-06 11:29 ` Paolo Bonzini
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 2/7] lib/vmalloc: vmalloc support for handling allocation metadata Claudio Imbrenda
2020-10-03 8:46 ` Andrew Jones
2020-10-05 7:00 ` Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 3/7] lib/asm: Add definitions of memory areas Claudio Imbrenda
2020-10-03 9:23 ` Andrew Jones
2020-10-05 7:10 ` Claudio Imbrenda
2020-11-06 11:34 ` Paolo Bonzini
2020-11-06 12:58 ` Claudio Imbrenda
2020-11-06 13:04 ` Paolo Bonzini
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 4/7] lib/alloc_page: complete rewrite of the page allocator Claudio Imbrenda
2020-10-05 12:40 ` Andrew Jones
2020-10-05 15:56 ` Claudio Imbrenda
2020-10-05 16:53 ` Andrew Jones
2020-10-05 17:18 ` Claudio Imbrenda
2020-10-05 18:04 ` Andrew Jones
2020-12-08 0:41 ` Nadav Amit
2020-12-08 1:10 ` Nadav Amit
2020-12-08 9:15 ` Claudio Imbrenda
2020-12-08 9:23 ` Nadav Amit
2020-12-08 10:00 ` Claudio Imbrenda
2020-12-08 12:48 ` Nadav Amit
2020-12-08 13:41 ` Claudio Imbrenda
2020-12-08 14:26 ` Andrew Jones
2020-12-09 8:53 ` Claudio Imbrenda
2020-12-08 9:11 ` Claudio Imbrenda [this message]
2020-12-08 9:16 ` Nadav Amit
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 5/7] lib/alloc: simplify free and malloc Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 6/7] lib/alloc.h: remove align_min from struct alloc_ops Claudio Imbrenda
2020-11-06 11:35 ` Paolo Bonzini
2020-11-06 12:56 ` Claudio Imbrenda
2020-10-02 15:44 ` [kvm-unit-tests PATCH v2 7/7] lib/alloc_page: allow reserving arbitrary memory ranges Claudio Imbrenda
2020-10-05 11:54 ` [kvm-unit-tests PATCH v2 0/7] Rewrite the allocators Pierre Morel
2020-10-05 12:35 ` Claudio Imbrenda
2020-10-05 12:49 ` Andrew Jones
2020-10-05 12:57 ` Pierre Morel
2020-10-05 14:59 ` Claudio Imbrenda
2020-11-06 11:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208101155.0e2de3c9@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.