From: Deepak R Varma <mh12gx2825@gmail.com> To: Maxime Ripard <maxime@cerno.tech> Cc: Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2] drm/vc4: replace idr_init() by idr_init_base() Date: Sun, 8 Nov 2020 15:43:51 +0530 [thread overview] Message-ID: <20201108101351.GA41922@localhost> (raw) In-Reply-To: <20201106105249.zvyd36shfec24lzn@gilmour.lan> On Fri, Nov 06, 2020 at 11:52:49AM +0100, Maxime Ripard wrote: > On Thu, Nov 05, 2020 at 01:24:14PM -0800, Eric Anholt wrote: > > On Thu, Nov 5, 2020 at 12:21 PM Deepak R Varma <mh12gx2825@gmail.com> wrote: > > > > > > idr_init() uses base 0 which is an invalid identifier for this driver. > > > The idr_alloc for this driver uses VC4_PERFMONID_MIN as start value for > > > ID range and it is #defined to 1. The new function idr_init_base allows > > > IDR to set the ID lookup from base 1. This avoids all lookups that > > > otherwise starts from 0 since 0 is always unused / available. > > > > > > References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") > > > > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > > > --- > > > Changes since v1: > > > - Change suggested by Eric Anholt > > > 1. Use VC4_PERFMONID_MIN instead of magic number 1 > > > > > > drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vc4/vc4_perfmon.c b/drivers/gpu/drm/vc4/vc4_perfmon.c > > > index f4aa75efd16b..18abc06335c1 100644 > > > --- a/drivers/gpu/drm/vc4/vc4_perfmon.c > > > +++ b/drivers/gpu/drm/vc4/vc4_perfmon.c > > > @@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id) > > > void vc4_perfmon_open_file(struct vc4_file *vc4file) > > > { > > > mutex_init(&vc4file->perfmon.lock); > > > - idr_init(&vc4file->perfmon.idr); > > > + idr_init_base(&vc4file->perfmon.idr, VC4_PERFMONID_MIN); > > > } > > > > > > static int vc4_perfmon_idr_del(int id, void *elem, void *data) > > > -- > > > 2.25.1 > > > > Reviewed-by: Eric Anholt <eric@anholt.net> > > > > hopefully Maxime can apply it. > > Applied, thanks! Thank you all. Appreciate your time. ./drv > Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Deepak R Varma <mh12gx2825@gmail.com> To: Maxime Ripard <maxime@cerno.tech> Cc: David Airlie <airlied@linux.ie>, DRI Development <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2] drm/vc4: replace idr_init() by idr_init_base() Date: Sun, 8 Nov 2020 15:43:51 +0530 [thread overview] Message-ID: <20201108101351.GA41922@localhost> (raw) In-Reply-To: <20201106105249.zvyd36shfec24lzn@gilmour.lan> On Fri, Nov 06, 2020 at 11:52:49AM +0100, Maxime Ripard wrote: > On Thu, Nov 05, 2020 at 01:24:14PM -0800, Eric Anholt wrote: > > On Thu, Nov 5, 2020 at 12:21 PM Deepak R Varma <mh12gx2825@gmail.com> wrote: > > > > > > idr_init() uses base 0 which is an invalid identifier for this driver. > > > The idr_alloc for this driver uses VC4_PERFMONID_MIN as start value for > > > ID range and it is #defined to 1. The new function idr_init_base allows > > > IDR to set the ID lookup from base 1. This avoids all lookups that > > > otherwise starts from 0 since 0 is always unused / available. > > > > > > References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") > > > > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > > > --- > > > Changes since v1: > > > - Change suggested by Eric Anholt > > > 1. Use VC4_PERFMONID_MIN instead of magic number 1 > > > > > > drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vc4/vc4_perfmon.c b/drivers/gpu/drm/vc4/vc4_perfmon.c > > > index f4aa75efd16b..18abc06335c1 100644 > > > --- a/drivers/gpu/drm/vc4/vc4_perfmon.c > > > +++ b/drivers/gpu/drm/vc4/vc4_perfmon.c > > > @@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id) > > > void vc4_perfmon_open_file(struct vc4_file *vc4file) > > > { > > > mutex_init(&vc4file->perfmon.lock); > > > - idr_init(&vc4file->perfmon.idr); > > > + idr_init_base(&vc4file->perfmon.idr, VC4_PERFMONID_MIN); > > > } > > > > > > static int vc4_perfmon_idr_del(int id, void *elem, void *data) > > > -- > > > 2.25.1 > > > > Reviewed-by: Eric Anholt <eric@anholt.net> > > > > hopefully Maxime can apply it. > > Applied, thanks! Thank you all. Appreciate your time. ./drv > Maxime _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-08 10:13 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-05 20:21 [PATCH v2] drm/vc4: replace idr_init() by idr_init_base() Deepak R Varma 2020-11-05 20:21 ` Deepak R Varma 2020-11-05 21:24 ` Eric Anholt 2020-11-05 21:24 ` Eric Anholt 2020-11-06 10:52 ` Maxime Ripard 2020-11-06 10:52 ` Maxime Ripard 2020-11-08 10:13 ` Deepak R Varma [this message] 2020-11-08 10:13 ` Deepak R Varma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201108101351.GA41922@localhost \ --to=mh12gx2825@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=eric@anholt.net \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime@cerno.tech \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.