From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Ondrej Jirman <megous@megous.com>,
Peter Chen <peter.chen@nxp.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Anil Varughese <aniljoy@cadence.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Fabio Estevam <festevam@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Chen-Yu Tsai <wens@csie.org>,
bcm-kernel-feedback-list@broadcom.com,
NXP Linux Team <linux-imx@nxp.com>,
Icenowy Zheng <icenowy@aosc.io>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Ray Jui <rjui@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Yue Wang <yue.wang@amlogic.com>, Lubomir Rintel <lkundrak@v3.sk>,
Remi Pommarel <repk@triplefau.lt>,
linux-mediatek@lists.infradead.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Ma Feng <mafeng.ma@huawei.com>,
Scott Branden <sbranden@broadcom.com>,
Randy Dunlap <rdunlap@infradead.org>, Jyri Sarha <jsarha@ti.com>,
linux-kernel@vger.kernel.org, Sanket Parmar <sparmar@cadence.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Joe Perches <joe@perches.com>,
Colin Ian King <colin.king@canonical.com>,
Shawn Guo <shawnguo@kernel.org>, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v2 07/17] phy: marvell: convert to devm_platform_ioremap_resource
Date: Mon, 9 Nov 2020 10:04:23 +0800 [thread overview]
Message-ID: <20201109100423.0d734ec3@xhacker.debian> (raw)
In-Reply-To: <1604642930-29019-7-git-send-email-chunfeng.yun@mediatek.com>
On Fri, 6 Nov 2020 14:08:40 +0800 Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: no changes
> ---
> drivers/phy/marvell/phy-armada375-usb2.c | 4 +---
> drivers/phy/marvell/phy-berlin-usb.c | 4 +---
For phy-berlin-usb.c,
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> drivers/phy/marvell/phy-mmp3-usb.c | 4 +---
> drivers/phy/marvell/phy-mvebu-sata.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-hsic.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-usb2.c | 4 +---
> drivers/phy/marvell/phy-pxa-usb.c | 4 +---
> 7 files changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-armada375-usb2.c b/drivers/phy/marvell/phy-armada375-usb2.c
> index fa5dc9462d09..b141e3cd8a94 100644
> --- a/drivers/phy/marvell/phy-armada375-usb2.c
> +++ b/drivers/phy/marvell/phy-armada375-usb2.c
> @@ -105,15 +105,13 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
> struct phy *phy;
> struct phy_provider *phy_provider;
> void __iomem *usb_cluster_base;
> - struct resource *res;
> struct armada375_cluster_phy *cluster_phy;
>
> cluster_phy = devm_kzalloc(dev, sizeof(*cluster_phy), GFP_KERNEL);
> if (!cluster_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
> + usb_cluster_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb_cluster_base))
> return PTR_ERR(usb_cluster_base);
>
> diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy/marvell/phy-berlin-usb.c
> index a43df63007c5..78ef6ae72a9a 100644
> --- a/drivers/phy/marvell/phy-berlin-usb.c
> +++ b/drivers/phy/marvell/phy-berlin-usb.c
> @@ -165,7 +165,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> const struct of_device_id *match =
> of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> - struct resource *res;
> struct phy *phy;
> struct phy_provider *phy_provider;
>
> @@ -173,8 +172,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-mmp3-usb.c b/drivers/phy/marvell/phy-mmp3-usb.c
> index 499869595a58..04c0bada3519 100644
> --- a/drivers/phy/marvell/phy-mmp3-usb.c
> +++ b/drivers/phy/marvell/phy-mmp3-usb.c
> @@ -246,7 +246,6 @@ MODULE_DEVICE_TABLE(of, mmp3_usb_phy_of_match);
> static int mmp3_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct mmp3_usb_phy *mmp3_usb_phy;
> struct phy_provider *provider;
>
> @@ -254,8 +253,7 @@ static int mmp3_usb_phy_probe(struct platform_device *pdev)
> if (!mmp3_usb_phy)
> return -ENOMEM;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mmp3_usb_phy->base = devm_ioremap_resource(dev, resource);
> + mmp3_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmp3_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(mmp3_usb_phy->base);
> diff --git a/drivers/phy/marvell/phy-mvebu-sata.c b/drivers/phy/marvell/phy-mvebu-sata.c
> index 3c01b5dceaae..51a4646e2933 100644
> --- a/drivers/phy/marvell/phy-mvebu-sata.c
> +++ b/drivers/phy/marvell/phy-mvebu-sata.c
> @@ -80,7 +80,6 @@ static const struct phy_ops phy_mvebu_sata_ops = {
> static int phy_mvebu_sata_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct priv *priv;
> struct phy *phy;
>
> @@ -88,8 +87,7 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-hsic.c b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> index 31b43d2ee39a..c5c100563f55 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> @@ -162,7 +162,6 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_hsic_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -176,8 +175,7 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-usb2.c b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> index a175ae915f02..0b390b9d2ae1 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> @@ -294,7 +294,6 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_usb2_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -308,8 +307,7 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-usb.c b/drivers/phy/marvell/phy-pxa-usb.c
> index 87ff7550b912..ffe889893ff4 100644
> --- a/drivers/phy/marvell/phy-pxa-usb.c
> +++ b/drivers/phy/marvell/phy-pxa-usb.c
> @@ -286,7 +286,6 @@ MODULE_DEVICE_TABLE(of, pxa_usb_phy_of_match);
> static int pxa_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct pxa_usb_phy *pxa_usb_phy;
> struct phy_provider *provider;
> const struct of_device_id *of_id;
> @@ -301,8 +300,7 @@ static int pxa_usb_phy_probe(struct platform_device *pdev)
> else
> pxa_usb_phy->version = PXA_USB_PHY_MMP2;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pxa_usb_phy->base = devm_ioremap_resource(dev, resource);
> + pxa_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pxa_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(pxa_usb_phy->base);
> --
> 2.18.0
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
>
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Ondrej Jirman <megous@megous.com>,
Peter Chen <peter.chen@nxp.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Anil Varughese <aniljoy@cadence.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Fabio Estevam <festevam@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chen-Yu Tsai <wens@csie.org>, Sanket Parmar <sparmar@cadence.com>,
bcm-kernel-feedback-list@broadcom.com,
NXP Linux Team <linux-imx@nxp.com>,
Icenowy Zheng <icenowy@aosc.io>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Yue Wang <yue.wang@amlogic.com>, Lubomir Rintel <lkundrak@v3.sk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-mediatek@lists.infradead.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Ma Feng <mafeng.ma@huawei.com>,
Scott Branden <sbranden@broadcom.com>,
Randy Dunlap <rdunlap@infradead.org>, Jyri Sarha <jsarha@ti.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Remi Pommarel <repk@triplefau.lt>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Joe Perches <joe@perches.com>,
Colin Ian King <colin.king@canonical.com>,
Shawn Guo <shawnguo@kernel.org>, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v2 07/17] phy: marvell: convert to devm_platform_ioremap_resource
Date: Mon, 9 Nov 2020 10:04:23 +0800 [thread overview]
Message-ID: <20201109100423.0d734ec3@xhacker.debian> (raw)
In-Reply-To: <1604642930-29019-7-git-send-email-chunfeng.yun@mediatek.com>
On Fri, 6 Nov 2020 14:08:40 +0800 Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: no changes
> ---
> drivers/phy/marvell/phy-armada375-usb2.c | 4 +---
> drivers/phy/marvell/phy-berlin-usb.c | 4 +---
For phy-berlin-usb.c,
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> drivers/phy/marvell/phy-mmp3-usb.c | 4 +---
> drivers/phy/marvell/phy-mvebu-sata.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-hsic.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-usb2.c | 4 +---
> drivers/phy/marvell/phy-pxa-usb.c | 4 +---
> 7 files changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-armada375-usb2.c b/drivers/phy/marvell/phy-armada375-usb2.c
> index fa5dc9462d09..b141e3cd8a94 100644
> --- a/drivers/phy/marvell/phy-armada375-usb2.c
> +++ b/drivers/phy/marvell/phy-armada375-usb2.c
> @@ -105,15 +105,13 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
> struct phy *phy;
> struct phy_provider *phy_provider;
> void __iomem *usb_cluster_base;
> - struct resource *res;
> struct armada375_cluster_phy *cluster_phy;
>
> cluster_phy = devm_kzalloc(dev, sizeof(*cluster_phy), GFP_KERNEL);
> if (!cluster_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
> + usb_cluster_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb_cluster_base))
> return PTR_ERR(usb_cluster_base);
>
> diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy/marvell/phy-berlin-usb.c
> index a43df63007c5..78ef6ae72a9a 100644
> --- a/drivers/phy/marvell/phy-berlin-usb.c
> +++ b/drivers/phy/marvell/phy-berlin-usb.c
> @@ -165,7 +165,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> const struct of_device_id *match =
> of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> - struct resource *res;
> struct phy *phy;
> struct phy_provider *phy_provider;
>
> @@ -173,8 +172,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-mmp3-usb.c b/drivers/phy/marvell/phy-mmp3-usb.c
> index 499869595a58..04c0bada3519 100644
> --- a/drivers/phy/marvell/phy-mmp3-usb.c
> +++ b/drivers/phy/marvell/phy-mmp3-usb.c
> @@ -246,7 +246,6 @@ MODULE_DEVICE_TABLE(of, mmp3_usb_phy_of_match);
> static int mmp3_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct mmp3_usb_phy *mmp3_usb_phy;
> struct phy_provider *provider;
>
> @@ -254,8 +253,7 @@ static int mmp3_usb_phy_probe(struct platform_device *pdev)
> if (!mmp3_usb_phy)
> return -ENOMEM;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mmp3_usb_phy->base = devm_ioremap_resource(dev, resource);
> + mmp3_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmp3_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(mmp3_usb_phy->base);
> diff --git a/drivers/phy/marvell/phy-mvebu-sata.c b/drivers/phy/marvell/phy-mvebu-sata.c
> index 3c01b5dceaae..51a4646e2933 100644
> --- a/drivers/phy/marvell/phy-mvebu-sata.c
> +++ b/drivers/phy/marvell/phy-mvebu-sata.c
> @@ -80,7 +80,6 @@ static const struct phy_ops phy_mvebu_sata_ops = {
> static int phy_mvebu_sata_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct priv *priv;
> struct phy *phy;
>
> @@ -88,8 +87,7 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-hsic.c b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> index 31b43d2ee39a..c5c100563f55 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> @@ -162,7 +162,6 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_hsic_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -176,8 +175,7 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-usb2.c b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> index a175ae915f02..0b390b9d2ae1 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> @@ -294,7 +294,6 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_usb2_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -308,8 +307,7 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-usb.c b/drivers/phy/marvell/phy-pxa-usb.c
> index 87ff7550b912..ffe889893ff4 100644
> --- a/drivers/phy/marvell/phy-pxa-usb.c
> +++ b/drivers/phy/marvell/phy-pxa-usb.c
> @@ -286,7 +286,6 @@ MODULE_DEVICE_TABLE(of, pxa_usb_phy_of_match);
> static int pxa_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct pxa_usb_phy *pxa_usb_phy;
> struct phy_provider *provider;
> const struct of_device_id *of_id;
> @@ -301,8 +300,7 @@ static int pxa_usb_phy_probe(struct platform_device *pdev)
> else
> pxa_usb_phy->version = PXA_USB_PHY_MMP2;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pxa_usb_phy->base = devm_ioremap_resource(dev, resource);
> + pxa_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pxa_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(pxa_usb_phy->base);
> --
> 2.18.0
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Ondrej Jirman <megous@megous.com>,
Peter Chen <peter.chen@nxp.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Anil Varughese <aniljoy@cadence.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Fabio Estevam <festevam@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chen-Yu Tsai <wens@csie.org>, Sanket Parmar <sparmar@cadence.com>,
bcm-kernel-feedback-list@broadcom.com,
NXP Linux Team <linux-imx@nxp.com>,
Icenowy Zheng <icenowy@aosc.io>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Yue Wang <yue.wang@amlogic.com>, Lubomir Rintel <lkundrak@v3.sk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-mediatek@lists.infradead.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Ma Feng <mafeng.ma@huawei.com>,
Scott Branden <sbranden@broadcom.com>,
Randy Dunlap <rdunlap@infradead.org>, Jyri Sarha <jsarha@ti.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Remi Pommarel <repk@triplefau.lt>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Joe Perches <joe@perches.com>,
Colin Ian King <colin.king@canonical.com>,
Shawn Guo <shawnguo@kernel.org>, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v2 07/17] phy: marvell: convert to devm_platform_ioremap_resource
Date: Mon, 9 Nov 2020 10:04:23 +0800 [thread overview]
Message-ID: <20201109100423.0d734ec3@xhacker.debian> (raw)
In-Reply-To: <1604642930-29019-7-git-send-email-chunfeng.yun@mediatek.com>
On Fri, 6 Nov 2020 14:08:40 +0800 Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: no changes
> ---
> drivers/phy/marvell/phy-armada375-usb2.c | 4 +---
> drivers/phy/marvell/phy-berlin-usb.c | 4 +---
For phy-berlin-usb.c,
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> drivers/phy/marvell/phy-mmp3-usb.c | 4 +---
> drivers/phy/marvell/phy-mvebu-sata.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-hsic.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-usb2.c | 4 +---
> drivers/phy/marvell/phy-pxa-usb.c | 4 +---
> 7 files changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-armada375-usb2.c b/drivers/phy/marvell/phy-armada375-usb2.c
> index fa5dc9462d09..b141e3cd8a94 100644
> --- a/drivers/phy/marvell/phy-armada375-usb2.c
> +++ b/drivers/phy/marvell/phy-armada375-usb2.c
> @@ -105,15 +105,13 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
> struct phy *phy;
> struct phy_provider *phy_provider;
> void __iomem *usb_cluster_base;
> - struct resource *res;
> struct armada375_cluster_phy *cluster_phy;
>
> cluster_phy = devm_kzalloc(dev, sizeof(*cluster_phy), GFP_KERNEL);
> if (!cluster_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
> + usb_cluster_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb_cluster_base))
> return PTR_ERR(usb_cluster_base);
>
> diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy/marvell/phy-berlin-usb.c
> index a43df63007c5..78ef6ae72a9a 100644
> --- a/drivers/phy/marvell/phy-berlin-usb.c
> +++ b/drivers/phy/marvell/phy-berlin-usb.c
> @@ -165,7 +165,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> const struct of_device_id *match =
> of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> - struct resource *res;
> struct phy *phy;
> struct phy_provider *phy_provider;
>
> @@ -173,8 +172,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-mmp3-usb.c b/drivers/phy/marvell/phy-mmp3-usb.c
> index 499869595a58..04c0bada3519 100644
> --- a/drivers/phy/marvell/phy-mmp3-usb.c
> +++ b/drivers/phy/marvell/phy-mmp3-usb.c
> @@ -246,7 +246,6 @@ MODULE_DEVICE_TABLE(of, mmp3_usb_phy_of_match);
> static int mmp3_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct mmp3_usb_phy *mmp3_usb_phy;
> struct phy_provider *provider;
>
> @@ -254,8 +253,7 @@ static int mmp3_usb_phy_probe(struct platform_device *pdev)
> if (!mmp3_usb_phy)
> return -ENOMEM;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mmp3_usb_phy->base = devm_ioremap_resource(dev, resource);
> + mmp3_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmp3_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(mmp3_usb_phy->base);
> diff --git a/drivers/phy/marvell/phy-mvebu-sata.c b/drivers/phy/marvell/phy-mvebu-sata.c
> index 3c01b5dceaae..51a4646e2933 100644
> --- a/drivers/phy/marvell/phy-mvebu-sata.c
> +++ b/drivers/phy/marvell/phy-mvebu-sata.c
> @@ -80,7 +80,6 @@ static const struct phy_ops phy_mvebu_sata_ops = {
> static int phy_mvebu_sata_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct priv *priv;
> struct phy *phy;
>
> @@ -88,8 +87,7 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-hsic.c b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> index 31b43d2ee39a..c5c100563f55 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> @@ -162,7 +162,6 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_hsic_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -176,8 +175,7 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-usb2.c b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> index a175ae915f02..0b390b9d2ae1 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> @@ -294,7 +294,6 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_usb2_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -308,8 +307,7 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-usb.c b/drivers/phy/marvell/phy-pxa-usb.c
> index 87ff7550b912..ffe889893ff4 100644
> --- a/drivers/phy/marvell/phy-pxa-usb.c
> +++ b/drivers/phy/marvell/phy-pxa-usb.c
> @@ -286,7 +286,6 @@ MODULE_DEVICE_TABLE(of, pxa_usb_phy_of_match);
> static int pxa_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct pxa_usb_phy *pxa_usb_phy;
> struct phy_provider *provider;
> const struct of_device_id *of_id;
> @@ -301,8 +300,7 @@ static int pxa_usb_phy_probe(struct platform_device *pdev)
> else
> pxa_usb_phy->version = PXA_USB_PHY_MMP2;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pxa_usb_phy->base = devm_ioremap_resource(dev, resource);
> + pxa_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pxa_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(pxa_usb_phy->base);
> --
> 2.18.0
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Ondrej Jirman <megous@megous.com>,
Peter Chen <peter.chen@nxp.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Anil Varughese <aniljoy@cadence.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
Fabio Estevam <festevam@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chen-Yu Tsai <wens@csie.org>, Sanket Parmar <sparmar@cadence.com>,
bcm-kernel-feedback-list@broadcom.com,
NXP Linux Team <linux-imx@nxp.com>,
Icenowy Zheng <icenowy@aosc.io>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Maxime Ripard <mripard@kernel.org>,
Yue Wang <yue.wang@amlogic.com>, Lubomir Rintel <lkundrak@v3.sk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-mediatek@lists.infradead.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Ma Feng <mafeng.ma@huawei.com>,
Scott Branden <sbranden@broadcom.com>,
Randy Dunlap <rdunlap@infradead.org>, Jyri Sarha <jsarha@ti.com>,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Remi Pommarel <repk@triplefau.lt>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Joe Perches <joe@perches.com>,
Colin Ian King <colin.king@canonical.com>,
Shawn Guo <shawnguo@kernel.org>, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v2 07/17] phy: marvell: convert to devm_platform_ioremap_resource
Date: Mon, 9 Nov 2020 10:04:23 +0800 [thread overview]
Message-ID: <20201109100423.0d734ec3@xhacker.debian> (raw)
In-Reply-To: <1604642930-29019-7-git-send-email-chunfeng.yun@mediatek.com>
On Fri, 6 Nov 2020 14:08:40 +0800 Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2: no changes
> ---
> drivers/phy/marvell/phy-armada375-usb2.c | 4 +---
> drivers/phy/marvell/phy-berlin-usb.c | 4 +---
For phy-berlin-usb.c,
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> drivers/phy/marvell/phy-mmp3-usb.c | 4 +---
> drivers/phy/marvell/phy-mvebu-sata.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-hsic.c | 4 +---
> drivers/phy/marvell/phy-pxa-28nm-usb2.c | 4 +---
> drivers/phy/marvell/phy-pxa-usb.c | 4 +---
> 7 files changed, 7 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-armada375-usb2.c b/drivers/phy/marvell/phy-armada375-usb2.c
> index fa5dc9462d09..b141e3cd8a94 100644
> --- a/drivers/phy/marvell/phy-armada375-usb2.c
> +++ b/drivers/phy/marvell/phy-armada375-usb2.c
> @@ -105,15 +105,13 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
> struct phy *phy;
> struct phy_provider *phy_provider;
> void __iomem *usb_cluster_base;
> - struct resource *res;
> struct armada375_cluster_phy *cluster_phy;
>
> cluster_phy = devm_kzalloc(dev, sizeof(*cluster_phy), GFP_KERNEL);
> if (!cluster_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
> + usb_cluster_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usb_cluster_base))
> return PTR_ERR(usb_cluster_base);
>
> diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy/marvell/phy-berlin-usb.c
> index a43df63007c5..78ef6ae72a9a 100644
> --- a/drivers/phy/marvell/phy-berlin-usb.c
> +++ b/drivers/phy/marvell/phy-berlin-usb.c
> @@ -165,7 +165,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> const struct of_device_id *match =
> of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> - struct resource *res;
> struct phy *phy;
> struct phy_provider *phy_provider;
>
> @@ -173,8 +172,7 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-mmp3-usb.c b/drivers/phy/marvell/phy-mmp3-usb.c
> index 499869595a58..04c0bada3519 100644
> --- a/drivers/phy/marvell/phy-mmp3-usb.c
> +++ b/drivers/phy/marvell/phy-mmp3-usb.c
> @@ -246,7 +246,6 @@ MODULE_DEVICE_TABLE(of, mmp3_usb_phy_of_match);
> static int mmp3_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct mmp3_usb_phy *mmp3_usb_phy;
> struct phy_provider *provider;
>
> @@ -254,8 +253,7 @@ static int mmp3_usb_phy_probe(struct platform_device *pdev)
> if (!mmp3_usb_phy)
> return -ENOMEM;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mmp3_usb_phy->base = devm_ioremap_resource(dev, resource);
> + mmp3_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mmp3_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(mmp3_usb_phy->base);
> diff --git a/drivers/phy/marvell/phy-mvebu-sata.c b/drivers/phy/marvell/phy-mvebu-sata.c
> index 3c01b5dceaae..51a4646e2933 100644
> --- a/drivers/phy/marvell/phy-mvebu-sata.c
> +++ b/drivers/phy/marvell/phy-mvebu-sata.c
> @@ -80,7 +80,6 @@ static const struct phy_ops phy_mvebu_sata_ops = {
> static int phy_mvebu_sata_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct priv *priv;
> struct phy *phy;
>
> @@ -88,8 +87,7 @@ static int phy_mvebu_sata_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-hsic.c b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> index 31b43d2ee39a..c5c100563f55 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-hsic.c
> @@ -162,7 +162,6 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_hsic_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -176,8 +175,7 @@ static int mv_hsic_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-28nm-usb2.c b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> index a175ae915f02..0b390b9d2ae1 100644
> --- a/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> +++ b/drivers/phy/marvell/phy-pxa-28nm-usb2.c
> @@ -294,7 +294,6 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct mv_usb2_phy *mv_phy;
> - struct resource *r;
>
> mv_phy = devm_kzalloc(&pdev->dev, sizeof(*mv_phy), GFP_KERNEL);
> if (!mv_phy)
> @@ -308,8 +307,7 @@ static int mv_usb2_phy_probe(struct platform_device *pdev)
> return PTR_ERR(mv_phy->clk);
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mv_phy->base = devm_ioremap_resource(&pdev->dev, r);
> + mv_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mv_phy->base))
> return PTR_ERR(mv_phy->base);
>
> diff --git a/drivers/phy/marvell/phy-pxa-usb.c b/drivers/phy/marvell/phy-pxa-usb.c
> index 87ff7550b912..ffe889893ff4 100644
> --- a/drivers/phy/marvell/phy-pxa-usb.c
> +++ b/drivers/phy/marvell/phy-pxa-usb.c
> @@ -286,7 +286,6 @@ MODULE_DEVICE_TABLE(of, pxa_usb_phy_of_match);
> static int pxa_usb_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *resource;
> struct pxa_usb_phy *pxa_usb_phy;
> struct phy_provider *provider;
> const struct of_device_id *of_id;
> @@ -301,8 +300,7 @@ static int pxa_usb_phy_probe(struct platform_device *pdev)
> else
> pxa_usb_phy->version = PXA_USB_PHY_MMP2;
>
> - resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pxa_usb_phy->base = devm_ioremap_resource(dev, resource);
> + pxa_usb_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(pxa_usb_phy->base)) {
> dev_err(dev, "failed to remap PHY regs\n");
> return PTR_ERR(pxa_usb_phy->base);
> --
> 2.18.0
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-11-09 2:04 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 6:08 [PATCH v2 01/17] phy: allwinner: convert to devm_platform_ioremap_resource(_byname) Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 02/17] phy: amlogic: convert to devm_platform_ioremap_resource Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-08 22:11 ` Martin Blumenstingl
2020-11-08 22:11 ` Martin Blumenstingl
2020-11-08 22:11 ` Martin Blumenstingl
2020-11-06 6:08 ` [PATCH v2 03/17] phy: broadcom: convert to devm_platform_ioremap_resource(_byname) Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 04/17] phy: cadence: convert to devm_platform_ioremap_resource Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 05/17] phy: freescale: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 06/17] phy: lantiq: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-08 22:10 ` Martin Blumenstingl
2020-11-06 6:08 ` [PATCH v2 07/17] phy: marvell: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-09 2:04 ` Jisheng Zhang [this message]
2020-11-09 2:04 ` Jisheng Zhang
2020-11-09 2:04 ` Jisheng Zhang
2020-11-09 2:04 ` Jisheng Zhang
2020-11-06 6:08 ` [PATCH v2 08/17] phy: phy-xgene: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 09/17] phy: phy-mtk-ufs: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 10/17] phy: qualcomm: convert to devm_platform_ioremap_resource(_byname) Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 11/17] phy: phy-ralink-usb: convert to devm_platform_ioremap_resource Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 12/17] phy: renesas: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 13/17] phy: rockchip: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 14/17] phy: samsung: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 15/17] phy: phy-stm32-usbphyc: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 16/17] phy: tegra: convert to devm_platform_ioremap_resource(_byname) Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` [PATCH v2 17/17] phy: ti: " Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-06 6:08 ` Chunfeng Yun
2020-11-16 7:19 ` [PATCH v2 01/17] phy: allwinner: " Vinod Koul
2020-11-16 7:19 ` Vinod Koul
2020-11-16 7:19 ` Vinod Koul
2020-11-16 7:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109100423.0d734ec3@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=aniljoy@cadence.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.gooty@broadcom.com \
--cc=chunfeng.yun@mediatek.com \
--cc=colin.king@canonical.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=hanjie.lin@amlogic.com \
--cc=icenowy@aosc.io \
--cc=jbrunet@baylibre.com \
--cc=joe@perches.com \
--cc=jsarha@ti.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mafeng.ma@huawei.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=peter.chen@nxp.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=rdunlap@infradead.org \
--cc=repk@triplefau.lt \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sparmar@cadence.com \
--cc=vkoul@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=wens@csie.org \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.