From: Daniel Vetter <daniel@ffwll.ch>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peilin Ye <yepeilin.cs@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Jiri Slaby <jirislaby@kernel.org>,
Thomas Winischhofer <thomas@winischhofer.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Nicolas Pitre <nico@fluxnic.net>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
George Kennedy <george.kennedy@oracle.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations
Date: Tue, 10 Nov 2020 13:49:46 +0100 [thread overview]
Message-ID: <20201110124946.GF401619@phenom.ffwll.local> (raw)
In-Reply-To: <20201106105058.GA2801856@kroah.com>
On Fri, Nov 06, 2020 at 11:50:58AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote:
> > `struct console_font` is a UAPI structure, thus ideally should not be
> > used for kernel internal abstraction. Remove some dummy .con_font_set,
> > .con_font_default and .con_font_copy `struct consw` callback
> > implementations, to make it cleaner.
> >
> > Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()"
> > depends on this patch, so Cc: stable.
> >
> > Cc: stable@vger.kernel.org
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
> > ---
> > Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@mail.gmail.com/
> >
> > drivers/usb/misc/sisusbvga/sisusb_con.c | 21 ---------------------
> > drivers/video/console/dummycon.c | 20 --------------------
> > 2 files changed, 41 deletions(-)
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peilin, can you pls resend this together with all the other pending
patches from you? I think that's better than me trying to cherry-pick the
bits we decided to keep from random places.
Greg, ok if I just pull these in through drm-misc-next? It's a pretty bad
hairball anyway and that avoids the tree coordination issues. Only thing
that might get in the way is the vt font_copy removal, but that's in -rc3
so easy to backmerge.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org,
Nicolas Pitre <nico@fluxnic.net>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Thomas Winischhofer <thomas@winischhofer.net>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
dri-devel@lists.freedesktop.org, Peter Rosin <peda@axentia.se>,
George Kennedy <george.kennedy@oracle.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>,
Peilin Ye <yepeilin.cs@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] console: Remove dummy con_font_op() callback implementations
Date: Tue, 10 Nov 2020 13:49:46 +0100 [thread overview]
Message-ID: <20201110124946.GF401619@phenom.ffwll.local> (raw)
In-Reply-To: <20201106105058.GA2801856@kroah.com>
On Fri, Nov 06, 2020 at 11:50:58AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Oct 31, 2020 at 03:24:41AM -0400, Peilin Ye wrote:
> > `struct console_font` is a UAPI structure, thus ideally should not be
> > used for kernel internal abstraction. Remove some dummy .con_font_set,
> > .con_font_default and .con_font_copy `struct consw` callback
> > implementations, to make it cleaner.
> >
> > Patch "fbcon: Prevent global-out-of-bounds read in fbcon_copy_font()"
> > depends on this patch, so Cc: stable.
> >
> > Cc: stable@vger.kernel.org
> > Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> > Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
> > ---
> > Context: https://lore.kernel.org/lkml/CAKMK7uFY2zv0adjKJ_ORVFT7Zzwn075MaU0rEU7_FuqENLR=UA@mail.gmail.com/
> >
> > drivers/usb/misc/sisusbvga/sisusb_con.c | 21 ---------------------
> > drivers/video/console/dummycon.c | 20 --------------------
> > 2 files changed, 41 deletions(-)
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Peilin, can you pls resend this together with all the other pending
patches from you? I think that's better than me trying to cherry-pick the
bits we decided to keep from random places.
Greg, ok if I just pull these in through drm-misc-next? It's a pretty bad
hairball anyway and that avoids the tree coordination issues. Only thing
that might get in the way is the vt font_copy removal, but that's in -rc3
so easy to backmerge.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-10 12:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 7:24 [PATCH 1/2] console: Remove dummy con_font_op() callback implementations Peilin Ye
2020-10-31 7:24 ` Peilin Ye
2020-10-31 7:27 ` [PATCH 2/2] fbcon: Prevent global-out-of-bounds read in fbcon_copy_font() Peilin Ye
2020-10-31 7:27 ` Peilin Ye
2020-11-02 2:51 ` kernel test robot
2020-11-02 9:36 ` [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations Peilin Ye
2020-11-02 9:36 ` Peilin Ye
2020-11-02 9:37 ` [PATCH v2 2/2] tty/vt: Avoid passing struct console_font_op to con_font_copy() Peilin Ye
2020-11-02 9:37 ` Peilin Ye
2020-11-02 10:10 ` Daniel Vetter
2020-11-02 10:10 ` Daniel Vetter
2020-11-02 11:12 ` Peilin Ye
2020-11-02 11:12 ` Peilin Ye
2020-11-02 11:30 ` Daniel Vetter
2020-11-02 11:30 ` Daniel Vetter
2020-11-02 9:47 ` [PATCH v2 1/2] console: Remove dummy con_font_op() callback implementations Jiri Slaby
2020-11-02 9:47 ` Jiri Slaby
2020-11-02 10:13 ` Daniel Vetter
2020-11-02 10:13 ` Daniel Vetter
2020-11-02 10:52 ` Peilin Ye
2020-11-02 10:52 ` Peilin Ye
2020-11-06 10:50 ` [PATCH " Greg Kroah-Hartman
2020-11-06 10:50 ` Greg Kroah-Hartman
2020-11-10 12:49 ` Daniel Vetter [this message]
2020-11-10 12:49 ` Daniel Vetter
2020-11-10 13:24 ` Peilin Ye
2020-11-10 13:24 ` Peilin Ye
2020-11-10 13:46 ` Daniel Vetter
2020-11-10 13:46 ` Daniel Vetter
2020-11-10 13:55 ` Peilin Ye
2020-11-10 13:55 ` Peilin Ye
2020-11-10 14:56 ` Greg Kroah-Hartman
2020-11-10 14:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110124946.GF401619@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=nico@fluxnic.net \
--cc=peda@axentia.se \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=thomas@winischhofer.net \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.