From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
"K. Merker" <merker@debian.org>, authored by <andrew@goodix.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-input@vger.kernel.org
Subject: [PATCH 04/15] input: touchscreen: goodix: Provide some missing function parameter descriptions
Date: Thu, 12 Nov 2020 11:01:53 +0000 [thread overview]
Message-ID: <20201112110204.2083435-5-lee.jones@linaro.org> (raw)
In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/goodix.c:569: warning: Function parameter or member 'len' not described in 'goodix_check_cfg'
drivers/input/touchscreen/goodix.c:587: warning: Function parameter or member 'len' not described in 'goodix_send_cfg'
drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'cfg' not described in 'goodix_config_cb'
drivers/input/touchscreen/goodix.c:1165: warning: Function parameter or member 'ctx' not described in 'goodix_config_cb'
drivers/input/touchscreen/goodix.c:1165: warning: Excess function parameter 'ts' description in 'goodix_config_cb'
Cc: Bastien Nocera <hadess@hadess.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: "K. Merker" <merker@debian.org>
Cc: authored by <andrew@goodix.com>
Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/goodix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 02c75ea385e08..80a82a66a0f3b 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -564,6 +564,7 @@ static void goodix_calc_cfg_checksum_16(struct goodix_ts_data *ts)
*
* @ts: goodix_ts_data pointer
* @cfg: firmware config data
+ * @len: config data length
*/
static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)
{
@@ -582,6 +583,7 @@ static int goodix_check_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)
*
* @ts: goodix_ts_data pointer
* @cfg: config firmware to write to device
+ * @len: config data length
*/
static int goodix_send_cfg(struct goodix_ts_data *ts, const u8 *cfg, int len)
{
@@ -1156,6 +1158,7 @@ static int goodix_configure_dev(struct goodix_ts_data *ts)
/**
* goodix_config_cb - Callback to finish device init
*
+ * @cfg: firmware config
* @ts: our goodix_ts_data pointer
*
* request_firmware_wait callback that finishes
--
2.25.1
next prev parent reply other threads:[~2020-11-12 11:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 11:01 [PATCH 00/15] [Set 2/2] Rid W=1 issues from Input Lee Jones
2020-11-12 11:01 ` [PATCH 01/15] input: joystick: xpad: Demote non-conformant kernel-doc header Lee Jones
2020-11-20 3:16 ` Dmitry Torokhov
2020-11-12 11:01 ` [PATCH 02/15] input: keyboard: samsung-keypad: Remove set but unused variable 'var' Lee Jones
2020-11-13 7:37 ` Dmitry Torokhov
2020-11-12 11:01 ` [PATCH 03/15] input: misc: mc13783-pwrbutton: File headers are not good candidates for kernel-doc Lee Jones
2020-11-20 3:16 ` Dmitry Torokhov
2020-11-12 11:01 ` Lee Jones [this message]
2020-11-20 3:16 ` [PATCH 04/15] input: touchscreen: goodix: Provide some missing function parameter descriptions Dmitry Torokhov
2020-11-12 11:01 ` [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused variable 'value' Lee Jones
2020-11-12 12:20 ` Bough Chen
2020-11-13 7:37 ` Dmitry Torokhov
2020-11-19 9:12 ` Lee Jones
2020-11-12 11:01 ` [PATCH 06/15] input: touchscreen: melfas_mip4: Remove a bunch of unused variables Lee Jones
2020-11-13 7:42 ` Dmitry Torokhov
2020-11-13 7:55 ` Lee Jones
2020-11-20 3:09 ` Dmitry Torokhov
2020-11-20 7:45 ` Lee Jones
2020-11-12 11:01 ` [PATCH 07/15] input: touchscreen: usbtouchscreen: Remove unused variable 'ret' Lee Jones
2020-11-13 7:36 ` Dmitry Torokhov
2020-11-13 7:56 ` Lee Jones
2020-11-20 3:09 ` Dmitry Torokhov
2020-11-12 11:01 ` [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
2020-11-13 7:40 ` Dmitry Torokhov
2020-11-13 7:42 ` Benjamin Tissoires
2020-11-15 22:02 ` Peter Hutterer
2020-11-12 11:01 ` [PATCH 09/15] input: misc: wm831x-on: Source file headers are not good candidates for kernel-doc Lee Jones
2020-11-12 11:20 ` Richard Fitzgerald
2020-11-20 3:17 ` Dmitry Torokhov
2020-11-12 11:01 ` [PATCH 10/15] input: touchscreen: surface3_spi: Fix naming issue with 'surface3_spi_get_gpio_config's header Lee Jones
2020-11-20 3:16 ` Dmitry Torokhov
2020-11-12 11:02 ` [PATCH 11/15] input: touchscreen: wm97xx-core: Provide missing description for 'status' Lee Jones
2020-11-12 11:22 ` Richard Fitzgerald
2020-11-20 3:17 ` Dmitry Torokhov
2020-11-12 11:02 ` [PATCH 12/15] input: mouse: synaptics: Demote non-conformant kernel-doc header Lee Jones
2020-11-20 3:18 ` Dmitry Torokhov
2020-11-12 11:02 ` [PATCH 13/15] input: touchscreen: goodix: Fix misspelling of 'ctx' Lee Jones
2020-11-20 3:20 ` Dmitry Torokhov
2020-11-12 11:02 ` [PATCH 14/15] input: keyboard: applespi: Provide missing struct 'message' descriptions Lee Jones
2020-11-20 3:21 ` Dmitry Torokhov
2020-11-12 11:02 ` [PATCH 15/15] input: mouse: vmmouse: Demote obvious abuse of kernel-doc header Lee Jones
2020-11-20 3:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112110204.2083435-5-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=andrew@goodix.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=merker@debian.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.