From: Daniel Vetter <daniel@ffwll.ch> To: Sam Ravnborg <sam@ravnborg.org> Cc: Lee Jones <lee.jones@linaro.org>, David Airlie <airlied@linux.ie>, Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Date: Fri, 13 Nov 2020 21:49:59 +0100 [thread overview] Message-ID: <20201113204959.GW401619@phenom.ffwll.local> (raw) In-Reply-To: <20201112202516.GA3340631@ravnborg.org> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > Hi Lee, > > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > The precedent has already been set by other macros in the same file. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] > > 55 | struct drm_crtc *crtc; > > | ^~~~ > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Also applied to drm-misc-next. > This was the last patch from this batch I will process. > The others are left for the maintainers to pick up. btw for patches that maintainers don't pick up, the usual process is that we give them 2 weeks, then just mass apply. Now you're producing a lot of patches, too much for me to keep track, so please just ping me with a resend for those that expired and I'll go through and pick them all up. Cheers, Daniel > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Sam Ravnborg <sam@ravnborg.org> Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: Re: [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Date: Fri, 13 Nov 2020 21:49:59 +0100 [thread overview] Message-ID: <20201113204959.GW401619@phenom.ffwll.local> (raw) In-Reply-To: <20201112202516.GA3340631@ravnborg.org> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote: > Hi Lee, > > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote: > > The precedent has already been set by other macros in the same file. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set but not used [-Wunused-but-set-variable] > > 55 | struct drm_crtc *crtc; > > | ^~~~ > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <mripard@kernel.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > Cc: Rob Clark <robdclark@gmail.com> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Also applied to drm-misc-next. > This was the last patch from this batch I will process. > The others are left for the maintainers to pick up. btw for patches that maintainers don't pick up, the usual process is that we give them 2 weeks, then just mass apply. Now you're producing a lot of patches, too much for me to keep track, so please just ping me with a resend for those that expired and I'll go through and pick them all up. Cheers, Daniel > > Sam > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-13 20:50 UTC|newest] Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-12 19:00 [PATCH 00/30] [Set 6] Rid W=1 warnings from GPU Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:31 ` Sam Ravnborg 2020-11-12 19:31 ` Sam Ravnborg 2020-11-12 20:08 ` Lee Jones 2020-11-12 20:08 ` Lee Jones 2020-11-12 19:00 ` [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 20:25 ` Sam Ravnborg 2020-11-12 20:25 ` Sam Ravnborg 2020-11-13 20:49 ` Daniel Vetter [this message] 2020-11-13 20:49 ` Daniel Vetter 2020-11-13 20:53 ` Lee Jones 2020-11-13 21:31 ` Daniel Vetter 2020-11-13 21:31 ` Daniel Vetter 2020-11-13 22:01 ` Lee Jones 2020-11-17 10:05 ` Daniel Vetter 2020-11-17 10:05 ` Daniel Vetter 2020-11-17 10:34 ` Lee Jones 2020-11-17 10:34 ` Lee Jones 2020-11-17 10:43 ` Daniel Vetter 2020-11-17 10:43 ` Daniel Vetter 2020-11-17 11:08 ` Lee Jones 2020-11-17 11:08 ` Lee Jones 2020-11-16 17:33 ` Lee Jones 2020-11-16 17:33 ` Lee Jones 2020-11-12 19:00 ` [PATCH 03/30] drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 04/30] drm/via/via_dma: Remove set but unused variable 'agp_base' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 20:27 ` Sam Ravnborg 2020-11-12 20:27 ` Sam Ravnborg 2020-11-12 19:00 ` [PATCH 05/30] drm/v3d/v3d_sched: Demote non-conformant kernel-doc header Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 06/30] drm/amd/amdgpu/amdgpu_kms: Fix misnaming of parameter 'dev' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:08 ` Alex Deucher 2020-11-12 21:08 ` Alex Deucher 2020-11-12 21:08 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 07/30] drm/amd/amdgpu/amdgpu_fence: Fix some issues pertaining to function documentation Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:11 ` Alex Deucher 2020-11-12 21:11 ` Alex Deucher 2020-11-12 21:11 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 08/30] drm/exynos/exynos7_drm_decon: Supply missing description for param 'ctx' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 09/30] drm/exynos/exynos_drm_fimd: Add " Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 10/30] drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 11/30] drm/vc4/vc4_hdmi: Remove set but unused variable 'ret' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 12/30] drm/amd/amdgpu/amdgpu_ttm: Demote non-conformant kernel-doc headers, fix slightly lacking ones Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:22 ` Alex Deucher 2020-11-12 21:22 ` Alex Deucher 2020-11-12 21:22 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 13/30] drm/atmel-hlcdc/atmel_hlcdc_crtc: Apply correct formatting to struct docs Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:00 ` [PATCH 14/30] drm/amd/amdgpu/amdgpu_ring: Fix a bunch of function misdocumentation Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:25 ` Alex Deucher 2020-11-12 21:25 ` Alex Deucher 2020-11-12 21:25 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 15/30] drm/amd/amdgpu/amdgpu_display: Remove pointless header Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:26 ` Alex Deucher 2020-11-12 21:26 ` Alex Deucher 2020-11-12 21:26 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 16/30] drm/atmel-hlcdc/atmel_hlcdc_plane: Staticise local function 'atmel_hlcdc_plane_setup_scaler()' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:00 ` [PATCH 17/30] drm/atmel-hlcdc/atmel_hlcdc_plane: Fix documentation formatting and add missing description Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:29 ` Sam Ravnborg 2020-11-12 19:00 ` [PATCH 18/30] drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 19/30] drm/amd/amdgpu/amdgpu_cs: Add a couple of missing function param descriptions Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:28 ` Alex Deucher 2020-11-12 21:28 ` Alex Deucher 2020-11-12 21:28 ` Alex Deucher 2020-11-12 19:00 ` [PATCH 20/30] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 21/30] drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 22/30] drm/rockchip/dw-mipi-dsi-rockchip: " Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 23/30] drm/rockchip/rockchip_rgb: Consume our own header Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 24/30] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 25/30] drm/rockchip/rockchip_lvds: Fix struct document formatting Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 26/30] drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` [PATCH 27/30] drm/sti/sti_hdmi: Move 'colorspace_mode_names' array to where its used Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 20:22 ` Sam Ravnborg 2020-11-12 20:22 ` Sam Ravnborg 2020-11-12 19:00 ` [PATCH 28/30] drm/mediatek/mtk_disp_color: Fix formatting and provide missing member description Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-23 14:31 ` Chun-Kuang Hu 2020-11-23 14:31 ` Chun-Kuang Hu 2020-11-23 14:31 ` Chun-Kuang Hu 2020-11-23 14:31 ` Chun-Kuang Hu 2020-11-12 19:00 ` [PATCH 29/30] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 21:31 ` Alex Deucher 2020-11-12 21:31 ` Alex Deucher 2020-11-12 21:31 ` Alex Deucher 2020-11-12 22:10 ` Lee Jones 2020-11-12 22:10 ` Lee Jones 2020-11-12 22:10 ` Lee Jones 2020-11-12 19:00 ` [PATCH 30/30] drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member description Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-12 19:00 ` Lee Jones 2020-11-23 14:29 ` Chun-Kuang Hu 2020-11-23 14:29 ` Chun-Kuang Hu 2020-11-23 14:29 ` Chun-Kuang Hu 2020-11-23 14:29 ` Chun-Kuang Hu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201113204959.GW401619@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sam@ravnborg.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.