Re: [Intel-gfx] [PATCH 15/27] drm/i915/pxp: Destroy all type0 sessions upon teardown

From: kernel test robot <lkp@intel.com>
To: Sean Z Huang <sean.z.huang@intel.com>, Intel-gfx@lists.freedesktop.org
Cc: clang-built-linux@googlegroups.com, "Huang,
	Sean Z" <sean.z.huang@intel.com>,
	kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 15/27] drm/i915/pxp: Destroy all type0 sessions upon teardown
Date: Sat, 14 Nov 2020 14:28:25 +0800	[thread overview]
Message-ID: <202011141425.eCM7DFvE-lkp@intel.com> (raw)
In-Reply-To: <20201114014537.25495-15-sean.z.huang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3549 bytes --]

Hi Sean,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-094926
base:    92edc4aef86780a8ad01b092c6d6630bb3cb423d
config: x86_64-randconfig-a004-20201113 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9a85643cd357e412cff69067bb5c4840e228c2ab)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/b2c5c38f134701a462cb7e880c4cebcd79e1d8c6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-094926
        git checkout b2c5c38f134701a462cb7e880c4cebcd79e1d8c6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:175:5: warning: no previous prototype for function 'pxp_sm_reg_read' [-Wmissing-prototypes]
   int pxp_sm_reg_read(struct drm_i915_private *i915, u32 offset, u32 *regval)
       ^
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:175:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pxp_sm_reg_read(struct drm_i915_private *i915, u32 offset, u32 *regval)
   ^
   static 
>> drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:1146:5: warning: no previous prototype for function 'intel_pxp_sm_destroy_all_sw_sessions' [-Wmissing-prototypes]
   int intel_pxp_sm_destroy_all_sw_sessions(struct drm_i915_private *i915, int session_type)
       ^
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:1146:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int intel_pxp_sm_destroy_all_sw_sessions(struct drm_i915_private *i915, int session_type)
   ^
   static 
   2 warnings generated.

vim +/intel_pxp_sm_destroy_all_sw_sessions +1146 drivers/gpu/drm/i915/pxp/intel_pxp_sm.c

  1145	
> 1146	int intel_pxp_sm_destroy_all_sw_sessions(struct drm_i915_private *i915, int session_type)
  1147	{
  1148		int ret = 0;
  1149		struct pxp_protected_session *current_session, *n;
  1150	
  1151		list_for_each_entry_safe(current_session, n, pxp_session_list(i915, session_type), session_list) {
  1152			ret = pxp_set_pxp_tag(i915, session_type, current_session->session_index, PROTECTION_MODE_NONE);
  1153			if (ret)
  1154				drm_dbg(&i915->drm, "Failed to pxp_set_pxp_tag()\n");
  1155	
  1156			list_del(&current_session->session_list);
  1157			kfree(current_session);
  1158		}
  1159	
  1160		return ret;
  1161	}
  1162	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35034 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx