All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
	linux-remoteproc@vger.kernel.org, matthias.bgg@gmail.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, groeck@chromium.org,
	drinkcat@chromium.org, pihsun@chromium.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off
Date: Mon, 16 Nov 2020 13:25:36 -0700	[thread overview]
Message-ID: <20201116202536.GA3892875@xps15> (raw)
In-Reply-To: <20201116082537.3287009-2-tzungbi@google.com>

On Mon, Nov 16, 2020 at 04:25:36PM +0800, Tzung-Bi Shih wrote:
> Fixes the following sparse errors on sram power on and off:
> 
> On drivers/remoteproc/mtk_scp.c:306:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:307:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:314:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:316:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
>  drivers/remoteproc/mtk_scp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 577cbd5d421e..8ed89ea1eb78 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp)
>  	return 0;
>  }
>  
> -static void mt8192_power_on_sram(void *addr)
> +static void mt8192_power_on_sram(void __iomem *addr)
>  {
>  	int i;
>  
> @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr)
>  	writel(0, addr);
>  }
>  
> -static void mt8192_power_off_sram(void *addr)
> +static void mt8192_power_off_sram(void __iomem *addr)

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  {
>  	int i;
>  
> -- 
> 2.29.2.299.gdc1121823c-goog
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ohad@wizery.com, drinkcat@chromium.org,
	kernel test robot <lkp@intel.com>,
	linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org,
	groeck@chromium.org, linux-mediatek@lists.infradead.org,
	pihsun@chromium.org, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off
Date: Mon, 16 Nov 2020 13:25:36 -0700	[thread overview]
Message-ID: <20201116202536.GA3892875@xps15> (raw)
In-Reply-To: <20201116082537.3287009-2-tzungbi@google.com>

On Mon, Nov 16, 2020 at 04:25:36PM +0800, Tzung-Bi Shih wrote:
> Fixes the following sparse errors on sram power on and off:
> 
> On drivers/remoteproc/mtk_scp.c:306:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:307:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:314:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:316:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
>  drivers/remoteproc/mtk_scp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 577cbd5d421e..8ed89ea1eb78 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp)
>  	return 0;
>  }
>  
> -static void mt8192_power_on_sram(void *addr)
> +static void mt8192_power_on_sram(void __iomem *addr)
>  {
>  	int i;
>  
> @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr)
>  	writel(0, addr);
>  }
>  
> -static void mt8192_power_off_sram(void *addr)
> +static void mt8192_power_off_sram(void __iomem *addr)

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  {
>  	int i;
>  
> -- 
> 2.29.2.299.gdc1121823c-goog
> 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ohad@wizery.com, drinkcat@chromium.org,
	kernel test robot <lkp@intel.com>,
	linux-remoteproc@vger.kernel.org, bjorn.andersson@linaro.org,
	groeck@chromium.org, linux-mediatek@lists.infradead.org,
	pihsun@chromium.org, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off
Date: Mon, 16 Nov 2020 13:25:36 -0700	[thread overview]
Message-ID: <20201116202536.GA3892875@xps15> (raw)
In-Reply-To: <20201116082537.3287009-2-tzungbi@google.com>

On Mon, Nov 16, 2020 at 04:25:36PM +0800, Tzung-Bi Shih wrote:
> Fixes the following sparse errors on sram power on and off:
> 
> On drivers/remoteproc/mtk_scp.c:306:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:307:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:314:9:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> On drivers/remoteproc/mtk_scp.c:316:17:
> warning: incorrect type in argument 2 (different address spaces)
>    expected void volatile [noderef] __iomem *addr
>    got void *addr
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
>  drivers/remoteproc/mtk_scp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 577cbd5d421e..8ed89ea1eb78 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp)
>  	return 0;
>  }
>  
> -static void mt8192_power_on_sram(void *addr)
> +static void mt8192_power_on_sram(void __iomem *addr)
>  {
>  	int i;
>  
> @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr)
>  	writel(0, addr);
>  }
>  
> -static void mt8192_power_off_sram(void *addr)
> +static void mt8192_power_off_sram(void __iomem *addr)

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  {
>  	int i;
>  
> -- 
> 2.29.2.299.gdc1121823c-goog
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-11-16 20:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  8:25 [PATCH v2 0/2] remoteproc/mediatek: fix sparse errors Tzung-Bi Shih
2020-11-16  8:25 ` Tzung-Bi Shih
2020-11-16  8:25 ` Tzung-Bi Shih
2020-11-16  8:25 ` [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off Tzung-Bi Shih
2020-11-16  8:25   ` Tzung-Bi Shih
2020-11-16  8:25   ` Tzung-Bi Shih
2020-11-16  8:42   ` Nicolas Boichat
2020-11-16  8:42     ` Nicolas Boichat
2020-11-16  8:42     ` Nicolas Boichat
2020-11-16 20:25   ` Mathieu Poirier [this message]
2020-11-16 20:25     ` Mathieu Poirier
2020-11-16 20:25     ` Mathieu Poirier
2020-11-16  8:25 ` [PATCH v2 2/2] remoteproc/mediatek: fix sparse errors on dma_alloc and dma_free Tzung-Bi Shih
2020-11-16  8:25   ` Tzung-Bi Shih
2020-11-16  8:25   ` Tzung-Bi Shih
2020-11-16  8:45   ` Nicolas Boichat
2020-11-16  8:45     ` Nicolas Boichat
2020-11-16  8:45     ` Nicolas Boichat
2020-11-16 20:32   ` Mathieu Poirier
2020-11-16 20:32     ` Mathieu Poirier
2020-11-16 20:32     ` Mathieu Poirier
2020-11-24  4:20 ` [PATCH v2 0/2] remoteproc/mediatek: fix sparse errors patchwork-bot+linux-remoteproc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116202536.GA3892875@xps15 \
    --to=mathieu.poirier@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=drinkcat@chromium.org \
    --cc=groeck@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ohad@wizery.com \
    --cc=pihsun@chromium.org \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.