From: Gabriele Paoloni <gabriele.paoloni@intel.com> To: tony.luck@intel.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gabriele.paoloni@intel.com, linux-safety@lists.elisa.tech Subject: [PATCH 4/4] x86/mce: remove redundant call to irq_work_queue() Date: Wed, 18 Nov 2020 15:15:52 +0000 [thread overview] Message-ID: <20201118151552.1412-5-gabriele.paoloni@intel.com> (raw) In-Reply-To: <20201118151552.1412-1-gabriele.paoloni@intel.com> Right now in do_machine_check() we have: __mc_scan_banks()->mce_log()->irq_work_queue(&mce_irq_work) hence the call of irq_work_queue() below after __mc_scan_banks() seems redundant. Just remove it. Signed-off-by: Gabriele Paoloni <gabriele.paoloni@intel.com> Reviewed-by: Tony Luck <tony.luck@intel.com> --- arch/x86/kernel/cpu/mce/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index d16cbb05b09c..f2f7bfc60c67 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1407,9 +1407,6 @@ noinstr void do_machine_check(struct pt_regs *regs) } } - if (worst > 0) - irq_work_queue(&mce_irq_work); - if (worst != MCE_AR_SEVERITY && !kill_it) goto out; -- 2.20.1 --------------------------------------------------------------------- INTEL CORPORATION ITALIA S.p.A. con unico socio Sede: Milanofiori Palazzo E 4 CAP 20094 Assago (MI) Capitale Sociale Euro 104.000,00 interamente versato Partita I.V.A. e Codice Fiscale 04236760155 Repertorio Economico Amministrativo n. 997124 Registro delle Imprese di Milano nr. 183983/5281/33 Soggetta ad attivita' di direzione e coordinamento di INTEL CORPORATION, USA This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
WARNING: multiple messages have this Message-ID (diff)
From: "Paoloni, Gabriele" <gabriele.paoloni@intel.com> To: tony.luck@intel.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: gabriele.paoloni@intel.com, linux-safety@lists.elisa.tech Subject: [linux-safety] [PATCH 4/4] x86/mce: remove redundant call to irq_work_queue() Date: Wed, 18 Nov 2020 15:15:52 +0000 [thread overview] Message-ID: <20201118151552.1412-5-gabriele.paoloni@intel.com> (raw) In-Reply-To: <20201118151552.1412-1-gabriele.paoloni@intel.com> Right now in do_machine_check() we have: __mc_scan_banks()->mce_log()->irq_work_queue(&mce_irq_work) hence the call of irq_work_queue() below after __mc_scan_banks() seems redundant. Just remove it. Signed-off-by: Gabriele Paoloni <gabriele.paoloni@intel.com> Reviewed-by: Tony Luck <tony.luck@intel.com> --- arch/x86/kernel/cpu/mce/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index d16cbb05b09c..f2f7bfc60c67 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1407,9 +1407,6 @@ noinstr void do_machine_check(struct pt_regs *regs) } } - if (worst > 0) - irq_work_queue(&mce_irq_work); - if (worst != MCE_AR_SEVERITY && !kill_it) goto out; -- 2.20.1 --------------------------------------------------------------------- INTEL CORPORATION ITALIA S.p.A. con unico socio Sede: Milanofiori Palazzo E 4 CAP 20094 Assago (MI) Capitale Sociale Euro 104.000,00 interamente versato Partita I.V.A. e Codice Fiscale 04236760155 Repertorio Economico Amministrativo n. 997124 Registro delle Imprese di Milano nr. 183983/5281/33 Soggetta ad attivita' di direzione e coordinamento di INTEL CORPORATION, USA This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#179): https://lists.elisa.tech/g/linux-safety/message/179 Mute This Topic: https://lists.elisa.tech/mt/78342513/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-11-18 15:16 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 15:15 [PATCH 0/4] x86/MCE: some minor fixes Gabriele Paoloni 2020-11-18 15:15 ` [linux-safety] " Paoloni, Gabriele 2020-11-18 15:15 ` [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce_end() fails Gabriele Paoloni 2020-11-18 15:15 ` [linux-safety] " Paoloni, Gabriele 2020-11-20 17:07 ` Borislav Petkov 2020-11-20 17:07 ` [linux-safety] " Borislav Petkov 2020-11-20 17:31 ` Paoloni, Gabriele 2020-11-20 17:31 ` [linux-safety] " Paoloni, Gabriele 2020-11-20 17:33 ` Borislav Petkov 2020-11-20 17:33 ` [linux-safety] " Borislav Petkov 2020-11-23 14:35 ` Borislav Petkov 2020-11-23 14:35 ` [linux-safety] " Borislav Petkov 2020-11-20 17:32 ` Borislav Petkov 2020-11-20 17:32 ` [linux-safety] " Borislav Petkov 2020-11-20 17:35 ` Paoloni, Gabriele 2020-11-20 17:35 ` [linux-safety] " Paoloni, Gabriele 2020-11-18 15:15 ` [PATCH 2/4] x86/mce: move the mce_panic() call and kill_it assignments at the right places Gabriele Paoloni 2020-11-18 15:15 ` [linux-safety] " Paoloni, Gabriele 2020-11-23 14:27 ` Borislav Petkov 2020-11-23 14:27 ` [linux-safety] " Borislav Petkov 2020-11-23 17:06 ` Paoloni, Gabriele 2020-11-23 17:06 ` [linux-safety] " Paoloni, Gabriele 2020-11-23 17:19 ` Borislav Petkov 2020-11-23 17:19 ` [linux-safety] " Borislav Petkov 2020-11-23 17:40 ` Paoloni, Gabriele 2020-11-23 17:40 ` [linux-safety] " Paoloni, Gabriele 2020-11-23 18:07 ` Borislav Petkov 2020-11-23 18:07 ` [linux-safety] " Borislav Petkov 2020-11-18 15:15 ` [PATCH 3/4] x86/mce: for LMCE panic only if mca_cfg.tolerant < 3 Gabriele Paoloni 2020-11-18 15:15 ` [linux-safety] " Paoloni, Gabriele 2020-11-18 15:15 ` Gabriele Paoloni [this message] 2020-11-18 15:15 ` [linux-safety] [PATCH 4/4] x86/mce: remove redundant call to irq_work_queue() Paoloni, Gabriele
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201118151552.1412-5-gabriele.paoloni@intel.com \ --to=gabriele.paoloni@intel.com \ --cc=bp@alien8.de \ --cc=hpa@zytor.com \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-safety@lists.elisa.tech \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.