From: Alan Stern <stern@rowland.harvard.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Min Guo <min.guo@mediatek.com>, Bin Liu <b-liu@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl'
Date: Fri, 20 Nov 2020 11:37:27 -0500 [thread overview]
Message-ID: <20201120163727.GC619708@rowland.harvard.edu> (raw)
In-Reply-To: <X7fvrK4F2378+9Rl@kroah.com>
On Fri, Nov 20, 2020 at 05:32:44PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 20, 2020 at 11:15:19AM -0500, Alan Stern wrote:
> > > Perhaps you might want to add a comment here so that people will not
> > > keep making this same mistake when they run auto-checkers on the
> > > codebase?
> >
> > A better change would be
> >
> > - devctl = musb_readb(mbase, MUSB_DEVCTL);
> > + (void) musb_readb(mbase, MUSB_DEVCTL);
> >
> > and eliminate the unused variable. Then there wouldn't be any compiler
> > warning.
>
> No need for the (void), the compiler shouldn't warn about that, right?
True, but it clearly indicates to a human reader that the value was
intended to be read and thrown away. Alternatively, the (void) cast
could be left out and a comment added.
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org,
Min Guo <min.guo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>, Bin Liu <b-liu@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl'
Date: Fri, 20 Nov 2020 11:37:27 -0500 [thread overview]
Message-ID: <20201120163727.GC619708@rowland.harvard.edu> (raw)
In-Reply-To: <X7fvrK4F2378+9Rl@kroah.com>
On Fri, Nov 20, 2020 at 05:32:44PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 20, 2020 at 11:15:19AM -0500, Alan Stern wrote:
> > > Perhaps you might want to add a comment here so that people will not
> > > keep making this same mistake when they run auto-checkers on the
> > > codebase?
> >
> > A better change would be
> >
> > - devctl = musb_readb(mbase, MUSB_DEVCTL);
> > + (void) musb_readb(mbase, MUSB_DEVCTL);
> >
> > and eliminate the unused variable. Then there wouldn't be any compiler
> > warning.
>
> No need for the (void), the compiler shouldn't warn about that, right?
True, but it clearly indicates to a human reader that the value was
intended to be read and thrown away. Alternatively, the (void) cast
could be left out and a comment added.
Alan Stern
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org,
Min Guo <min.guo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>, Bin Liu <b-liu@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: musb: remove unused variable 'devctl'
Date: Fri, 20 Nov 2020 11:37:27 -0500 [thread overview]
Message-ID: <20201120163727.GC619708@rowland.harvard.edu> (raw)
In-Reply-To: <X7fvrK4F2378+9Rl@kroah.com>
On Fri, Nov 20, 2020 at 05:32:44PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 20, 2020 at 11:15:19AM -0500, Alan Stern wrote:
> > > Perhaps you might want to add a comment here so that people will not
> > > keep making this same mistake when they run auto-checkers on the
> > > codebase?
> >
> > A better change would be
> >
> > - devctl = musb_readb(mbase, MUSB_DEVCTL);
> > + (void) musb_readb(mbase, MUSB_DEVCTL);
> >
> > and eliminate the unused variable. Then there wouldn't be any compiler
> > warning.
>
> No need for the (void), the compiler shouldn't warn about that, right?
True, but it clearly indicates to a human reader that the value was
intended to be read and thrown away. Alternatively, the (void) cast
could be left out and a comment added.
Alan Stern
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-20 16:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 8:21 [PATCH] usb: musb: remove unused variable 'devctl' min.guo
2020-11-17 8:21 ` min.guo
2020-11-17 8:21 ` min.guo
2020-11-18 11:48 ` Greg Kroah-Hartman
2020-11-18 11:48 ` Greg Kroah-Hartman
2020-11-18 11:48 ` Greg Kroah-Hartman
2020-11-20 6:48 ` Min Guo
2020-11-20 6:48 ` Min Guo
2020-11-20 6:48 ` Min Guo
2020-11-20 6:54 ` Greg Kroah-Hartman
2020-11-20 6:54 ` Greg Kroah-Hartman
2020-11-20 6:54 ` Greg Kroah-Hartman
2020-11-20 7:42 ` Min Guo
2020-11-20 7:42 ` Min Guo
2020-11-20 7:42 ` Min Guo
2020-11-20 8:36 ` Greg Kroah-Hartman
2020-11-20 8:36 ` Greg Kroah-Hartman
2020-11-20 8:36 ` Greg Kroah-Hartman
2020-11-20 9:02 ` Min Guo
2020-11-20 9:02 ` Min Guo
2020-11-20 9:02 ` Min Guo
2020-11-20 9:20 ` Greg Kroah-Hartman
2020-11-20 9:20 ` Greg Kroah-Hartman
2020-11-20 9:20 ` Greg Kroah-Hartman
2020-11-20 16:15 ` Alan Stern
2020-11-20 16:15 ` Alan Stern
2020-11-20 16:15 ` Alan Stern
2020-11-20 16:32 ` Greg Kroah-Hartman
2020-11-20 16:32 ` Greg Kroah-Hartman
2020-11-20 16:32 ` Greg Kroah-Hartman
2020-11-20 16:37 ` Alan Stern [this message]
2020-11-20 16:37 ` Alan Stern
2020-11-20 16:37 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120163727.GC619708@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.