From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: alsa-devel@alsa-project.org, vkoul@kernel.org
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, jank@cadence.com,
srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
mengdong.lin@intel.com, bard.liao@intel.com
Subject: [PATCH 0/5] soundwire: only clear valid interrupts
Date: Tue, 24 Nov 2020 09:33:13 +0800 [thread overview]
Message-ID: <20201124013318.8963-1-yung-chuan.liao@linux.intel.com> (raw)
We wrote 1 to the handled interrupts bits along with 0 to all other bits
to the SoundWire DPx interrupt register. However, DP0 has reserved fields
and the read-only SDCA_CASCADE bit. DPN also has reserved fields. We should
not try to write values in these fields.
Besides, we deal with pending interrupts in a loop but we didn't reset the
slave_notify status.
Pierre-Louis Bossart (5):
soundwire: bus: add comments to explain interrupt loop filter
soundwire: bus: reset slave_notify status at each loop
soundwire: registers: add definitions for clearable interrupt fields
soundwire: bus: only clear valid DP0 interrupts
soundwire: bus: only clear valid DPN interrupts
drivers/soundwire/bus.c | 27 +++++++++++++++++--------
include/linux/soundwire/sdw_registers.h | 11 ++++++++++
2 files changed, 30 insertions(+), 8 deletions(-)
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: alsa-devel@alsa-project.org, vkoul@kernel.org
Cc: pierre-louis.bossart@linux.intel.com, vinod.koul@linaro.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
srinivas.kandagatla@linaro.org, jank@cadence.com,
mengdong.lin@intel.com, sanyog.r.kale@intel.com,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: [PATCH 0/5] soundwire: only clear valid interrupts
Date: Tue, 24 Nov 2020 09:33:13 +0800 [thread overview]
Message-ID: <20201124013318.8963-1-yung-chuan.liao@linux.intel.com> (raw)
We wrote 1 to the handled interrupts bits along with 0 to all other bits
to the SoundWire DPx interrupt register. However, DP0 has reserved fields
and the read-only SDCA_CASCADE bit. DPN also has reserved fields. We should
not try to write values in these fields.
Besides, we deal with pending interrupts in a loop but we didn't reset the
slave_notify status.
Pierre-Louis Bossart (5):
soundwire: bus: add comments to explain interrupt loop filter
soundwire: bus: reset slave_notify status at each loop
soundwire: registers: add definitions for clearable interrupt fields
soundwire: bus: only clear valid DP0 interrupts
soundwire: bus: only clear valid DPN interrupts
drivers/soundwire/bus.c | 27 +++++++++++++++++--------
include/linux/soundwire/sdw_registers.h | 11 ++++++++++
2 files changed, 30 insertions(+), 8 deletions(-)
--
2.17.1
next reply other threads:[~2020-11-24 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 1:33 Bard Liao [this message]
2020-11-24 1:33 ` [PATCH 0/5] soundwire: only clear valid interrupts Bard Liao
2020-11-24 1:33 ` [PATCH 1/5] soundwire: bus: add comments to explain interrupt loop filter Bard Liao
2020-11-24 1:33 ` Bard Liao
2020-11-24 1:33 ` [PATCH 2/5] soundwire: bus: reset slave_notify status at each loop Bard Liao
2020-11-24 1:33 ` Bard Liao
2020-11-24 1:33 ` [PATCH 3/5] soundwire: registers: add definitions for clearable interrupt fields Bard Liao
2020-11-24 1:33 ` Bard Liao
2020-11-24 1:33 ` [PATCH 4/5] soundwire: bus: only clear valid DP0 interrupts Bard Liao
2020-11-24 1:33 ` Bard Liao
2020-11-24 1:33 ` [PATCH 5/5] soundwire: bus: only clear valid DPN interrupts Bard Liao
2020-11-24 1:33 ` Bard Liao
2020-11-25 5:02 ` [PATCH 0/5] soundwire: only clear valid interrupts Vinod Koul
2020-11-25 5:02 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124013318.8963-1-yung-chuan.liao@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.