Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY

From: Maxime Ripard <maxime@cerno.tech>
To: Adam Sampson <ats@offog.org>
Cc: Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Andrew Lunn <andrew@lunn.ch>, Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
Date: Tue, 24 Nov 2020 15:24:40 +0100	[thread overview]
Message-ID: <20201124142440.5ott772bz5f4ieln@gilmour> (raw)
In-Reply-To: <20201123174739.6809-1-ats@offog.org>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On Mon, Nov 23, 2020 at 05:47:39PM +0000, Adam Sampson wrote:
> The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
> are configured in hardware, using resistors that are populated to pull
> the RTL8211E's RXDLY/TXDLY pins low or high as needed.
> 
> phy-mode should be set to rgmii-id to reflect this. Previously it was
> set to rgmii, which used to work but now results in the delays being
> disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
> phy: realtek: fix rtl8211e rx/tx delay config").
> 
> Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
> Ethernet works unreliably on one board and doesn't work at all on the
> other.
> 
> Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
> Signed-off-by: Adam Sampson <ats@offog.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]