From: Will Deacon <will@kernel.org>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Ning Sun <ning.sun@intel.com>,
Joerg Roedel <joro@8bytes.org>, Borislav Petkov <bp@alien8.de>,
catalin.marinas@arm.com, kernel-team@android.com, x86@kernel.org,
tboot-devel@lists.sourceforge.net,
Adrian Huang <ahuang12@lenovo.com>,
iommu@lists.linux-foundation.org, Ashok Raj <ashok.raj@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] x86/tboot: Don't disable swiotlb when iommu is forced on
Date: Wed, 25 Nov 2020 15:51:30 +0000 [thread overview]
Message-ID: <20201125155130.GA16839@willie-the-truck> (raw)
In-Reply-To: <20201125154153.GA29929@localhost.localdomain>
Hi Konrad,
On Wed, Nov 25, 2020 at 10:41:53AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 25, 2020 at 02:05:15PM +0000, Will Deacon wrote:
> > On Wed, 25 Nov 2020 09:41:24 +0800, Lu Baolu wrote:
> > > After commit 327d5b2fee91c ("iommu/vt-d: Allow 32bit devices to uses DMA
> > > domain"), swiotbl could also be used for direct memory access if IOMMU
> > > is enabled but a device is configured to pass through the DMA translation.
> > > Keep swiotlb when IOMMU is forced on, otherwise, some devices won't work
> > > if "iommu=pt" kernel parameter is used.
> >
> > Applied to arm64 (for-next/iommu/fixes), thanks!
> >
> > [1/1] x86/tboot: Don't disable swiotlb when iommu is forced on
> > https://git.kernel.org/arm64/c/e2be2a833ab5
>
> But tboot never ran on ARM. It is a Intel specifc.
>
> I think either me or Thomas should take this patch.
FWIW, I did check with Thomas before I picked it up. I know it looks weird
going via arm64, but that's only because I'm temporarily handling the IOMMU
tree there (including vt-d changes) while Joerg is away. Since this fixes a
vt-d regression, I thought I'd pick it up along with the other IOMMU fixes I
have queued for -rc6.
That said, if you insist, then I can revert it. I'm really only trying to
help here.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Ashok Raj <ashok.raj@intel.com>,
catalin.marinas@arm.com, x86@kernel.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Ning Sun <ning.sun@intel.com>,
tboot-devel@lists.sourceforge.net, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Adrian Huang <ahuang12@lenovo.com>,
Thomas Gleixner <tglx@linutronix.de>,
kernel-team@android.com
Subject: Re: [PATCH 1/1] x86/tboot: Don't disable swiotlb when iommu is forced on
Date: Wed, 25 Nov 2020 15:51:30 +0000 [thread overview]
Message-ID: <20201125155130.GA16839@willie-the-truck> (raw)
In-Reply-To: <20201125154153.GA29929@localhost.localdomain>
Hi Konrad,
On Wed, Nov 25, 2020 at 10:41:53AM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 25, 2020 at 02:05:15PM +0000, Will Deacon wrote:
> > On Wed, 25 Nov 2020 09:41:24 +0800, Lu Baolu wrote:
> > > After commit 327d5b2fee91c ("iommu/vt-d: Allow 32bit devices to uses DMA
> > > domain"), swiotbl could also be used for direct memory access if IOMMU
> > > is enabled but a device is configured to pass through the DMA translation.
> > > Keep swiotlb when IOMMU is forced on, otherwise, some devices won't work
> > > if "iommu=pt" kernel parameter is used.
> >
> > Applied to arm64 (for-next/iommu/fixes), thanks!
> >
> > [1/1] x86/tboot: Don't disable swiotlb when iommu is forced on
> > https://git.kernel.org/arm64/c/e2be2a833ab5
>
> But tboot never ran on ARM. It is a Intel specifc.
>
> I think either me or Thomas should take this patch.
FWIW, I did check with Thomas before I picked it up. I know it looks weird
going via arm64, but that's only because I'm temporarily handling the IOMMU
tree there (including vt-d changes) while Joerg is away. Since this fixes a
vt-d regression, I thought I'd pick it up along with the other IOMMU fixes I
have queued for -rc6.
That said, if you insist, then I can revert it. I'm really only trying to
help here.
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-11-25 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 1:41 [PATCH 1/1] x86/tboot: Don't disable swiotlb when iommu is forced on Lu Baolu
2020-11-25 1:41 ` Lu Baolu
2020-11-25 14:05 ` Will Deacon
2020-11-25 14:05 ` Will Deacon
2020-11-25 15:41 ` Konrad Rzeszutek Wilk
2020-11-25 15:41 ` Konrad Rzeszutek Wilk
2020-11-25 15:51 ` Will Deacon [this message]
2020-11-25 15:51 ` Will Deacon
2020-11-25 16:25 ` Konrad Rzeszutek Wilk
2020-11-25 16:25 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125155130.GA16839@willie-the-truck \
--to=will@kernel.org \
--cc=ahuang12@lenovo.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ning.sun@intel.com \
--cc=tboot-devel@lists.sourceforge.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.