Re: [PATCH v2 for-next 7/7] RDMA/hns: Add support for UD inline

From: Jason Gunthorpe <jgg@nvidia.com>
To: liweihang <liweihang@huawei.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"leon@kernel.org" <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v2 for-next 7/7] RDMA/hns: Add support for UD inline
Date: Thu, 26 Nov 2020 15:24:28 -0400	[thread overview]
Message-ID: <20201126192428.GA547165@nvidia.com> (raw)
In-Reply-To: <7a7ee7427b68488f98ebc18d5b7c4d75@huawei.com>

On Thu, Nov 19, 2020 at 06:15:42AM +0000, liweihang wrote:
> On 2020/11/19 3:11, Jason Gunthorpe wrote:
> > On Mon, Nov 16, 2020 at 07:33:28PM +0800, Weihang Li wrote:
> >> @@ -503,7 +581,23 @@ static inline int set_ud_wqe(struct hns_roce_qp *qp,
> >>  	if (ret)
> >>  		return ret;
> >>  
> >> -	set_extend_sge(qp, wr, &curr_idx, valid_num_sge);
> >> +	if (wr->send_flags & IB_SEND_INLINE) {
> >> +		ret = set_ud_inl(qp, wr, ud_sq_wqe, &curr_idx);
> >> +		if (ret)
> >> +			return ret;
> > 
> > Why are you implementing this in the kernel? No kernel ULP sets this
> > flag?
> 
> Sorry, I don't understand. Some kernel users may set IB_SEND_INLINE
> when using UD, some may not, we just check this flag to decide how
> to fill the data into UD SQ WQE here.

I mean if you 'git grep IB_SEND_INLINE' nothing uses it. 

This is all dead code.

How did you test it?

Jason