From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Michal Simek <michal.simek@xilinx.com>, linux-iio <linux-iio@vger.kernel.org>, "Bartosz Golaszewski" <bgolaszewski@baylibre.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and remove remove() Date: Mon, 30 Nov 2020 16:16:00 +0000 [thread overview] Message-ID: <20201130161600.00000d66@Huawei.com> (raw) In-Reply-To: <CAMRc=Mcbzpw4o28NA-19dtWzwQz-DUYocNrD+0_RqRkCVq=PiQ@mail.gmail.com> On Mon, 30 Nov 2020 15:30:22 +0100 Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Mon, Nov 30, 2020 at 3:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > In order to simplify resource management and error paths in probe() and > > entirely drop the remove() callback - use devres helpers wherever > > possible. Define devm actions for cancelling the delayed work and > > disabling the clock. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > [snip] > > > > > /* Set thresholds to min/max */ > > for (i = 0; i < 16; i++) { > > @@ -1334,59 +1353,23 @@ static int xadc_probe(struct platform_device *pdev) > > ret = xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(i), > > xadc->threshold[i]); > > if (ret) > > - goto err_free_irq; > > + return ret; > > } > > > > /* Go to non-buffered mode */ > > xadc_postdisable(indio_dev); > > > > - ret = iio_device_register(indio_dev); > > + ret = devm_iio_device_register(dev, indio_dev); > > if (ret) > > - goto err_free_irq; > > + return ret; > > > > platform_set_drvdata(pdev, indio_dev); > > > > Cr*p I was supposed to drop this line... > > Jonathan: can you drop it when applying? Sure. J > > Bartosz > > [snip] > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Lars-Peter Clausen <lars@metafoo.de>, linux-iio <linux-iio@vger.kernel.org>, Michal Simek <michal.simek@xilinx.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Jonathan Cameron <jic23@kernel.org> Subject: Re: [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and remove remove() Date: Mon, 30 Nov 2020 16:16:00 +0000 [thread overview] Message-ID: <20201130161600.00000d66@Huawei.com> (raw) In-Reply-To: <CAMRc=Mcbzpw4o28NA-19dtWzwQz-DUYocNrD+0_RqRkCVq=PiQ@mail.gmail.com> On Mon, 30 Nov 2020 15:30:22 +0100 Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Mon, Nov 30, 2020 at 3:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > In order to simplify resource management and error paths in probe() and > > entirely drop the remove() callback - use devres helpers wherever > > possible. Define devm actions for cancelling the delayed work and > > disabling the clock. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > [snip] > > > > > /* Set thresholds to min/max */ > > for (i = 0; i < 16; i++) { > > @@ -1334,59 +1353,23 @@ static int xadc_probe(struct platform_device *pdev) > > ret = xadc_write_adc_reg(xadc, XADC_REG_THRESHOLD(i), > > xadc->threshold[i]); > > if (ret) > > - goto err_free_irq; > > + return ret; > > } > > > > /* Go to non-buffered mode */ > > xadc_postdisable(indio_dev); > > > > - ret = iio_device_register(indio_dev); > > + ret = devm_iio_device_register(dev, indio_dev); > > if (ret) > > - goto err_free_irq; > > + return ret; > > > > platform_set_drvdata(pdev, indio_dev); > > > > Cr*p I was supposed to drop this line... > > Jonathan: can you drop it when applying? Sure. J > > Bartosz > > [snip] > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-30 16:17 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-30 14:27 [PATH v3 0/3] iio: adc: xilinx: use even more devres Bartosz Golaszewski 2020-11-30 14:27 ` Bartosz Golaszewski 2020-11-30 14:27 ` [PATH v3 1/3] iio: adc: xilinx: use helper variable for &pdev->dev Bartosz Golaszewski 2020-11-30 14:27 ` Bartosz Golaszewski 2020-11-30 14:27 ` [PATH v3 2/3] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Bartosz Golaszewski 2020-11-30 14:27 ` Bartosz Golaszewski 2020-11-30 14:27 ` [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and remove remove() Bartosz Golaszewski 2020-11-30 14:27 ` Bartosz Golaszewski 2020-11-30 14:30 ` Bartosz Golaszewski 2020-11-30 14:30 ` Bartosz Golaszewski 2020-11-30 16:16 ` Jonathan Cameron [this message] 2020-11-30 16:16 ` Jonathan Cameron 2020-11-30 20:21 ` [PATH v3 0/3] iio: adc: xilinx: use even more devres Jonathan Cameron 2020-11-30 20:21 ` Jonathan Cameron 2020-12-11 12:15 ` Anand Ashok Dumbre 2020-12-11 12:15 ` Anand Ashok Dumbre 2020-12-13 12:04 ` Jonathan Cameron 2020-12-13 12:04 ` Jonathan Cameron 2021-01-18 9:09 ` Bartosz Golaszewski 2021-01-18 9:09 ` Bartosz Golaszewski 2021-01-18 13:38 ` Jonathan Cameron 2021-01-18 13:38 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201130161600.00000d66@Huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=bgolaszewski@baylibre.com \ --cc=brgl@bgdev.pl \ --cc=jic23@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.