From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bongsu Jeon <bongsu.jeon2@gmail.com>
Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bongsu Jeon <bongsu.jeon@samsung.com>
Subject: Re: [PATCH net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME
Date: Mon, 30 Nov 2020 20:40:41 +0200 [thread overview]
Message-ID: <20201130184041.GB28735@kozik-lap> (raw)
In-Reply-To: <1606737750-29537-1-git-send-email-bongsu.jeon@samsung.com>
On Mon, Nov 30, 2020 at 09:02:30PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> The delay of 20ms is enough to enable and
> wake up the Samsung's nfc chip.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
> drivers/nfc/s3fwrn5/i2c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
It's really not easy to work with your way of sending the patches.
I am sorry but you have to adjust your style to the style of reviewers
and the entire community.
1. Again, you ignored/dropped my Ack.
2. I asked you to send all patches referencing each other, which you can
achieve without any effort with git format-patch and send-email or
with in-reply-to.
Seriously, these tools work properly by default! You have to break
them on purpose - so stop. Now, all your patches are scattered over
my mailbox. They are all over mailing list:
https://lore.kernel.org/lkml/?q=bongsu.jeon2%40gmail.com
Browsing this patchset is uncomfortable. It's a pain.
Please, work on your workflow. Get help in that - there are plenty of
open-source contributors in Samsung. Ask them how to do it. If you
cannot, read the mailing lists and see how others do it.
Recent example, one of thousands:
https://lore.kernel.org/linux-arm-kernel/20201130131047.2648960-1-daniel@0x0f.com/T/#m4a9ed644869b8018b8286a6b229012278141cb66
1. It comes with a cover letter,
2. All emails are properly linked with each other (scroll to the bottom).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-nfc@lists.01.org
Subject: [linux-nfc] Re: [PATCH net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME
Date: Mon, 30 Nov 2020 20:40:41 +0200 [thread overview]
Message-ID: <20201130184041.GB28735@kozik-lap> (raw)
In-Reply-To: 1606737750-29537-1-git-send-email-bongsu.jeon@samsung.com
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
On Mon, Nov 30, 2020@09:02:30PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> The delay of 20ms is enough to enable and
> wake up the Samsung's nfc chip.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
> drivers/nfc/s3fwrn5/i2c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
It's really not easy to work with your way of sending the patches.
I am sorry but you have to adjust your style to the style of reviewers
and the entire community.
1. Again, you ignored/dropped my Ack.
2. I asked you to send all patches referencing each other, which you can
achieve without any effort with git format-patch and send-email or
with in-reply-to.
Seriously, these tools work properly by default! You have to break
them on purpose - so stop. Now, all your patches are scattered over
my mailbox. They are all over mailing list:
https://lore.kernel.org/lkml/?q=bongsu.jeon2%40gmail.com
Browsing this patchset is uncomfortable. It's a pain.
Please, work on your workflow. Get help in that - there are plenty of
open-source contributors in Samsung. Ask them how to do it. If you
cannot, read the mailing lists and see how others do it.
Recent example, one of thousands:
https://lore.kernel.org/linux-arm-kernel/20201130131047.2648960-1-daniel@0x0f.com/T/#m4a9ed644869b8018b8286a6b229012278141cb66
1. It comes with a cover letter,
2. All emails are properly linked with each other (scroll to the bottom).
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-nfc@lists.01.org
Subject: Re: [PATCH net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME
Date: Mon, 30 Nov 2020 20:40:41 +0200 [thread overview]
Message-ID: <20201130184041.GB28735@kozik-lap> (raw)
In-Reply-To: <1606737750-29537-1-git-send-email-bongsu.jeon@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
On Mon, Nov 30, 2020 at 09:02:30PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> The delay of 20ms is enough to enable and
> wake up the Samsung's nfc chip.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
> drivers/nfc/s3fwrn5/i2c.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
It's really not easy to work with your way of sending the patches.
I am sorry but you have to adjust your style to the style of reviewers
and the entire community.
1. Again, you ignored/dropped my Ack.
2. I asked you to send all patches referencing each other, which you can
achieve without any effort with git format-patch and send-email or
with in-reply-to.
Seriously, these tools work properly by default! You have to break
them on purpose - so stop. Now, all your patches are scattered over
my mailbox. They are all over mailing list:
https://lore.kernel.org/lkml/?q=bongsu.jeon2%40gmail.com
Browsing this patchset is uncomfortable. It's a pain.
Please, work on your workflow. Get help in that - there are plenty of
open-source contributors in Samsung. Ask them how to do it. If you
cannot, read the mailing lists and see how others do it.
Recent example, one of thousands:
https://lore.kernel.org/linux-arm-kernel/20201130131047.2648960-1-daniel(a)0x0f.com/T/#m4a9ed644869b8018b8286a6b229012278141cb66
1. It comes with a cover letter,
2. All emails are properly linked with each other (scroll to the bottom).
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-30 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:02 [PATCH net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME Bongsu Jeon
2020-11-30 12:02 ` Bongsu Jeon
2020-11-30 12:02 ` [linux-nfc] " Bongsu Jeon
2020-11-30 18:40 ` Krzysztof Kozlowski [this message]
2020-11-30 18:40 ` Krzysztof Kozlowski
2020-11-30 18:40 ` [linux-nfc] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130184041.GB28735@kozik-lap \
--to=krzk@kernel.org \
--cc=bongsu.jeon2@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.