From: Bjorn Helgaas <helgaas@kernel.org>
To: Guilherme Piccoli <gpiccoli@canonical.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
lukas@wunner.de, linux-pci@vger.kernel.org,
Pingfan Liu <kernelfans@gmail.com>,
andi@firstfloor.org, "H. Peter Anvin" <hpa@zytor.com>,
Baoquan He <bhe@redhat.com>,
x86@kernel.org, Sinan Kaya <okaya@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
Dave Young <dyoung@redhat.com>,
Gavin Guo <gavin.guo@canonical.com>,
Borislav Petkov <bp@alien8.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Guowen Shan <gshan@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Guilherme G. Piccoli" <kernel@gpiccoli.net>,
kexec mailing list <kexec@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Dan Streetman <ddstreet@canonical.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks
Date: Mon, 30 Nov 2020 14:20:21 -0600 [thread overview]
Message-ID: <20201130202021.GA1106292@bjorn-Precision-5520> (raw)
In-Reply-To: <CAHD1Q_yfFYrfAEHTA3mW25hK9DFFYnKQ2_1HCEnL4m=bc=rLfg@mail.gmail.com>
On Wed, Nov 18, 2020 at 07:36:08PM -0300, Guilherme Piccoli wrote:
> Thanks a lot Bjorn! I confess except for PPC64 Server machines, I
> never saw other "domains" or segments. Is it common in x86 to have
> that? The early_quirks() are restricted to the first segment, no
> matter how many host bridges we have in segment 0000?
I don't know whether it's *common* to have multiple domains on x86,
but they're definitely used on large systems. This includes some
lspci info from an HPE Superdome Flex system:
https://lore.kernel.org/lkml/5350E02A-6457-41A8-8F33-AF67BFDAEE3E@fb.com/
The early quirks in arch/x86/kernel/early-quirks.c (not the
DECLARE_PCI_FIXUP_EARLY quirks in drivers/pci/quirks.c) are restricted
to segment 0, no matter how many host bridges there are. This is
because they use read_pci_config_16(), which uses a config access
mechanism that has no provision for a segment number.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Guilherme Piccoli <gpiccoli@canonical.com>
Cc: Guowen Shan <gshan@redhat.com>,
linux-pci@vger.kernel.org, Pingfan Liu <kernelfans@gmail.com>,
andi@firstfloor.org, "H. Peter Anvin" <hpa@zytor.com>,
Baoquan He <bhe@redhat.com>,
x86@kernel.org, Sinan Kaya <okaya@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
Dave Young <dyoung@redhat.com>,
Gavin Guo <gavin.guo@canonical.com>,
Borislav Petkov <bp@alien8.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
kexec mailing list <kexec@lists.infradead.org>,
"Guilherme G. Piccoli" <kernel@gpiccoli.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
LKML <linux-kernel@vger.kernel.org>,
Vivek Goyal <vgoyal@redhat.com>,
Dan Streetman <ddstreet@canonical.com>,
lukas@wunner.de, "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks
Date: Mon, 30 Nov 2020 14:20:21 -0600 [thread overview]
Message-ID: <20201130202021.GA1106292@bjorn-Precision-5520> (raw)
In-Reply-To: <CAHD1Q_yfFYrfAEHTA3mW25hK9DFFYnKQ2_1HCEnL4m=bc=rLfg@mail.gmail.com>
On Wed, Nov 18, 2020 at 07:36:08PM -0300, Guilherme Piccoli wrote:
> Thanks a lot Bjorn! I confess except for PPC64 Server machines, I
> never saw other "domains" or segments. Is it common in x86 to have
> that? The early_quirks() are restricted to the first segment, no
> matter how many host bridges we have in segment 0000?
I don't know whether it's *common* to have multiple domains on x86,
but they're definitely used on large systems. This includes some
lspci info from an HPE Superdome Flex system:
https://lore.kernel.org/lkml/5350E02A-6457-41A8-8F33-AF67BFDAEE3E@fb.com/
The early quirks in arch/x86/kernel/early-quirks.c (not the
DECLARE_PCI_FIXUP_EARLY quirks in drivers/pci/quirks.c) are restricted
to segment 0, no matter how many host bridges there are. This is
because they use read_pci_config_16(), which uses a config access
mechanism that has no provision for a segment number.
Bjorn
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-11-30 20:21 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 18:37 [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks Guilherme G. Piccoli
2018-10-18 18:37 ` Guilherme G. Piccoli
2018-10-18 18:37 ` [PATCH 2/3] x86/PCI: Export find_cap() to be used in early PCI code Guilherme G. Piccoli
2018-10-18 18:37 ` Guilherme G. Piccoli
2018-10-18 18:37 ` [PATCH 3/3] x86/quirks: Add parameter to clear MSIs early on boot Guilherme G. Piccoli
2018-10-18 18:37 ` Guilherme G. Piccoli
2018-10-18 20:08 ` Sinan Kaya
2018-10-18 20:08 ` Sinan Kaya
2018-10-18 20:13 ` Guilherme G. Piccoli
2018-10-18 20:13 ` Guilherme G. Piccoli
2018-10-18 20:30 ` Sinan Kaya
2018-10-18 20:30 ` Sinan Kaya
2018-10-22 19:44 ` Guilherme G. Piccoli
2018-10-22 19:44 ` Guilherme G. Piccoli
2018-10-18 22:15 ` [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks Bjorn Helgaas
2018-10-18 22:15 ` Bjorn Helgaas
2018-10-22 20:35 ` Guilherme G. Piccoli
2018-10-22 20:35 ` Guilherme G. Piccoli
2018-10-23 17:03 ` Bjorn Helgaas
2018-10-23 17:03 ` Bjorn Helgaas
2020-11-06 13:14 ` Guilherme G. Piccoli
2020-11-06 13:14 ` Guilherme G. Piccoli
2020-11-13 16:46 ` Bjorn Helgaas
2020-11-13 16:46 ` Bjorn Helgaas
2020-11-13 23:31 ` Thomas Gleixner
2020-11-13 23:31 ` Thomas Gleixner
2020-11-13 23:40 ` Thomas Gleixner
2020-11-13 23:40 ` Thomas Gleixner
2020-11-14 20:39 ` Bjorn Helgaas
2020-11-14 20:39 ` Bjorn Helgaas
2020-11-14 20:58 ` Thomas Gleixner
2020-11-14 20:58 ` Thomas Gleixner
2020-11-14 21:22 ` Bjorn Helgaas
2020-11-14 21:22 ` Bjorn Helgaas
2020-11-15 14:05 ` Eric W. Biederman
2020-11-15 14:05 ` Eric W. Biederman
2020-11-15 14:29 ` Eric W. Biederman
2020-11-15 14:29 ` Eric W. Biederman
2020-11-15 15:11 ` Thomas Gleixner
2020-11-15 15:11 ` Thomas Gleixner
2020-11-15 17:01 ` Lukas Wunner
2020-11-15 19:18 ` Thomas Gleixner
2020-11-15 19:18 ` Thomas Gleixner
2020-11-15 20:46 ` Eric W. Biederman
2020-11-15 20:46 ` Eric W. Biederman
2020-11-16 20:31 ` Guilherme G. Piccoli
2020-11-16 20:31 ` Guilherme G. Piccoli
2020-11-16 21:45 ` Eric W. Biederman
2020-11-16 21:45 ` Eric W. Biederman
2020-11-16 21:49 ` Guilherme Piccoli
2020-11-16 21:49 ` Guilherme Piccoli
2020-11-17 0:19 ` Bjorn Helgaas
2020-11-17 0:19 ` Bjorn Helgaas
2020-11-17 1:06 ` Eric W. Biederman
2020-11-17 1:06 ` Eric W. Biederman
2020-11-17 9:53 ` Thomas Gleixner
2020-11-17 9:53 ` Thomas Gleixner
2020-11-17 12:19 ` David Woodhouse
2020-11-17 12:19 ` David Woodhouse
2020-11-17 19:34 ` Thomas Gleixner
2020-11-17 19:34 ` Thomas Gleixner
2020-11-17 22:25 ` Eric W. Biederman
2020-11-17 22:25 ` Eric W. Biederman
2020-11-17 12:04 ` Guilherme Piccoli
2020-11-17 12:04 ` Guilherme Piccoli
2020-11-18 21:05 ` Bjorn Helgaas
2020-11-18 21:05 ` Bjorn Helgaas
2020-11-18 22:36 ` Guilherme Piccoli
2020-11-18 22:36 ` Guilherme Piccoli
2020-11-30 20:20 ` Bjorn Helgaas [this message]
2020-11-30 20:20 ` Bjorn Helgaas
2020-12-14 18:32 ` Guilherme Piccoli
2020-12-14 18:32 ` Guilherme Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130202021.GA1106292@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andi@firstfloor.org \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=ddstreet@canonical.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gavin.guo@canonical.com \
--cc=gpiccoli@canonical.com \
--cc=gshan@redhat.com \
--cc=hpa@zytor.com \
--cc=jay.vosburgh@canonical.com \
--cc=kernel@gpiccoli.net \
--cc=kernelfans@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mingo@redhat.com \
--cc=okaya@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.