From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Xiong, Jianxin" <jianxin.xiong@intel.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Christian Koenig <christian.koenig@amd.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support
Date: Tue, 1 Dec 2020 20:39:23 -0400 [thread overview]
Message-ID: <20201202003923.GI5487@ziepe.ca> (raw)
In-Reply-To: <MW3PR11MB45556C1BAD4AF795DF0F783EE5F50@MW3PR11MB4555.namprd11.prod.outlook.com>
On Mon, Nov 30, 2020 at 05:53:39PM +0000, Xiong, Jianxin wrote:
> > From: Jason Gunthorpe <jgg@ziepe.ca>
> > Sent: Monday, November 30, 2020 8:08 AM
> > To: Xiong, Jianxin <jianxin.xiong@intel.com>
> > Cc: linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford <dledford@redhat.com>; Leon Romanovsky
> > <leon@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian Koenig <christian.koenig@amd.com>; Vetter, Daniel
> > <daniel.vetter@intel.com>
> > Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support
> >
> > On Fri, Nov 27, 2020 at 12:55:41PM -0800, Jianxin Xiong wrote:
> > >
> > > +function(rdma_multifile_module PY_MODULE MODULE_NAME LINKER_FLAGS)
> >
> > I think just replace rdma_cython_module with this? No good reason I can see to have two APIs?
>
> rdma_cython_module can handle many modules, but this one is for a single module.
> If you agree, I can merge the two by slightly tweaking the logic: each module starts
> with a .pyx file, followed by 0 or more .c and .h files.
Then have rdma_cython_module call some rdam_single_cython_module()
multiple times that has this code below?
> > Here too? You probably don't need to specify h files at all, at
> > worst they should only be used with publish_internal_headers
>
> Without the .h link, the compiler fail to find the header file (both
> dmabuf_alloc.c and the generated "dmabuf.c" contain #include
> "dmabuf_alloc.h").
Header files are made 'cross module' using the
"publish_internal_headers" command
But we could also hack in a -I directive to fix up the "" include for
the cython outupt..
But it should not be handled here in the cython module command
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Xiong, Jianxin" <jianxin.xiong@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Doug Ledford <dledford@redhat.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support
Date: Tue, 1 Dec 2020 20:39:23 -0400 [thread overview]
Message-ID: <20201202003923.GI5487@ziepe.ca> (raw)
In-Reply-To: <MW3PR11MB45556C1BAD4AF795DF0F783EE5F50@MW3PR11MB4555.namprd11.prod.outlook.com>
On Mon, Nov 30, 2020 at 05:53:39PM +0000, Xiong, Jianxin wrote:
> > From: Jason Gunthorpe <jgg@ziepe.ca>
> > Sent: Monday, November 30, 2020 8:08 AM
> > To: Xiong, Jianxin <jianxin.xiong@intel.com>
> > Cc: linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford <dledford@redhat.com>; Leon Romanovsky
> > <leon@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>; Christian Koenig <christian.koenig@amd.com>; Vetter, Daniel
> > <daniel.vetter@intel.com>
> > Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support
> >
> > On Fri, Nov 27, 2020 at 12:55:41PM -0800, Jianxin Xiong wrote:
> > >
> > > +function(rdma_multifile_module PY_MODULE MODULE_NAME LINKER_FLAGS)
> >
> > I think just replace rdma_cython_module with this? No good reason I can see to have two APIs?
>
> rdma_cython_module can handle many modules, but this one is for a single module.
> If you agree, I can merge the two by slightly tweaking the logic: each module starts
> with a .pyx file, followed by 0 or more .c and .h files.
Then have rdma_cython_module call some rdam_single_cython_module()
multiple times that has this code below?
> > Here too? You probably don't need to specify h files at all, at
> > worst they should only be used with publish_internal_headers
>
> Without the .h link, the compiler fail to find the header file (both
> dmabuf_alloc.c and the generated "dmabuf.c" contain #include
> "dmabuf_alloc.h").
Header files are made 'cross module' using the
"publish_internal_headers" command
But we could also hack in a -I directive to fix up the "" include for
the cython outupt..
But it should not be handled here in the cython module command
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-02 0:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 20:55 [PATCH rdma-core v3 0/6] Add user space dma-buf support Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-11-27 20:55 ` [PATCH rdma-core v3 1/6] Update kernel headers Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-11-27 20:55 ` [PATCH rdma-core v3 2/6] verbs: Support dma-buf based memory region Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-12-02 16:33 ` Yishai Hadas
2020-12-02 16:33 ` Yishai Hadas
2020-11-27 20:55 ` [PATCH rdma-core v3 3/6] mlx5: " Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-11-27 20:55 ` [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-11-30 14:57 ` Daniel Vetter
2020-11-30 14:57 ` Daniel Vetter
2020-11-30 15:55 ` Jason Gunthorpe
2020-11-30 15:55 ` Jason Gunthorpe
2020-11-30 16:04 ` Daniel Vetter
2020-11-30 16:04 ` Daniel Vetter
2020-11-30 16:36 ` Jason Gunthorpe
2020-11-30 16:36 ` Jason Gunthorpe
2020-11-30 16:55 ` Daniel Vetter
2020-11-30 16:55 ` Daniel Vetter
2020-11-30 18:03 ` Xiong, Jianxin
2020-11-30 18:03 ` Xiong, Jianxin
2020-11-30 18:13 ` Xiong, Jianxin
2020-11-30 18:13 ` Xiong, Jianxin
2020-11-30 16:08 ` Jason Gunthorpe
2020-11-30 16:08 ` Jason Gunthorpe
2020-11-30 17:53 ` Xiong, Jianxin
2020-11-30 17:53 ` Xiong, Jianxin
2020-12-02 0:39 ` Jason Gunthorpe [this message]
2020-12-02 0:39 ` Jason Gunthorpe
2020-12-02 1:12 ` Xiong, Jianxin
2020-12-02 1:12 ` Xiong, Jianxin
2020-11-27 20:55 ` [PATCH rdma-core v3 5/6] tests: Add tests for dma-buf based memory regions Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
2020-11-30 15:00 ` Daniel Vetter
2020-11-30 15:00 ` Daniel Vetter
2020-11-30 17:35 ` Xiong, Jianxin
2020-11-30 17:35 ` Xiong, Jianxin
2020-11-30 17:46 ` Daniel Vetter
2020-11-30 17:46 ` Daniel Vetter
2020-11-27 20:55 ` [PATCH rdma-core v3 6/6] tests: Bug fix for get_access_flags() Jianxin Xiong
2020-11-27 20:55 ` Jianxin Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202003923.GI5487@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jianxin.xiong@intel.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.