From: Matthew Wilcox <willy@infradead.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-nvdimm@lists.01.org
Subject: Re: PATCH] fs/dax: fix compile problem on parisc and mips
Date: Fri, 4 Dec 2020 03:48:43 +0000 [thread overview]
Message-ID: <20201204034843.GM11935@casper.infradead.org> (raw)
In-Reply-To: <fb91b40d258414b0fdce2c380752e48daa6a70d6.camel@HansenPartnership.com>
On Thu, Dec 03, 2020 at 04:33:10PM -0800, James Bottomley wrote:
> These platforms define PMD_ORDER in asm/pgtable.h
I think that's the real problem, though.
#define PGD_ORDER 1 /* Number of pages per pgd */
#define PMD_ORDER 1 /* Number of pages per pmd */
#define PGD_ALLOC_ORDER (2 + 1) /* first pgd contains pmd */
#else
#define PGD_ORDER 1 /* Number of pages per pgd */
#define PGD_ALLOC_ORDER (PGD_ORDER + 1)
That should clearly be PMD_ALLOC_ORDER, not PMD_ORDER. Or even
PAGES_PER_PMD like the comment calls it, because I really think
that doing an order-3 (8 pages) allocation for the PGD is wrong.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-nvdimm@lists.01.org
Subject: Re: PATCH] fs/dax: fix compile problem on parisc and mips
Date: Fri, 4 Dec 2020 03:48:43 +0000 [thread overview]
Message-ID: <20201204034843.GM11935@casper.infradead.org> (raw)
In-Reply-To: <fb91b40d258414b0fdce2c380752e48daa6a70d6.camel@HansenPartnership.com>
On Thu, Dec 03, 2020 at 04:33:10PM -0800, James Bottomley wrote:
> These platforms define PMD_ORDER in asm/pgtable.h
I think that's the real problem, though.
#define PGD_ORDER 1 /* Number of pages per pgd */
#define PMD_ORDER 1 /* Number of pages per pmd */
#define PGD_ALLOC_ORDER (2 + 1) /* first pgd contains pmd */
#else
#define PGD_ORDER 1 /* Number of pages per pgd */
#define PGD_ALLOC_ORDER (PGD_ORDER + 1)
That should clearly be PMD_ALLOC_ORDER, not PMD_ORDER. Or even
PAGES_PER_PMD like the comment calls it, because I really think
that doing an order-3 (8 pages) allocation for the PGD is wrong.
next prev parent reply other threads:[~2020-12-04 3:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 0:33 PATCH] fs/dax: fix compile problem on parisc and mips James Bottomley
2020-12-04 0:33 ` James Bottomley
2020-12-04 3:48 ` Matthew Wilcox [this message]
2020-12-04 3:48 ` Matthew Wilcox
2020-12-04 7:57 ` Helge Deller
2020-12-04 7:57 ` Helge Deller
2020-12-04 12:44 ` Matthew Wilcox
2020-12-04 12:44 ` Matthew Wilcox
2020-12-04 13:28 ` John David Anglin
2020-12-04 13:28 ` John David Anglin
2020-12-04 14:11 ` Matthew Wilcox
2020-12-04 14:11 ` Matthew Wilcox
2021-01-28 19:18 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204034843.GM11935@casper.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.