From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Thomas Wagner <thwa1@web.de>
Subject: Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing
Date: Sat, 5 Dec 2020 12:33:00 -0800 [thread overview]
Message-ID: <20201205123300.34f99141@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <eefc4f80-da1c-fed5-7934-11615f1db0fc@pengutronix.de>
On Sat, 5 Dec 2020 21:24:42 +0100 Marc Kleine-Budde wrote:
> On 12/5/20 12:26 PM, Oliver Hartkopp wrote:
> > On 05.12.20 04:44, Jakub Kicinski wrote:
> >> On Fri, 4 Dec 2020 14:35:08 +0100 Marc Kleine-Budde wrote:
> >>> From: Oliver Hartkopp <socketcan@hartkopp.net>
> >>>
> >>> When CAN_ISOTP_SF_BROADCAST is set in the CAN_ISOTP_OPTS flags the CAN_ISOTP
> >>> socket is switched into functional addressing mode, where only single frame
> >>> (SF) protocol data units can be send on the specified CAN interface and the
> >>> given tp.tx_id after bind().
> >>>
> >>> In opposite to normal and extended addressing this socket does not register a
> >>> CAN-ID for reception which would be needed for a 1-to-1 ISOTP connection with a
> >>> segmented bi-directional data transfer.
> >>>
> >>> Sending SFs on this socket is therefore a TX-only 'broadcast' operation.
> >>
> >> Unclear from this patch what is getting fixed. Looks a little bit like
> >> a feature which could be added in a backward compatible way, no?
> >> Is it only added for completeness of the ISOTP implementation?
> >>
> >
> > Yes, the latter.
> >
> > It's a very small and simple tested addition and I hope it can still go
> > into the initial upstream process.
>
> What about the (incremental?) change that Thomas Wagner posted?
>
> https://lore.kernel.org/r/20201204135557.55599-1-thwa1@web.de
That settles it :) This change needs to got into -next and 5.11.
next prev parent reply other threads:[~2020-12-05 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 13:35 pull-request: can 2020-12-04 Marc Kleine-Budde
2020-12-04 13:35 ` [net 1/3] can: softing: softing_netdev_open(): fix error handling Marc Kleine-Budde
2020-12-04 13:35 ` [net 2/3] can: isotp: isotp_setsockopt(): block setsockopt on bound sockets Marc Kleine-Budde
2020-12-04 13:35 ` [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing Marc Kleine-Budde
2020-12-05 3:44 ` Jakub Kicinski
2020-12-05 11:26 ` Oliver Hartkopp
2020-12-05 20:24 ` Marc Kleine-Budde
2020-12-05 20:33 ` Jakub Kicinski [this message]
2020-12-05 20:56 ` Marc Kleine-Budde
2020-12-05 21:09 ` Jakub Kicinski
2020-12-05 21:20 ` Marc Kleine-Budde
2020-12-08 12:54 ` Oliver Hartkopp
2020-12-08 18:07 ` Jakub Kicinski
2020-12-09 7:45 ` Marc Kleine-Budde
2020-12-10 8:18 ` Oliver Hartkopp
2020-12-10 9:55 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205123300.34f99141@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thwa1@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.