From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Thomas Wagner <thwa1@web.de>,
linux-can@vger.kernel.org, kernel@pengutronix.de,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing
Date: Tue, 8 Dec 2020 10:07:18 -0800 [thread overview]
Message-ID: <20201208100718.5ed008dc@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <752c8838-b478-43da-620b-e15bcc690518@hartkopp.net>
On Tue, 8 Dec 2020 13:54:28 +0100 Oliver Hartkopp wrote:
> On 05.12.20 22:09, Jakub Kicinski wrote:
> > On Sat, 5 Dec 2020 21:56:33 +0100 Marc Kleine-Budde wrote:
> >> On 12/5/20 9:33 PM, Jakub Kicinski wrote:
> >>>> What about the (incremental?) change that Thomas Wagner posted?
> >>>>
> >>>> https://lore.kernel.org/r/20201204135557.55599-1-thwa1@web.de
> >>>
> >>> That settles it :) This change needs to got into -next and 5.11.
> >>
> >> Ok. Can you take patch 1, which is a real fix:
> >>
> >> https://lore.kernel.org/linux-can/20201204133508.742120-2-mkl@pengutronix.de/
> >
> > Sure! Applied that one from the ML (I assumed that's what you meant).
>
> I just double-checked this mail and in fact the second patch from Marc's
> pull request was a real fix too:
>
> https://lore.kernel.org/linux-can/20201204133508.742120-3-mkl@pengutronix.de/
Ack, I thought it was a fix to some existing code but it's a fix to
ISO-TP so we should probably get it in before someone start depending
on existing behavior - Marc should I apply that one directly, too?
> Btw. the missing feature which was added for completeness of the ISOTP
> implementation has now also integrated the improvement suggested by
> Thomas Wagner:
>
> https://lore.kernel.org/linux-can/20201206144731.4609-1-socketcan@hartkopp.net/T/#u
>
> Would be cool if it could go into the initial iso-tp contribution as
> 5.10 becomes a long-term kernel.
>
> But I don't want to be pushy - treat it as your like.
I think Linus wants to release 5.10 so that the merge window doesn't
overlap with Christmas too much. Let's not push our luck.
next prev parent reply other threads:[~2020-12-08 18:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 13:35 pull-request: can 2020-12-04 Marc Kleine-Budde
2020-12-04 13:35 ` [net 1/3] can: softing: softing_netdev_open(): fix error handling Marc Kleine-Budde
2020-12-04 13:35 ` [net 2/3] can: isotp: isotp_setsockopt(): block setsockopt on bound sockets Marc Kleine-Budde
2020-12-04 13:35 ` [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing Marc Kleine-Budde
2020-12-05 3:44 ` Jakub Kicinski
2020-12-05 11:26 ` Oliver Hartkopp
2020-12-05 20:24 ` Marc Kleine-Budde
2020-12-05 20:33 ` Jakub Kicinski
2020-12-05 20:56 ` Marc Kleine-Budde
2020-12-05 21:09 ` Jakub Kicinski
2020-12-05 21:20 ` Marc Kleine-Budde
2020-12-08 12:54 ` Oliver Hartkopp
2020-12-08 18:07 ` Jakub Kicinski [this message]
2020-12-09 7:45 ` Marc Kleine-Budde
2020-12-10 8:18 ` Oliver Hartkopp
2020-12-10 9:55 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208100718.5ed008dc@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thwa1@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.