From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <broonie@kernel.org>, <linux-spi@vger.kernel.org>
Cc: <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<ludovic.desroches@microchip.com>, <bugalski.piotr@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>
Subject: [PATCH 2/4] spi: atmel-quadspi: Drop superfluous set of QSPI_IFR_APBTFRTYP_READ
Date: Mon, 7 Dec 2020 15:59:57 +0200 [thread overview]
Message-ID: <20201207135959.154124-3-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20201207135959.154124-1-tudor.ambarus@microchip.com>
That bit describes the APB transfer type. We are writing
serial memory registers via AHB acesses, that bit does not
make sense in the current context.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
drivers/spi/atmel-quadspi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ad913212426e..30533ab82c7b 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -386,9 +386,6 @@ static int atmel_qspi_set_cfg(struct atmel_qspi *aq,
(void)atmel_qspi_read(aq, QSPI_SR);
if (aq->caps->has_ricr) {
- if (!op->addr.nbytes && op->data.dir == SPI_MEM_DATA_IN)
- ifr |= QSPI_IFR_APBTFRTYP_READ;
-
/* Set QSPI Instruction Frame registers */
atmel_qspi_write(iar, aq, QSPI_IAR);
if (op->data.dir == SPI_MEM_DATA_IN)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <broonie@kernel.org>, <linux-spi@vger.kernel.org>
Cc: alexandre.belloni@bootlin.com,
Tudor Ambarus <tudor.ambarus@microchip.com>,
linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com,
bugalski.piotr@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] spi: atmel-quadspi: Drop superfluous set of QSPI_IFR_APBTFRTYP_READ
Date: Mon, 7 Dec 2020 15:59:57 +0200 [thread overview]
Message-ID: <20201207135959.154124-3-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20201207135959.154124-1-tudor.ambarus@microchip.com>
That bit describes the APB transfer type. We are writing
serial memory registers via AHB acesses, that bit does not
make sense in the current context.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
drivers/spi/atmel-quadspi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index ad913212426e..30533ab82c7b 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -386,9 +386,6 @@ static int atmel_qspi_set_cfg(struct atmel_qspi *aq,
(void)atmel_qspi_read(aq, QSPI_SR);
if (aq->caps->has_ricr) {
- if (!op->addr.nbytes && op->data.dir == SPI_MEM_DATA_IN)
- ifr |= QSPI_IFR_APBTFRTYP_READ;
-
/* Set QSPI Instruction Frame registers */
atmel_qspi_write(iar, aq, QSPI_IAR);
if (op->data.dir == SPI_MEM_DATA_IN)
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 13:59 [PATCH 0/4] spi: atmel-quadspi: Fix AHB memory accesses Tudor Ambarus
2020-12-07 13:59 ` Tudor Ambarus
2020-12-07 13:59 ` [PATCH 1/4] " Tudor Ambarus
2020-12-07 13:59 ` Tudor Ambarus
2020-12-07 13:59 ` Tudor Ambarus [this message]
2020-12-07 13:59 ` [PATCH 2/4] spi: atmel-quadspi: Drop superfluous set of QSPI_IFR_APBTFRTYP_READ Tudor Ambarus
2020-12-07 13:59 ` [PATCH 3/4] spi: atmel-quadspi: Write QSPI_IAR only when needed Tudor Ambarus
2020-12-07 13:59 ` Tudor Ambarus
2020-12-07 13:59 ` [PATCH 4/4] spi: atmel-quadspi: Move common code outside of if else Tudor Ambarus
2020-12-07 13:59 ` Tudor Ambarus
2020-12-07 17:22 ` [PATCH 0/4] spi: atmel-quadspi: Fix AHB memory accesses Mark Brown
2020-12-07 17:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207135959.154124-3-tudor.ambarus@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.