All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: mpe@ellerman.id.au, mikey@neuling.org, npiggin@gmail.com,
	leobras.c@gmail.com, pbonzini@redhat.com,
	christophe.leroy@c-s.fr, jniethe5@gmail.com, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 4/4] KVM: PPC: Introduce new capability for 2nd DAWR
Date: Wed, 9 Dec 2020 15:36:48 +1100	[thread overview]
Message-ID: <20201209043648.GB29825@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <20201124105953.39325-5-ravi.bangoria@linux.ibm.com>

On Tue, Nov 24, 2020 at 04:29:53PM +0530, Ravi Bangoria wrote:
> Introduce KVM_CAP_PPC_DAWR1 which can be used by Qemu to query whether
> kvm supports 2nd DAWR or not.

This should be described in Documentation/virt/kvm/api.rst.

Strictly speaking, it should be a capability which is disabled by
default, so the guest can only do the H_SET_MODE to set DAWR[X]1 if it
has been explicitly permitted to do so by userspace (QEMU).  This is
because we want as little as possible of the VM configuration to come
from the host capabilities rather than from what userspace configures.

So what we really need here is for this to be a capability which can
be queried by userspace to find out if it is possible, and then
enabled by userspace if it wants.  See how KVM_CAP_PPC_NESTED_HV is
handled for example.

Paul.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: christophe.leroy@c-s.fr, leobras.c@gmail.com, mikey@neuling.org,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	npiggin@gmail.com, kvm-ppc@vger.kernel.org, jniethe5@gmail.com,
	pbonzini@redhat.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 4/4] KVM: PPC: Introduce new capability for 2nd DAWR
Date: Wed, 9 Dec 2020 15:36:48 +1100	[thread overview]
Message-ID: <20201209043648.GB29825@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <20201124105953.39325-5-ravi.bangoria@linux.ibm.com>

On Tue, Nov 24, 2020 at 04:29:53PM +0530, Ravi Bangoria wrote:
> Introduce KVM_CAP_PPC_DAWR1 which can be used by Qemu to query whether
> kvm supports 2nd DAWR or not.

This should be described in Documentation/virt/kvm/api.rst.

Strictly speaking, it should be a capability which is disabled by
default, so the guest can only do the H_SET_MODE to set DAWR[X]1 if it
has been explicitly permitted to do so by userspace (QEMU).  This is
because we want as little as possible of the VM configuration to come
from the host capabilities rather than from what userspace configures.

So what we really need here is for this to be a capability which can
be queried by userspace to find out if it is possible, and then
enabled by userspace if it wants.  See how KVM_CAP_PPC_NESTED_HV is
handled for example.

Paul.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: mpe@ellerman.id.au, mikey@neuling.org, npiggin@gmail.com,
	leobras.c@gmail.com, pbonzini@redhat.com,
	christophe.leroy@c-s.fr, jniethe5@gmail.com, kvm@vger.kernel.org,
	kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 4/4] KVM: PPC: Introduce new capability for 2nd DAWR
Date: Wed, 09 Dec 2020 04:36:48 +0000	[thread overview]
Message-ID: <20201209043648.GB29825@thinks.paulus.ozlabs.org> (raw)
In-Reply-To: <20201124105953.39325-5-ravi.bangoria@linux.ibm.com>

On Tue, Nov 24, 2020 at 04:29:53PM +0530, Ravi Bangoria wrote:
> Introduce KVM_CAP_PPC_DAWR1 which can be used by Qemu to query whether
> kvm supports 2nd DAWR or not.

This should be described in Documentation/virt/kvm/api.rst.

Strictly speaking, it should be a capability which is disabled by
default, so the guest can only do the H_SET_MODE to set DAWR[X]1 if it
has been explicitly permitted to do so by userspace (QEMU).  This is
because we want as little as possible of the VM configuration to come
from the host capabilities rather than from what userspace configures.

So what we really need here is for this to be a capability which can
be queried by userspace to find out if it is possible, and then
enabled by userspace if it wants.  See how KVM_CAP_PPC_NESTED_HV is
handled for example.

Paul.

  reply	other threads:[~2020-12-09  4:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 10:59 [PATCH v2 0/4] KVM: PPC: Power10 2nd DAWR enablement Ravi Bangoria
2020-11-24 11:11 ` Ravi Bangoria
2020-11-24 10:59 ` Ravi Bangoria
2020-11-24 10:59 ` [PATCH v2 1/4] KVM: PPC: Allow nested guest creation when L0 hv_guest_state > L1 Ravi Bangoria
2020-11-24 11:11   ` Ravi Bangoria
2020-11-24 10:59   ` Ravi Bangoria
2020-12-09 14:25   ` Fabiano Rosas
2020-12-09 14:25     ` Fabiano Rosas
2020-12-09 14:25     ` Fabiano Rosas
2020-11-24 10:59 ` [PATCH v2 2/4] KVM: PPC: Rename current DAWR macros and variables Ravi Bangoria
2020-11-24 11:11   ` Ravi Bangoria
2020-11-24 10:59   ` Ravi Bangoria
2020-11-24 10:59 ` [PATCH v2 3/4] KVM: PPC: Add infrastructure to support 2nd DAWR Ravi Bangoria
2020-11-24 11:11   ` Ravi Bangoria
2020-11-24 10:59   ` Ravi Bangoria
2020-11-24 10:59 ` [PATCH v2 4/4] KVM: PPC: Introduce new capability for " Ravi Bangoria
2020-11-24 11:11   ` Ravi Bangoria
2020-11-24 10:59   ` Ravi Bangoria
2020-12-09  4:36   ` Paul Mackerras [this message]
2020-12-09  4:36     ` Paul Mackerras
2020-12-09  4:36     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209043648.GB29825@thinks.paulus.ozlabs.org \
    --to=paulus@ozlabs.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=jniethe5@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=leobras.c@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=ravi.bangoria@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.