From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
davem@davemloft.net, kuba@kernel.org, wens@csie.org,
jernej.skrabec@siol.net, timur@kernel.org,
song.bao.hua@hisilicon.com, f.fainelli@gmail.com,
leon@kernel.org, hkallweit1@gmail.com, wangyunjian@huawei.com,
sr@denx.de, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function
Date: Tue, 15 Dec 2020 12:11:53 +0300 [thread overview]
Message-ID: <20201215091153.GH2809@kadam> (raw)
In-Reply-To: <20201215085655.ddacjfvogc3e33vz@gilmour>
On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
> Hi,
>
> On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
> > 'irq_of_parse_and_map()' should be balanced by a corresponding
> > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
>
> Do you have a source to back that? It's not clear at all from the
> documentation for those functions, and couldn't find any user calling it
> from the ten-or-so random picks I took.
It looks like irq_create_of_mapping() needs to be freed with
irq_dispose_mapping() so this is correct.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: song.bao.hua@hisilicon.com, jernej.skrabec@siol.net,
f.fainelli@gmail.com, leon@kernel.org, timur@kernel.org,
netdev@vger.kernel.org, wangyunjian@huawei.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
wens@csie.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kuba@kernel.org, sr@denx.de, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t
Date: Tue, 15 Dec 2020 09:11:53 +0000 [thread overview]
Message-ID: <20201215091153.GH2809@kadam> (raw)
In-Reply-To: <20201215085655.ddacjfvogc3e33vz@gilmour>
On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
> Hi,
>
> On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
> > 'irq_of_parse_and_map()' should be balanced by a corresponding
> > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
>
> Do you have a source to back that? It's not clear at all from the
> documentation for those functions, and couldn't find any user calling it
> from the ten-or-so random picks I took.
It looks like irq_create_of_mapping() needs to be freed with
irq_dispose_mapping() so this is correct.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: song.bao.hua@hisilicon.com, jernej.skrabec@siol.net,
f.fainelli@gmail.com, leon@kernel.org, timur@kernel.org,
netdev@vger.kernel.org, wangyunjian@huawei.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
wens@csie.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kuba@kernel.org, sr@denx.de, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com
Subject: Re: [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function
Date: Tue, 15 Dec 2020 12:11:53 +0300 [thread overview]
Message-ID: <20201215091153.GH2809@kadam> (raw)
In-Reply-To: <20201215085655.ddacjfvogc3e33vz@gilmour>
On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
> Hi,
>
> On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
> > 'irq_of_parse_and_map()' should be balanced by a corresponding
> > 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
>
> Do you have a source to back that? It's not clear at all from the
> documentation for those functions, and couldn't find any user calling it
> from the ten-or-so random picks I took.
It looks like irq_create_of_mapping() needs to be freed with
irq_dispose_mapping() so this is correct.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-15 9:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 20:21 [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Christophe JAILLET
2020-12-14 20:21 ` Christophe JAILLET
2020-12-14 20:21 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the r Christophe JAILLET
2020-12-15 8:56 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Maxime Ripard
2020-12-15 8:56 ` Maxime Ripard
2020-12-15 8:56 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Maxime Ripard
2020-12-15 9:11 ` Dan Carpenter [this message]
2020-12-15 9:11 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Dan Carpenter
2020-12-15 9:11 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Dan Carpenter
2020-12-15 11:37 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Maxime Ripard
2020-12-15 11:37 ` Maxime Ripard
2020-12-15 11:37 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Maxime Ripard
2020-12-15 18:18 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Christophe JAILLET
2020-12-15 18:18 ` Christophe JAILLET
2020-12-15 18:18 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Christophe JAILLET
2020-12-15 19:08 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Maxime Ripard
2020-12-15 19:08 ` Maxime Ripard
2020-12-15 19:08 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Maxime Ripard
2020-12-15 19:35 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Dan Carpenter
2020-12-15 19:35 ` Dan Carpenter
2020-12-15 19:35 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Dan Carpenter
2020-12-15 20:15 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Christophe JAILLET
2020-12-15 21:08 ` Markus Elfring
2020-12-16 3:23 ` [PATCH] " Chen-Yu Tsai
2020-12-16 3:23 ` Chen-Yu Tsai
2020-12-16 3:23 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Chen-Yu Tsai
2020-12-15 20:15 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function Christophe JAILLET
2020-12-15 20:15 ` Christophe JAILLET
2020-12-15 20:15 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t Christophe JAILLET
2020-12-16 19:50 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function patchwork-bot+netdevbpf
2020-12-16 19:50 ` patchwork-bot+netdevbpf
2020-12-16 19:50 ` [PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in t patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215091153.GH2809@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=netdev@vger.kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=sr@denx.de \
--cc=timur@kernel.org \
--cc=wangyunjian@huawei.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.