From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Martin Kepplinger <martink@posteo.de>,
Angus Ainslie <angus@akkea.ca>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Li Yang <leoyang.li@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vinod Koul <vkoul@kernel.org>, Anson Huang <Anson.Huang@nxp.com>,
Michael Walle <michael@walle.cc>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc
Date: Tue, 15 Dec 2020 10:18:44 +0100 [thread overview]
Message-ID: <20201215091844.GD29321@kozik-lap> (raw)
In-Reply-To: <d66739ead267a9468977801d9ad7f9f23c7de166.1607879709.git.agx@sigxcpu.org>
On Sun, Dec 13, 2020 at 06:17:12PM +0100, Guido Günther wrote:
> The board has it's own rtc chip.
s/rtc/RTC/
Even if you have on-board RTC, why disabling the SNVS?
Best regards,
Krzysztof
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index af139b283daf..12f5d75a5e44 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -886,6 +886,10 @@ &snvs_pwrkey {
> status = "okay";
> };
>
> +&snvs_rtc {
> + status = "disabled";
> +};
> +
> &sai2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sai2>;
> --
> 2.29.2
>
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: devicetree@vger.kernel.org, phone-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Will Deacon <will@kernel.org>, Anson Huang <Anson.Huang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Angus Ainslie <angus@akkea.ca>, Michael Walle <michael@walle.cc>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Martin Kepplinger <martink@posteo.de>,
Li Yang <leoyang.li@nxp.com>, Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc
Date: Tue, 15 Dec 2020 10:18:44 +0100 [thread overview]
Message-ID: <20201215091844.GD29321@kozik-lap> (raw)
In-Reply-To: <d66739ead267a9468977801d9ad7f9f23c7de166.1607879709.git.agx@sigxcpu.org>
On Sun, Dec 13, 2020 at 06:17:12PM +0100, Guido Günther wrote:
> The board has it's own rtc chip.
s/rtc/RTC/
Even if you have on-board RTC, why disabling the SNVS?
Best regards,
Krzysztof
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index af139b283daf..12f5d75a5e44 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -886,6 +886,10 @@ &snvs_pwrkey {
> status = "okay";
> };
>
> +&snvs_rtc {
> + status = "disabled";
> +};
> +
> &sai2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sai2>;
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-15 9:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 17:17 [PATCH 0/4] Config and device tree updates for the Librem5 Devkit Guido Günther
2020-12-13 17:17 ` Guido Günther
2020-12-13 17:17 ` [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components Guido Günther
2020-12-13 17:17 ` Guido Günther
2020-12-15 9:17 ` Krzysztof Kozlowski
2020-12-15 9:17 ` Krzysztof Kozlowski
2020-12-13 17:17 ` [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc Guido Günther
2020-12-13 17:17 ` Guido Günther
2020-12-15 9:18 ` Krzysztof Kozlowski [this message]
2020-12-15 9:18 ` Krzysztof Kozlowski
2020-12-13 17:17 ` [PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on Guido Günther
2020-12-13 17:17 ` Guido Günther
2020-12-15 9:21 ` Krzysztof Kozlowski
2020-12-15 9:21 ` Krzysztof Kozlowski
2020-12-13 17:17 ` [PATCH 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings Guido Günther
2020-12-13 17:17 ` Guido Günther
2020-12-15 9:22 ` Krzysztof Kozlowski
2020-12-15 9:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215091844.GD29321@kozik-lap \
--to=krzk@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=agx@sigxcpu.org \
--cc=angus@akkea.ca \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=michael@walle.cc \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.