All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Milan Lakhani <milan.lakhani@codethink.co.uk>
Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
	linux-doc@vger.kernel.org, lukas.bulwahn@gmail.com,
	sudip.mukherjee@codethink.co.uk, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2] Documentation: process: Correct numbering
Date: Mon, 21 Dec 2020 09:52:09 -0700	[thread overview]
Message-ID: <20201221095209.4dd4233e@lwn.net> (raw)
In-Reply-To: <1608064956-5512-1-git-send-email-milan.lakhani@codethink.co.uk>

On Tue, 15 Dec 2020 20:42:36 +0000
Milan Lakhani <milan.lakhani@codethink.co.uk> wrote:

> Renumber the steps in submit-checklist.rst as some numbers were skipped.
> 
> Fixes: 72deb455b5ec ("block: remove CONFIG_LBDAF")
> Signed-off-by: Milan Lakhani <milan.lakhani@codethink.co.uk>
> ---
>  Documentation/process/submit-checklist.rst | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
> index 1879f88..230ee42 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -75,44 +75,44 @@ and elsewhere regarding submitting Linux kernel patches.
>  13) Has been build- and runtime tested with and without ``CONFIG_SMP`` and
>      ``CONFIG_PREEMPT.``
>  
> -16) All codepaths have been exercised with all lockdep features enabled.
> +14) All codepaths have been exercised with all lockdep features enabled.
>  
> -17) All new ``/proc`` entries are documented under ``Documentation/``
> +15) All new ``/proc`` entries are documented under ``Documentation/``
[...]

I've applied this, but, if you're going to stick a "Fixes" tag onto a
patch, it's probably only polite to copy the original author.  I'm not
fully convinced that the tag is warranted in this case.

This document seems out of date in a number of ways; it could really use a
rather more thorough updating than this.

Thanks,

jon

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Milan Lakhani <milan.lakhani@codethink.co.uk>
Cc: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
	linux-doc@vger.kernel.org, lukas.bulwahn@gmail.com,
	sudip.mukherjee@codethink.co.uk, Christoph Hellwig <hch@lst.de>
Subject: Re: [linux-safety] [PATCH v2] Documentation: process: Correct numbering
Date: Mon, 21 Dec 2020 09:52:09 -0700	[thread overview]
Message-ID: <20201221095209.4dd4233e@lwn.net> (raw)
In-Reply-To: <1608064956-5512-1-git-send-email-milan.lakhani@codethink.co.uk>

On Tue, 15 Dec 2020 20:42:36 +0000
Milan Lakhani <milan.lakhani@codethink.co.uk> wrote:

> Renumber the steps in submit-checklist.rst as some numbers were skipped.
> 
> Fixes: 72deb455b5ec ("block: remove CONFIG_LBDAF")
> Signed-off-by: Milan Lakhani <milan.lakhani@codethink.co.uk>
> ---
>  Documentation/process/submit-checklist.rst | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
> index 1879f88..230ee42 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -75,44 +75,44 @@ and elsewhere regarding submitting Linux kernel patches.
>  13) Has been build- and runtime tested with and without ``CONFIG_SMP`` and
>      ``CONFIG_PREEMPT.``
>
> -16) All codepaths have been exercised with all lockdep features enabled.
> +14) All codepaths have been exercised with all lockdep features enabled.
>
> -17) All new ``/proc`` entries are documented under ``Documentation/``
> +15) All new ``/proc`` entries are documented under ``Documentation/``
[...]

I've applied this, but, if you're going to stick a "Fixes" tag onto a
patch, it's probably only polite to copy the original author.  I'm not
fully convinced that the tag is warranted in this case.

This document seems out of date in a number of ways; it could really use a
rather more thorough updating than this.

Thanks,

jon


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#228): https://lists.elisa.tech/g/linux-safety/message/228
Mute This Topic: https://lists.elisa.tech/mt/78985953/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2020-12-21 16:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15 20:42 [linux-safety] [PATCH v2] Documentation: process: Correct numbering Milan Lakhani
2020-12-21 16:52 ` Jonathan Corbet [this message]
2020-12-21 16:52   ` Jonathan Corbet
2020-12-22 16:23   ` Lukas Bulwahn
2020-12-22 16:23     ` [linux-safety] " Lukas Bulwahn
2020-12-22 16:36     ` Randy Dunlap
2020-12-22 17:11       ` Lukas Bulwahn
2020-12-22 17:11         ` [linux-safety] " Lukas Bulwahn
2020-12-22 17:15         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201221095209.4dd4233e@lwn.net \
    --to=corbet@lwn.net \
    --cc=hch@lst.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-safety@lists.elisa.tech \
    --cc=lukas.bulwahn@gmail.com \
    --cc=milan.lakhani@codethink.co.uk \
    --cc=sudip.mukherjee@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.