From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Hsin-Yi Wang <hsinyi@chromium.org>,
Ikjoon Jang <ikjn@chromium.org>
Subject: Re: [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams
Date: Mon, 21 Dec 2020 12:29:13 -0700 [thread overview]
Message-ID: <20201221192913.GA407645@robh.at.kernel.org> (raw)
In-Reply-To: <20201216115125.5886-1-chunfeng.yun@mediatek.com>
On Wed, Dec 16, 2020 at 07:51:23PM +0800, Chunfeng Yun wrote:
> The 0.96 xHCI controller on some platforms does not support
> bulk stream even HCCPARAMS says supporting, due to MaxPSASize
> is set a non-zero default value by mistake, so add a new
> property "mediatek,broken_streams_quirk" to fix it.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> this patch depends on:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=402773
> [v4,09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index e5e03f902802..330f7294bf34 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -120,6 +120,11 @@ properties:
> description: The mask to disable u3ports, bit0 for u3port0,
> bit1 for u3port1, ... etc
>
> + mediatek,broken_streams_quirk:
You should imply this from the compatible property.
(Also, don't use '_' in property names).
> + description: set if the controller doesn't support bulk stream but
> + HCCPARAMS says support.
> + type: boolean
> +
> "#address-cells":
> const: 1
>
> --
> 2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: devicetree@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams
Date: Mon, 21 Dec 2020 12:29:13 -0700 [thread overview]
Message-ID: <20201221192913.GA407645@robh.at.kernel.org> (raw)
In-Reply-To: <20201216115125.5886-1-chunfeng.yun@mediatek.com>
On Wed, Dec 16, 2020 at 07:51:23PM +0800, Chunfeng Yun wrote:
> The 0.96 xHCI controller on some platforms does not support
> bulk stream even HCCPARAMS says supporting, due to MaxPSASize
> is set a non-zero default value by mistake, so add a new
> property "mediatek,broken_streams_quirk" to fix it.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> this patch depends on:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=402773
> [v4,09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index e5e03f902802..330f7294bf34 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -120,6 +120,11 @@ properties:
> description: The mask to disable u3ports, bit0 for u3port0,
> bit1 for u3port1, ... etc
>
> + mediatek,broken_streams_quirk:
You should imply this from the compatible property.
(Also, don't use '_' in property names).
> + description: set if the controller doesn't support bulk stream but
> + HCCPARAMS says support.
> + type: boolean
> +
> "#address-cells":
> const: 1
>
> --
> 2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: devicetree@vger.kernel.org,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams
Date: Mon, 21 Dec 2020 12:29:13 -0700 [thread overview]
Message-ID: <20201221192913.GA407645@robh.at.kernel.org> (raw)
In-Reply-To: <20201216115125.5886-1-chunfeng.yun@mediatek.com>
On Wed, Dec 16, 2020 at 07:51:23PM +0800, Chunfeng Yun wrote:
> The 0.96 xHCI controller on some platforms does not support
> bulk stream even HCCPARAMS says supporting, due to MaxPSASize
> is set a non-zero default value by mistake, so add a new
> property "mediatek,broken_streams_quirk" to fix it.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> this patch depends on:
> https://patchwork.kernel.org/project/linux-mediatek/list/?series=402773
> [v4,09/11] dt-bindings: usb: convert mediatek, mtk-xhci.txt to YAML schema
> ---
> Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> index e5e03f902802..330f7294bf34 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> @@ -120,6 +120,11 @@ properties:
> description: The mask to disable u3ports, bit0 for u3port0,
> bit1 for u3port1, ... etc
>
> + mediatek,broken_streams_quirk:
You should imply this from the compatible property.
(Also, don't use '_' in property names).
> + description: set if the controller doesn't support bulk stream but
> + HCCPARAMS says support.
> + type: boolean
> +
> "#address-cells":
> const: 1
>
> --
> 2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-21 19:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 11:51 [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-16 11:51 ` [PATCH 2/3] usb: xhci-mtk: fix UAS issue by XHCI_BROKEN_STREAMS quirk Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-16 12:28 ` Nicolas Boichat
2020-12-16 12:28 ` Nicolas Boichat
2020-12-16 12:28 ` Nicolas Boichat
2020-12-17 2:19 ` Chunfeng Yun
2020-12-17 2:19 ` Chunfeng Yun
2020-12-17 2:19 ` Chunfeng Yun
2020-12-17 3:32 ` Nicolas Boichat
2020-12-17 3:32 ` Nicolas Boichat
2020-12-17 3:32 ` Nicolas Boichat
2020-12-17 6:23 ` Chunfeng Yun
2020-12-17 6:23 ` Chunfeng Yun
2020-12-17 6:23 ` Chunfeng Yun
2020-12-21 19:35 ` Rob Herring
2020-12-21 19:35 ` Rob Herring
2020-12-21 19:35 ` Rob Herring
2020-12-25 6:12 ` Chunfeng Yun
2020-12-25 6:12 ` Chunfeng Yun
2020-12-25 6:12 ` Chunfeng Yun
2020-12-17 3:43 ` Rosen Penev
2020-12-17 3:43 ` Rosen Penev
2020-12-17 3:43 ` Rosen Penev
2020-12-24 7:18 ` Chunfeng Yun
2020-12-24 7:18 ` Chunfeng Yun
2020-12-24 7:18 ` Chunfeng Yun
[not found] ` <7ad022d3-ff83-9126-ee74-6d1e4d381366@gmail.com>
2021-02-01 1:47 ` Chunfeng Yun
2021-02-01 1:47 ` Chunfeng Yun
2021-02-01 1:47 ` Chunfeng Yun
2020-12-16 11:51 ` [PATCH 3/3] arm64: dts: mt8173: add a broken streams quirk property for xHCI node Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-16 11:51 ` Chunfeng Yun
2020-12-21 19:29 ` Rob Herring [this message]
2020-12-21 19:29 ` [PATCH 1/3] dt-bindings: usb: mtk-xhci: add a new property for broken streams Rob Herring
2020-12-21 19:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221192913.GA407645@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsinyi@chromium.org \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.