From: Parav Pandit <parav@nvidia.com>
To: <virtualization@lists.linux-foundation.org>
Cc: <mst@redhat.com>, <jasowang@redhat.com>, <parav@nvidia.com>,
<elic@nvidia.com>, <netdev@vger.kernel.org>
Subject: [PATCH linux-next v2 2/7] vdpa_sim_net: Add module param to disable default vdpa net device
Date: Mon, 4 Jan 2021 05:31:36 +0200 [thread overview]
Message-ID: <20210104033141.105876-3-parav@nvidia.com> (raw)
In-Reply-To: <20210104033141.105876-1-parav@nvidia.com>
To support creating multiple vdpa devices and to allow user to
manage them, add a knob to disable a default vdpa net device.
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
Changelog:
v1->v2:
- new patch
---
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 41 ++++++++++++++++++++--------
1 file changed, 29 insertions(+), 12 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index f0482427186b..34155831538c 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
@@ -33,6 +33,10 @@ static char *macaddr;
module_param(macaddr, charp, 0);
MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
+static bool default_device = true;
+module_param(default_device, bool, 0);
+MODULE_PARM_DESC(default_device, "Support single default VDPA device");
+
static u8 macaddr_buf[ETH_ALEN];
static struct vdpasim *vdpasim_net_dev;
@@ -120,21 +124,11 @@ static void vdpasim_net_get_config(struct vdpasim *vdpasim, void *config)
memcpy(net_config->mac, macaddr_buf, ETH_ALEN);
}
-static int __init vdpasim_net_init(void)
+static int vdpasim_net_default_dev_register(void)
{
struct vdpasim_dev_attr dev_attr = {};
int ret;
- if (macaddr) {
- mac_pton(macaddr, macaddr_buf);
- if (!is_valid_ether_addr(macaddr_buf)) {
- ret = -EADDRNOTAVAIL;
- goto out;
- }
- } else {
- eth_random_addr(macaddr_buf);
- }
-
dev_attr.id = VIRTIO_ID_NET;
dev_attr.supported_features = VDPASIM_NET_FEATURES;
dev_attr.nvqs = VDPASIM_NET_VQ_NUM;
@@ -161,13 +155,36 @@ static int __init vdpasim_net_init(void)
return ret;
}
-static void __exit vdpasim_net_exit(void)
+static void vdpasim_net_default_dev_unregister(void)
{
struct vdpa_device *vdpa = &vdpasim_net_dev->vdpa;
vdpa_unregister_device(vdpa);
}
+static int __init vdpasim_net_init(void)
+{
+ int ret = 0;
+
+ if (macaddr) {
+ mac_pton(macaddr, macaddr_buf);
+ if (!is_valid_ether_addr(macaddr_buf))
+ return -EADDRNOTAVAIL;
+ } else {
+ eth_random_addr(macaddr_buf);
+ }
+
+ if (default_device)
+ ret = vdpasim_net_default_dev_register();
+ return ret;
+}
+
+static void __exit vdpasim_net_exit(void)
+{
+ if (default_device)
+ vdpasim_net_default_dev_unregister();
+}
+
module_init(vdpasim_net_init);
module_exit(vdpasim_net_exit);
--
2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: <virtualization@lists.linux-foundation.org>
Cc: netdev@vger.kernel.org, elic@nvidia.com, mst@redhat.com
Subject: [PATCH linux-next v2 2/7] vdpa_sim_net: Add module param to disable default vdpa net device
Date: Mon, 4 Jan 2021 05:31:36 +0200 [thread overview]
Message-ID: <20210104033141.105876-3-parav@nvidia.com> (raw)
In-Reply-To: <20210104033141.105876-1-parav@nvidia.com>
To support creating multiple vdpa devices and to allow user to
manage them, add a knob to disable a default vdpa net device.
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
Changelog:
v1->v2:
- new patch
---
drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 41 ++++++++++++++++++++--------
1 file changed, 29 insertions(+), 12 deletions(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index f0482427186b..34155831538c 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
@@ -33,6 +33,10 @@ static char *macaddr;
module_param(macaddr, charp, 0);
MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
+static bool default_device = true;
+module_param(default_device, bool, 0);
+MODULE_PARM_DESC(default_device, "Support single default VDPA device");
+
static u8 macaddr_buf[ETH_ALEN];
static struct vdpasim *vdpasim_net_dev;
@@ -120,21 +124,11 @@ static void vdpasim_net_get_config(struct vdpasim *vdpasim, void *config)
memcpy(net_config->mac, macaddr_buf, ETH_ALEN);
}
-static int __init vdpasim_net_init(void)
+static int vdpasim_net_default_dev_register(void)
{
struct vdpasim_dev_attr dev_attr = {};
int ret;
- if (macaddr) {
- mac_pton(macaddr, macaddr_buf);
- if (!is_valid_ether_addr(macaddr_buf)) {
- ret = -EADDRNOTAVAIL;
- goto out;
- }
- } else {
- eth_random_addr(macaddr_buf);
- }
-
dev_attr.id = VIRTIO_ID_NET;
dev_attr.supported_features = VDPASIM_NET_FEATURES;
dev_attr.nvqs = VDPASIM_NET_VQ_NUM;
@@ -161,13 +155,36 @@ static int __init vdpasim_net_init(void)
return ret;
}
-static void __exit vdpasim_net_exit(void)
+static void vdpasim_net_default_dev_unregister(void)
{
struct vdpa_device *vdpa = &vdpasim_net_dev->vdpa;
vdpa_unregister_device(vdpa);
}
+static int __init vdpasim_net_init(void)
+{
+ int ret = 0;
+
+ if (macaddr) {
+ mac_pton(macaddr, macaddr_buf);
+ if (!is_valid_ether_addr(macaddr_buf))
+ return -EADDRNOTAVAIL;
+ } else {
+ eth_random_addr(macaddr_buf);
+ }
+
+ if (default_device)
+ ret = vdpasim_net_default_dev_register();
+ return ret;
+}
+
+static void __exit vdpasim_net_exit(void)
+{
+ if (default_device)
+ vdpasim_net_default_dev_unregister();
+}
+
module_init(vdpasim_net_init);
module_exit(vdpasim_net_exit);
--
2.26.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-01-04 3:33 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 6:39 [PATCH 0/7] Introduce vdpa management tool Parav Pandit
2020-11-12 6:39 ` Parav Pandit
2020-11-12 6:39 ` [PATCH 1/7] vdpa: Add missing comment for virtqueue count Parav Pandit
2020-11-12 6:39 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 2/7] vdpa: Use simpler version of ida allocation Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 3/7] vdpa: Extend routine to accept vdpa device name Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 4/7] vdpa: Define vdpa parent device, ops and a netlink interface Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 5/7] vdpa: Enable a user to add and delete a vdpa device Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 6/7] vdpa: Enable user to query vdpa device info Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-12 6:40 ` [PATCH 7/7] vdpa/vdpa_sim: Enable user to create vdpasim net devices Parav Pandit
2020-11-12 6:40 ` Parav Pandit
2020-11-16 9:41 ` [PATCH 0/7] Introduce vdpa management tool Stefan Hajnoczi
2020-11-16 9:41 ` Stefan Hajnoczi
2020-11-17 19:41 ` Parav Pandit
2020-11-17 19:41 ` Parav Pandit
2020-11-16 22:23 ` Jakub Kicinski
2020-11-17 19:51 ` Parav Pandit
2020-11-17 19:51 ` Parav Pandit
2020-12-16 9:13 ` Michael S. Tsirkin
2020-12-16 9:13 ` Michael S. Tsirkin
[not found] ` <20201216080610.08541f44@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2020-12-16 16:54 ` Parav Pandit
2020-12-16 16:54 ` Parav Pandit
2020-12-16 19:57 ` Michael S. Tsirkin
2020-12-16 19:57 ` Michael S. Tsirkin
2020-12-17 12:13 ` Parav Pandit
2020-12-17 12:13 ` Parav Pandit
2020-11-27 3:53 ` Jason Wang
2020-11-27 3:53 ` Jason Wang
[not found] ` <CACycT3sYScObb9nN3g7L3cesjE7sCZWxZ5_5R1usGU9ePZEeqA@mail.gmail.com>
2020-11-30 3:36 ` [External] " Jason Wang
2020-11-30 3:36 ` Jason Wang
2020-11-30 7:07 ` Yongji Xie
2020-12-01 6:25 ` Jason Wang
2020-12-01 6:25 ` Jason Wang
2020-12-01 9:55 ` Yongji Xie
2020-12-01 11:32 ` Parav Pandit
2020-12-01 11:32 ` Parav Pandit
2020-12-01 14:18 ` Yongji Xie
2020-12-01 15:58 ` Parav Pandit
2020-12-01 15:58 ` Parav Pandit
2020-12-02 3:29 ` Yongji Xie
2020-12-02 4:53 ` Parav Pandit
2020-12-02 4:53 ` Parav Pandit
2020-12-02 5:51 ` Jason Wang
2020-12-02 5:51 ` Jason Wang
2020-12-02 6:24 ` Parav Pandit
2020-12-02 6:24 ` Parav Pandit
2020-12-02 7:55 ` Jason Wang
2020-12-02 7:55 ` Jason Wang
2020-12-02 9:27 ` Yongji Xie
2020-12-02 9:21 ` Yongji Xie
2020-12-02 11:13 ` Parav Pandit
2020-12-02 11:13 ` Parav Pandit
2020-12-02 13:18 ` Yongji Xie
2020-12-02 5:48 ` Jason Wang
2020-12-02 5:48 ` Jason Wang
2020-12-08 22:47 ` David Ahern
2020-12-08 22:47 ` David Ahern
2021-01-19 4:21 ` Parav Pandit
2021-01-19 4:21 ` Parav Pandit
2020-12-16 9:16 ` Michael S. Tsirkin
2020-12-16 9:16 ` Michael S. Tsirkin
2021-01-04 3:31 ` [PATCH linux-next v2 " Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 3:31 ` [PATCH linux-next v2 1/7] vdpa_sim_net: Make mac address array static Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 7:00 ` Jason Wang
2021-01-04 7:00 ` Jason Wang
2021-01-04 3:31 ` Parav Pandit [this message]
2021-01-04 3:31 ` [PATCH linux-next v2 2/7] vdpa_sim_net: Add module param to disable default vdpa net device Parav Pandit
2021-01-04 3:31 ` [PATCH linux-next v2 3/7] vdpa: Extend routine to accept vdpa device name Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 3:31 ` [PATCH linux-next v2 4/7] vdpa: Define vdpa mgmt device, ops and a netlink interface Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 7:03 ` Jason Wang
2021-01-04 7:03 ` Jason Wang
2021-01-04 7:24 ` Parav Pandit
2021-01-04 7:24 ` Parav Pandit
2021-01-05 4:10 ` Jason Wang
2021-01-05 4:10 ` Jason Wang
2021-01-05 6:33 ` Parav Pandit
2021-01-05 6:33 ` Parav Pandit
2021-01-05 8:36 ` Jason Wang
2021-01-05 8:36 ` Jason Wang
2021-01-04 3:31 ` [PATCH linux-next v2 5/7] vdpa: Enable a user to add and delete a vdpa device Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 3:31 ` [PATCH linux-next v2 6/7] vdpa: Enable user to query vdpa device info Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 3:31 ` [PATCH linux-next v2 7/7] vdpa_sim_net: Add support for user supported devices Parav Pandit
2021-01-04 3:31 ` Parav Pandit
2021-01-04 7:05 ` Jason Wang
2021-01-04 7:05 ` Jason Wang
2021-01-04 7:21 ` Parav Pandit
2021-01-04 7:21 ` Parav Pandit
2021-01-05 4:06 ` Jason Wang
2021-01-05 4:06 ` Jason Wang
2021-01-05 6:22 ` Parav Pandit
2021-01-05 6:22 ` Parav Pandit
2021-01-05 10:31 ` [PATCH linux-next v3 0/6] Introduce vdpa management tool Parav Pandit
2021-01-05 10:31 ` Parav Pandit
2021-01-05 10:31 ` [PATCH linux-next v3 1/6] vdpa_sim_net: Make mac address array static Parav Pandit
2021-01-05 10:31 ` Parav Pandit
2021-01-07 13:45 ` Stefano Garzarella
2021-01-07 13:45 ` Stefano Garzarella
2021-01-05 10:31 ` [PATCH linux-next v3 2/6] vdpa: Extend routine to accept vdpa device name Parav Pandit
2021-01-05 10:31 ` Parav Pandit
2021-01-05 10:32 ` [PATCH linux-next v3 3/6] vdpa: Define vdpa mgmt device, ops and a netlink interface Parav Pandit
2021-01-05 10:32 ` Parav Pandit
2021-01-05 10:32 ` [PATCH linux-next v3 4/6] vdpa: Enable a user to add and delete a vdpa device Parav Pandit
2021-01-05 10:32 ` Parav Pandit
2021-01-05 10:32 ` [PATCH linux-next v3 5/6] vdpa: Enable user to query vdpa device info Parav Pandit
2021-01-05 10:32 ` Parav Pandit
2021-01-05 10:32 ` [PATCH linux-next v3 6/6] vdpa_sim_net: Add support for user supported devices Parav Pandit
2021-01-05 10:32 ` Parav Pandit
2021-01-05 11:48 ` Michael S. Tsirkin
2021-01-05 11:48 ` Michael S. Tsirkin
2021-01-05 12:02 ` Parav Pandit
2021-01-05 12:02 ` Parav Pandit
2021-01-05 12:14 ` Michael S. Tsirkin
2021-01-05 12:14 ` Michael S. Tsirkin
2021-01-05 12:30 ` Parav Pandit
2021-01-05 12:30 ` Parav Pandit
2021-01-05 13:23 ` Michael S. Tsirkin
2021-01-05 13:23 ` Michael S. Tsirkin
2021-01-07 3:48 ` Parav Pandit
2021-01-07 3:48 ` Parav Pandit
2021-01-12 4:14 ` Parav Pandit
2021-01-12 4:14 ` Parav Pandit
2021-01-14 4:17 ` Jason Wang
2021-01-14 4:17 ` Jason Wang
2021-01-14 7:58 ` Parav Pandit
2021-01-14 7:58 ` Parav Pandit
2021-01-15 5:38 ` Jason Wang
2021-01-15 5:38 ` Jason Wang
2021-01-15 6:27 ` Parav Pandit
2021-01-15 6:27 ` Parav Pandit
2021-01-19 11:09 ` Jason Wang
2021-01-19 11:09 ` Jason Wang
2021-01-20 3:21 ` Parav Pandit
2021-01-20 3:21 ` Parav Pandit
2021-01-20 3:46 ` Parav Pandit
2021-01-20 3:46 ` Parav Pandit
2021-01-18 18:03 ` Parav Pandit
2021-01-18 18:03 ` Parav Pandit
2021-01-20 7:53 ` Michael S. Tsirkin
2021-01-20 7:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104033141.105876-3-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.