Re: [PATCH] vnc: add qmp to support change authz

From: Gerd Hoffmann <kraxel@redhat.com>
To: Zihao Chang <changzihao1@huawei.com>
Cc: oscar.zhangbo@huawei.com, qemu-devel@nongnu.org,
	xiexiangyou@huawei.com, armbru@redhat.com
Subject: Re: [PATCH] vnc: add qmp to support change authz
Date: Thu, 7 Jan 2021 17:04:10 +0100	[thread overview]
Message-ID: <20210107160410.bh27ibafc2szsayh@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210107124657.650-1-changzihao1@huawei.com>

  Hi,

> This patch add a new qmp 'change-vnc-authz' to support change the
> tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid
> {
>    "execute":"change-vnc-authz",
>    "arguments":{
>       "index":"object-authz-id",
>       "type":"tls/sasl"
>    }
> }

> +##
> +# @change-vnc-authz:
> +#
> +# Change the VNC server authz.
> +#
> +# @type:  the new authz type to use with VNC authentication
> +# @index:  the new authz object index to use with VNC authentication
> +#
> +# Since: 5.2
> +#
> +##
> +{ 'command': 'change-vnc-authz',
> +  'data': { 'type' : 'str',
> +            'index': 'str'},
> +  'if': 'defined(CONFIG_VNC_SASL)' }

type should be an enum I think.

Also index should be an int (and possibly an optional argument so you
can just not specify index to unset).

take care,
  Gerd