Re: [PATCH] vnc: add qmp to support change authz

From: Gerd Hoffmann <kraxel@redhat.com>
To: Zihao Chang <changzihao1@huawei.com>
Cc: oscar.zhangbo@huawei.com, qemu-devel@nongnu.org,
	xiexiangyou@huawei.com, armbru@redhat.com
Subject: Re: [PATCH] vnc: add qmp to support change authz
Date: Mon, 11 Jan 2021 09:20:33 +0100	[thread overview]
Message-ID: <20210111082033.2izlpltm7gi5o5fa@sirius.home.kraxel.org> (raw)
In-Reply-To: <9b83b14a-61b1-d638-8924-af5ed32c55a3@huawei.com>

> >> +{ 'command': 'change-vnc-authz',
> >> +  'data': { 'type' : 'str',
> >> +            'index': 'str'},
> >> +  'if': 'defined(CONFIG_VNC_SASL)' }
> > 
> > type should be an enum I think.
> It is a good idea to set type to enum, I will fix it in the next version.
> 
> > Also index should be an int (and possibly an optional argument so you
> > can just not specify index to unset).
> > 
> Index is the id of authz object(myauthz, user can set it as they wanted), may not use int.
> -object authz-simple,id=myauthz,identity=test1

Name it "auth-id" then?  "index" sounds like a number ...

> BTW, Daniel P . BerrangÃ© suggests that all property set QMP commands should be integrated
> as an general purpose "display_update" QMP command. That's really a good idea.

Makes sense indeed.

take care,
  Gerd