From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 08/17] media: camss: Refactor CSID HW version support
Date: Sat, 09 Jan 2021 02:02:54 +0800 [thread overview]
Message-ID: <202101090148.1lCFKiR7-lkp@intel.com> (raw)
In-Reply-To: <20210108120429.895046-9-robert.foss@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 9826 bytes --]
Hi Robert,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on arm64/for-next/core v5.11-rc2 next-20210108]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Robert-Foss/Add-support-for-SDM845-Camera-Subsystem/20210108-200847
base: git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5a42146d4fd78efec431538aa957118944f135b0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Robert-Foss/Add-support-for-SDM845-Camera-Subsystem/20210108-200847
git checkout 5a42146d4fd78efec431538aa957118944f135b0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/err.h:5,
from include/linux/clk.h:12,
from drivers/media/platform/qcom/camss/camss.c:10:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from drivers/media/platform/qcom/camss/camss.h:21,
from drivers/media/platform/qcom/camss/camss.c:28:
drivers/media/platform/qcom/camss/camss-csid.h: At top level:
>> drivers/media/platform/qcom/camss/camss-csid.h:154:2: error: expected specifier-qualifier-list before 'irqreturn_t'
154 | irqreturn_t (*isr)(int irq, void *dev);
| ^~~~~~~~~~~
drivers/media/platform/qcom/camss/camss.c:468:31: warning: 'vfe_res_845' defined but not used [-Wunused-const-variable=]
468 | static const struct resources vfe_res_845[] = {
| ^~~~~~~~~~~
In file included from drivers/media/platform/qcom/camss/camss.h:21,
from drivers/media/platform/qcom/camss/camss.c:28:
drivers/media/platform/qcom/camss/camss-csid.h:91:27: warning: 'csid_testgen_modes' defined but not used [-Wunused-const-variable=]
91 | static const char * const csid_testgen_modes[] = {
| ^~~~~~~~~~~~~~~~~~
--
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from drivers/media/platform/qcom/camss/camss.h:13,
from drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:11:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from drivers/media/platform/qcom/camss/camss.h:21,
from drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:11:
drivers/media/platform/qcom/camss/camss-csid.h: At top level:
>> drivers/media/platform/qcom/camss/camss-csid.h:154:2: error: expected specifier-qualifier-list before 'irqreturn_t'
154 | irqreturn_t (*isr)(int irq, void *dev);
| ^~~~~~~~~~~
drivers/media/platform/qcom/camss/camss-csid.h:91:27: warning: 'csid_testgen_modes' defined but not used [-Wunused-const-variable=]
91 | static const char * const csid_testgen_modes[] = {
| ^~~~~~~~~~~~~~~~~~
--
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from drivers/media/platform/qcom/camss/camss.h:13,
from drivers/media/platform/qcom/camss/camss-vfe-gen1.c:11:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
In file included from drivers/media/platform/qcom/camss/camss.h:21,
from drivers/media/platform/qcom/camss/camss-vfe-gen1.c:11:
drivers/media/platform/qcom/camss/camss-csid.h: At top level:
>> drivers/media/platform/qcom/camss/camss-csid.h:154:2: error: expected specifier-qualifier-list before 'irqreturn_t'
154 | irqreturn_t (*isr)(int irq, void *dev);
| ^~~~~~~~~~~
drivers/media/platform/qcom/camss/camss-vfe-gen1.c: In function 'vfe_output_update_pong_addr':
drivers/media/platform/qcom/camss/camss-vfe-gen1.c:411:6: warning: variable 'addr' set but not used [-Wunused-but-set-variable]
411 | u32 addr;
| ^~~~
In file included from drivers/media/platform/qcom/camss/camss.h:21,
from drivers/media/platform/qcom/camss/camss-vfe-gen1.c:11:
At top level:
drivers/media/platform/qcom/camss/camss-csid.h:91:27: warning: 'csid_testgen_modes' defined but not used [-Wunused-const-variable=]
91 | static const char * const csid_testgen_modes[] = {
| ^~~~~~~~~~~~~~~~~~
vim +/irqreturn_t +154 drivers/media/platform/qcom/camss/camss-csid.h
126
127 struct csid_hw_ops {
128 /*
129 * configure_stream - Configures and starts CSID input stream
130 * @csid: CSID device
131 */
132 void (*configure_stream)(struct csid_device *csid, u8 enable);
133
134 /*
135 * configure_testgen_pattern - Validates and configures output pattern mode
136 * of test pattern generator
137 * @csid: CSID device
138 */
139 int (*configure_testgen_pattern)(struct csid_device *csid, s32 val);
140
141 /*
142 * hw_version - Read hardware version register from hardware
143 * @csid: CSID device
144 */
145 u32 (*hw_version)(struct csid_device *csid);
146
147 /*
148 * isr - CSID module interrupt service routine
149 * @irq: Interrupt line
150 * @dev: CSID device
151 *
152 * Return IRQ_HANDLED on success
153 */
> 154 irqreturn_t (*isr)(int irq, void *dev);
155
156 /*
157 * reset - Trigger reset on CSID module and wait to complete
158 * @csid: CSID device
159 *
160 * Return 0 on success or a negative error code otherwise
161 */
162 int (*reset)(struct csid_device *csid);
163
164 /*
165 * src_pad_code - Pick an output/src format based on the input/sink format
166 * @csid: CSID device
167 * @sink_code: The sink format of the input
168 * @match_format_idx: Request preferred index, as defined by subdevice csid_format.
169 * Set @match_code to 0 if used.
170 * @match_code: Request preferred code, set @match_format_idx to 0 if used
171 *
172 * Return 0 on failure or src format code otherwise
173 */
174 u32 (*src_pad_code)(struct csid_device *csid, u32 sink_code,
175 unsigned int match_format_idx, u32 match_code);
176
177 /*
178 * subdev_init - Initialize CSID device according for hardware revision
179 * @csid: CSID device
180 */
181 void (*subdev_init)(struct csid_device *csid);
182 };
183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59584 bytes --]
next prev parent reply other threads:[~2021-01-08 18:02 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 12:04 [PATCH v1 00/17] Add support for SDM845 Camera Subsystem Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 01/17] media: camss: Fix comment using wrong function name Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 18:51 ` Bjorn Andersson
2021-01-08 18:51 ` Bjorn Andersson
2021-01-13 10:04 ` Robert Foss
2021-01-13 10:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 02/17] media: camss: Fix vfe_isr comment typo Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 18:51 ` Bjorn Andersson
2021-01-08 18:51 ` Bjorn Andersson
2021-01-13 10:04 ` Robert Foss
2021-01-13 10:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 03/17] media: camss: Add CAMSS_845 camss version Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 04/17] media: camss: Make ISPIF subdevice optional Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 19:07 ` Bjorn Andersson
2021-01-08 19:07 ` Bjorn Andersson
2021-01-13 15:02 ` Robert Foss
2021-01-13 15:02 ` Robert Foss
2021-01-13 22:28 ` Andrey Konovalov
2021-01-13 22:28 ` Andrey Konovalov
2021-01-14 9:55 ` Robert Foss
2021-01-14 9:55 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 05/17] media: camss: Refactor VFE HW version support Robert Foss
2021-01-08 16:51 ` kernel test robot
2021-01-13 22:38 ` Andrey Konovalov
2021-01-14 10:07 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 06/17] media: camss: Add support for VFE hardware version Titan 170 Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-14 10:48 ` Andrey Konovalov
2021-01-14 10:48 ` Andrey Konovalov
2021-01-14 12:07 ` Robert Foss
2021-01-14 12:07 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 07/17] media: camss: Add missing format identifiers Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 08/17] media: camss: Refactor CSID HW version support Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 18:02 ` kernel test robot [this message]
2021-01-08 12:04 ` [PATCH v1 09/17] media: camss: Add support for CSID hardware version Titan 170 Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 10/17] media: camss: Add support for CSIPHY " Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 11/17] media: camss: Remove per VFE power domain toggling Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 12/17] media: dt-bindings: media: qcom,camss: Add bindings for SDM845 camss Robert Foss
2021-01-08 12:04 ` [PATCH v1 12/17] media: dt-bindings: media: qcom, camss: " Robert Foss
2021-01-09 1:44 ` [PATCH v1 12/17] media: dt-bindings: media: qcom,camss: " Laurent Pinchart
2021-01-09 1:44 ` Laurent Pinchart
2021-01-08 12:04 ` [PATCH v1 13/17] media: camss: Enable SDM845 Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 14/17] arm64: defconfig: Build Qcom CAMSS as module Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 15/17] arm64: dts: sdm845: Add CAMSS ISP node Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 16/17] arm64: dts: sdm845-db845c: " Robert Foss
2021-01-08 12:04 ` Robert Foss
2021-01-09 1:47 ` Laurent Pinchart
2021-01-09 1:47 ` Laurent Pinchart
2021-01-13 10:03 ` Robert Foss
2021-01-13 10:03 ` Robert Foss
2021-01-08 12:04 ` [PATCH v1 17/17] arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP Robert Foss
2021-01-08 12:04 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101090148.1lCFKiR7-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.