From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Robert Foss <robert.foss@linaro.org> Cc: agross@kernel.org, bjorn.andersson@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, leoyang.li@nxp.com, geert+renesas@glider.be, arnd@arndb.de, Anson.Huang@nxp.com, michael@walle.cc, agx@sigxcpu.org, max.oss.09@gmail.com, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno <kholk11@gmail.com>, Andrey Konovalov <andrey.konovalov@linaro.org>, Tomasz Figa <tfiga@chromium.org>, Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>, Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com> Subject: Re: [PATCH v1 16/17] arm64: dts: sdm845-db845c: Add CAMSS ISP node Date: Sat, 9 Jan 2021 03:47:32 +0200 [thread overview] Message-ID: <X/kLNCOjvTmANYbr@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210108120429.895046-17-robert.foss@linaro.org> Hi Rob, Thank you for the patch. The subject line doesn't match the patch. On Fri, Jan 08, 2021 at 01:04:28PM +0100, Robert Foss wrote: > Add regulators and camss DT node. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index a943b3f353ce..7bad0515345e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -294,6 +294,9 @@ vreg_s7a_1p025: smps7 { > regulator-max-microvolt = <1028000>; > }; > > + vdda_mipi_csi0_0p9: > + vdda_mipi_csi1_0p9: > + vdda_mipi_csi2_0p9: No need for new labels, you can simply use vreg_l1a_0p875 below. > vreg_l1a_0p875: ldo1 { > regulator-min-microvolt = <880000>; > regulator-max-microvolt = <880000>; > @@ -1106,6 +1109,15 @@ &cci { > status = "okay"; > }; > > +&camss { > + vdda-csi0-supply = <&vdda_mipi_csi0_0p9>; > + vdda-csi1-supply = <&vdda_mipi_csi1_0p9>; > + vdda-csi2-supply = <&vdda_mipi_csi2_0p9>; > + > + status = "disabled"; This isn't needed. > + Extra blank line. > +}; > + > &cci_i2c0 { > camera@10 { > compatible = "ovti,ov8856"; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Robert Foss <robert.foss@linaro.org> Cc: geert+renesas@glider.be, catalin.marinas@arm.com, agx@sigxcpu.org, todor.too@gmail.com, bjorn.andersson@linaro.org, AngeloGioacchino Del Regno <kholk11@gmail.com>, will@kernel.org, Anson.Huang@nxp.com, agross@kernel.org, Andrey Konovalov <andrey.konovalov@linaro.org>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>, arnd@arndb.de, linux-arm-msm@vger.kernel.org, robh+dt@kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>, max.oss.09@gmail.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, michael@walle.cc, Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>, shawnguo@kernel.org Subject: Re: [PATCH v1 16/17] arm64: dts: sdm845-db845c: Add CAMSS ISP node Date: Sat, 9 Jan 2021 03:47:32 +0200 [thread overview] Message-ID: <X/kLNCOjvTmANYbr@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210108120429.895046-17-robert.foss@linaro.org> Hi Rob, Thank you for the patch. The subject line doesn't match the patch. On Fri, Jan 08, 2021 at 01:04:28PM +0100, Robert Foss wrote: > Add regulators and camss DT node. > > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index a943b3f353ce..7bad0515345e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -294,6 +294,9 @@ vreg_s7a_1p025: smps7 { > regulator-max-microvolt = <1028000>; > }; > > + vdda_mipi_csi0_0p9: > + vdda_mipi_csi1_0p9: > + vdda_mipi_csi2_0p9: No need for new labels, you can simply use vreg_l1a_0p875 below. > vreg_l1a_0p875: ldo1 { > regulator-min-microvolt = <880000>; > regulator-max-microvolt = <880000>; > @@ -1106,6 +1109,15 @@ &cci { > status = "okay"; > }; > > +&camss { > + vdda-csi0-supply = <&vdda_mipi_csi0_0p9>; > + vdda-csi1-supply = <&vdda_mipi_csi1_0p9>; > + vdda-csi2-supply = <&vdda_mipi_csi2_0p9>; > + > + status = "disabled"; This isn't needed. > + Extra blank line. > +}; > + > &cci_i2c0 { > camera@10 { > compatible = "ovti,ov8856"; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-09 1:48 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 12:04 [PATCH v1 00/17] Add support for SDM845 Camera Subsystem Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 01/17] media: camss: Fix comment using wrong function name Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 18:51 ` Bjorn Andersson 2021-01-08 18:51 ` Bjorn Andersson 2021-01-13 10:04 ` Robert Foss 2021-01-13 10:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 02/17] media: camss: Fix vfe_isr comment typo Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 18:51 ` Bjorn Andersson 2021-01-08 18:51 ` Bjorn Andersson 2021-01-13 10:04 ` Robert Foss 2021-01-13 10:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 03/17] media: camss: Add CAMSS_845 camss version Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 04/17] media: camss: Make ISPIF subdevice optional Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 19:07 ` Bjorn Andersson 2021-01-08 19:07 ` Bjorn Andersson 2021-01-13 15:02 ` Robert Foss 2021-01-13 15:02 ` Robert Foss 2021-01-13 22:28 ` Andrey Konovalov 2021-01-13 22:28 ` Andrey Konovalov 2021-01-14 9:55 ` Robert Foss 2021-01-14 9:55 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 05/17] media: camss: Refactor VFE HW version support Robert Foss 2021-01-08 16:51 ` kernel test robot 2021-01-13 22:38 ` Andrey Konovalov 2021-01-14 10:07 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 06/17] media: camss: Add support for VFE hardware version Titan 170 Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-14 10:48 ` Andrey Konovalov 2021-01-14 10:48 ` Andrey Konovalov 2021-01-14 12:07 ` Robert Foss 2021-01-14 12:07 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 07/17] media: camss: Add missing format identifiers Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 08/17] media: camss: Refactor CSID HW version support Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 18:02 ` kernel test robot 2021-01-08 12:04 ` [PATCH v1 09/17] media: camss: Add support for CSID hardware version Titan 170 Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 10/17] media: camss: Add support for CSIPHY " Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 11/17] media: camss: Remove per VFE power domain toggling Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 12/17] media: dt-bindings: media: qcom,camss: Add bindings for SDM845 camss Robert Foss 2021-01-08 12:04 ` [PATCH v1 12/17] media: dt-bindings: media: qcom, camss: " Robert Foss 2021-01-09 1:44 ` [PATCH v1 12/17] media: dt-bindings: media: qcom,camss: " Laurent Pinchart 2021-01-09 1:44 ` Laurent Pinchart 2021-01-08 12:04 ` [PATCH v1 13/17] media: camss: Enable SDM845 Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 14/17] arm64: defconfig: Build Qcom CAMSS as module Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 15/17] arm64: dts: sdm845: Add CAMSS ISP node Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 16/17] arm64: dts: sdm845-db845c: " Robert Foss 2021-01-08 12:04 ` Robert Foss 2021-01-09 1:47 ` Laurent Pinchart [this message] 2021-01-09 1:47 ` Laurent Pinchart 2021-01-13 10:03 ` Robert Foss 2021-01-13 10:03 ` Robert Foss 2021-01-08 12:04 ` [PATCH v1 17/17] arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP Robert Foss 2021-01-08 12:04 ` Robert Foss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X/kLNCOjvTmANYbr@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=Anson.Huang@nxp.com \ --cc=Sarvesh.Sridutt@smartwirelesscompute.com \ --cc=agross@kernel.org \ --cc=agx@sigxcpu.org \ --cc=akapatra@quicinc.com \ --cc=andrey.konovalov@linaro.org \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=kholk11@gmail.com \ --cc=leoyang.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=max.oss.09@gmail.com \ --cc=mchehab@kernel.org \ --cc=michael@walle.cc \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tfiga@chromium.org \ --cc=todor.too@gmail.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.