From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>, Ani Joshi <ajoshi@shell.unixbox.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:49:45 +0000 [thread overview] Message-ID: <20210113145009.1272040-8-lee.jones@linaro.org> (raw) In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/fbdev.c:485: warning: Function parameter or member 'data8' not described in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:485: warning: Excess function parameter 'data' description in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'var' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'nom' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:1229: warning: Excess function parameter 'con' description in 'rivafb_pan_display' Cc: Antonino Daplas <adaplas@gmail.com> Cc: Ani Joshi <ajoshi@shell.unixbox.com> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/video/fbdev/riva/fbdev.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c index ce55b9d2e862b..8adf9cf353410 100644 --- a/drivers/video/fbdev/riva/fbdev.c +++ b/drivers/video/fbdev/riva/fbdev.c @@ -464,12 +464,12 @@ static inline void reverse_order(u32 *l) /** * rivafb_load_cursor_image - load cursor image to hardware - * @data: address to monochrome bitmap (1 = foreground color, 0 = background) + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background) * @par: pointer to private data - * @w: width of cursor image in pixels - * @h: height of cursor image in scanlines * @bg: background color (ARGB1555) - alpha bit determines opacity * @fg: foreground color (ARGB1555) + * @w: width of cursor image in pixels + * @h: height of cursor image in scanlines * * DESCRIPTiON: * Loads cursor image based on a monochrome source and mask bitmap. The @@ -840,19 +840,15 @@ static void riva_update_var(struct fb_var_screeninfo *var, NVTRACE_LEAVE(); } -/** - * rivafb_do_maximize - +/* + * rivafb_do_maximize * @info: pointer to fb_info object containing info for current riva board - * @var: - * @nom: - * @den: * * DESCRIPTION: * . * * RETURNS: * -EINVAL on failure, 0 on success - * * * CALLED FROM: * rivafb_check_var() @@ -1214,7 +1210,6 @@ static int rivafb_set_par(struct fb_info *info) /** * rivafb_pan_display * @var: standard kernel fb changeable data - * @con: TODO * @info: pointer to fb_info object containing info for current riva board * * DESCRIPTION: -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: dri-devel@lists.freedesktop.org, Ani Joshi <ajoshi@shell.unixbox.com>, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:49:45 +0000 [thread overview] Message-ID: <20210113145009.1272040-8-lee.jones@linaro.org> (raw) In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/fbdev.c:485: warning: Function parameter or member 'data8' not described in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:485: warning: Excess function parameter 'data' description in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'var' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'nom' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:1229: warning: Excess function parameter 'con' description in 'rivafb_pan_display' Cc: Antonino Daplas <adaplas@gmail.com> Cc: Ani Joshi <ajoshi@shell.unixbox.com> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/video/fbdev/riva/fbdev.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c index ce55b9d2e862b..8adf9cf353410 100644 --- a/drivers/video/fbdev/riva/fbdev.c +++ b/drivers/video/fbdev/riva/fbdev.c @@ -464,12 +464,12 @@ static inline void reverse_order(u32 *l) /** * rivafb_load_cursor_image - load cursor image to hardware - * @data: address to monochrome bitmap (1 = foreground color, 0 = background) + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background) * @par: pointer to private data - * @w: width of cursor image in pixels - * @h: height of cursor image in scanlines * @bg: background color (ARGB1555) - alpha bit determines opacity * @fg: foreground color (ARGB1555) + * @w: width of cursor image in pixels + * @h: height of cursor image in scanlines * * DESCRIPTiON: * Loads cursor image based on a monochrome source and mask bitmap. The @@ -840,19 +840,15 @@ static void riva_update_var(struct fb_var_screeninfo *var, NVTRACE_LEAVE(); } -/** - * rivafb_do_maximize - +/* + * rivafb_do_maximize * @info: pointer to fb_info object containing info for current riva board - * @var: - * @nom: - * @den: * * DESCRIPTION: * . * * RETURNS: * -EINVAL on failure, 0 on success - * * * CALLED FROM: * rivafb_check_var() @@ -1214,7 +1210,6 @@ static int rivafb_set_par(struct fb_info *info) /** * rivafb_pan_display * @var: standard kernel fb changeable data - * @con: TODO * @info: pointer to fb_info object containing info for current riva board * * DESCRIPTION: -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-13 14:51 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 14:49 [PATCH 00/31] Rid W=1 warnings from Video Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 01/31] video: fbdev: core: fbmon: Add missing description for 'specs' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 02/31] video: of_display_timing: Provide missing description for 'dt' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 03/31] video: fbdev: aty: atyfb_base: Remove superfluous code surrounding 'dac_type' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 04/31] video: fbdev: aty: atyfb_base: Mark 'dac_type' as __maybe_unused Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 05/31] video: of_videomode: Fix formatting in kernel-doc header Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 06/31] video: fbdev: core: fb_notify: Demote non-conformant " Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` Lee Jones [this message] 2021-01-13 14:49 ` [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Lee Jones 2021-01-13 14:49 ` [PATCH 08/31] video: fbdev: sis: sis_main: Remove unused variable 'reg' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 09/31] video: fbdev: sis: Remove superfluous include of 'init.h' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 10/31] video: fbdev: riva: riva_hw: Remove a bunch of unused variables Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 11/31] video: fbdev: sis: init: Remove four " Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 12/31] video: fbdev: sis: oem310: Remove some unused static const tables Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 13/31] video: fbdev: nvidia: nv_setup: Remove a couple of unused 'tmp' variables Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 15:24 ` Daniël Mantione 2021-01-13 15:24 ` Daniël Mantione 2021-01-13 15:45 ` Lee Jones 2021-01-13 15:45 ` Lee Jones 2021-01-13 14:49 ` [PATCH 15/31] video: fbdev: via: lcd: Remove unused variable 'mode_crt_table' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 16/31] video: fbdev: pm2fb: Fix some kernel-doc formatting issues Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 17/31] video: fbdev: aty: radeon_monitor: Remove unused variable 'mon_types' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 18/31] video: fbdev: neofb: Remove unused variable 'CursorMem' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 19/31] video: fbdev: tdfxfb: Remove unused variable 'tmp' Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 20/31] video: fbdev: core: fbcon: Mark 'pending' as __maybe_unused Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:49 ` [PATCH 21/31] video: fbdev: sstfb: Mark 3 debug variables " Lee Jones 2021-01-13 14:49 ` Lee Jones 2021-01-13 14:50 ` [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 23/31] video: fbdev: s1d13xxxfb: Mark debug variables as __maybe_unused Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 20:07 ` Jingoo Han 2021-01-13 20:07 ` Jingoo Han 2021-01-13 14:50 ` [PATCH 25/31] video: fbdev: mx3fb: Remove unused variable 'enabled' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 26/31] video: fbdev: riva: riva_hw: Remove set but unused variables 'vus_p' and 'vus_n' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 27/31] video: fbdev: sis: init: Remove unused variables 'cr_data2', 'VT' and 'HT' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 28/31] video: fbdev: cirrusfb: Add description for 'info' and correct spelling of 'regbase' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 29/31] video: fbdev: s1d13xxxfb: Function name must be on the 2nd line in kernel-doc Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 14:50 ` [PATCH 30/31] video: fbdev: s3c-fb: Remove unused variable 'var' from 's3c_fb_probe_win()' Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 20:09 ` Jingoo Han 2021-01-13 20:09 ` Jingoo Han 2021-01-13 14:50 ` [PATCH 31/31] video: fbdev: mx3fb: Fix some kernel-doc issues Lee Jones 2021-01-13 14:50 ` Lee Jones 2021-01-13 19:01 ` [PATCH 00/31] Rid W=1 warnings from Video Sam Ravnborg 2021-01-13 19:01 ` Sam Ravnborg 2021-01-13 20:25 ` Lee Jones 2021-01-13 20:25 ` Lee Jones 2021-01-14 9:04 ` Jani Nikula 2021-01-14 9:04 ` Jani Nikula 2021-01-14 9:11 ` Daniel Vetter 2021-01-14 9:11 ` Daniel Vetter 2021-01-14 9:54 ` Daniel Vetter 2021-01-14 9:54 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210113145009.1272040-8-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=adaplas@gmail.com \ --cc=ajoshi@shell.unixbox.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.