From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, VMware Graphics <linux-graphics-maintainer@vmware.com>, Roland Scheidegger <sroland@vmware.com>, Zack Rusin <zackr@vmware.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org Subject: [PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Date: Fri, 15 Jan 2021 18:15:40 +0000 [thread overview] Message-ID: <20210115181601.3432599-9-lee.jones@linaro.org> (raw) In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup' Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> Cc: Roland Scheidegger <sroland@vmware.com> Cc: Zack Rusin <zackr@vmware.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f2e2bf6d1421f..e7570f422400d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c @@ -48,7 +48,6 @@ struct vmw_validation_bo_node { u32 as_mob : 1; u32 cpu_blit : 1; }; - /** * struct vmw_validation_res_node - Resource validation metadata. * @head: List head for the resource validation list. @@ -64,6 +63,8 @@ struct vmw_validation_bo_node { * @first_usage: True iff the resource has been seen only once in the current * validation batch. * @reserved: Whether the resource is currently reserved by this process. + * @dirty_set: Change dirty status of the resource. + * @dirty: Dirty information VMW_RES_DIRTY_XX. * @private: Optionally additional memory for caller-private data. * * Bit fields are used since these structures are allocated and freed in @@ -205,7 +206,7 @@ vmw_validation_find_bo_dup(struct vmw_validation_context *ctx, * vmw_validation_find_res_dup - Find a duplicate resource entry in the * validation context's lists. * @ctx: The validation context to search. - * @vbo: The buffer object to search for. + * @res: Reference counted resource pointer. * * Return: Pointer to the struct vmw_validation_bo_node referencing the * duplicate, or NULL if none found. -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: lee.jones@linaro.org Cc: David Airlie <airlied@linux.ie>, Roland Scheidegger <sroland@vmware.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, VMware Graphics <linux-graphics-maintainer@vmware.com> Subject: [PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Date: Fri, 15 Jan 2021 18:15:40 +0000 [thread overview] Message-ID: <20210115181601.3432599-9-lee.jones@linaro.org> (raw) In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:85: warning: Function parameter or member 'dirty_set' not described in 'vmw_validation_res_node' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Function parameter or member 'res' not described in 'vmw_validation_find_res_dup' drivers/gpu/drm/vmwgfx/vmwgfx_validation.c:216: warning: Excess function parameter 'vbo' description in 'vmw_validation_find_res_dup' Cc: VMware Graphics <linux-graphics-maintainer@vmware.com> Cc: Roland Scheidegger <sroland@vmware.com> Cc: Zack Rusin <zackr@vmware.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c index f2e2bf6d1421f..e7570f422400d 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_validation.c @@ -48,7 +48,6 @@ struct vmw_validation_bo_node { u32 as_mob : 1; u32 cpu_blit : 1; }; - /** * struct vmw_validation_res_node - Resource validation metadata. * @head: List head for the resource validation list. @@ -64,6 +63,8 @@ struct vmw_validation_bo_node { * @first_usage: True iff the resource has been seen only once in the current * validation batch. * @reserved: Whether the resource is currently reserved by this process. + * @dirty_set: Change dirty status of the resource. + * @dirty: Dirty information VMW_RES_DIRTY_XX. * @private: Optionally additional memory for caller-private data. * * Bit fields are used since these structures are allocated and freed in @@ -205,7 +206,7 @@ vmw_validation_find_bo_dup(struct vmw_validation_context *ctx, * vmw_validation_find_res_dup - Find a duplicate resource entry in the * validation context's lists. * @ctx: The validation context to search. - * @vbo: The buffer object to search for. + * @res: Reference counted resource pointer. * * Return: Pointer to the struct vmw_validation_bo_node referencing the * duplicate, or NULL if none found. -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-15 18:20 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-15 18:15 [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Lee Jones 2021-01-15 18:15 ` [Intel-gfx] " Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 01/29] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 02/29] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 03/29] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 04/29] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 05/29] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg' Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 06/29] drm/gma500/mmu: Actually return an error if one occurs Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 07/29] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` Lee Jones [this message] 2021-01-15 18:15 ` [PATCH 08/29] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Lee Jones 2021-01-15 18:15 ` [PATCH 09/29] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 10/29] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager' Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 11/29] drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 12/29] drm/gma500/psb_irq: Demote kernel-doc abuse Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 13/29] drm/drm_dp_helper: Fix spelling issue and add missing description for 'enable_frl_ready_hpd' Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 14/29] drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in 'cdv_intel_crt_detect_hotplug()'s header Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 15/29] drm/gma500/cdv_intel_display: Demote kernel-doc abuse in 'cdv_intel_panel_fitter_pipe()'s header Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 16/29] drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks and fix another Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 17/29] drm/gma500/cdv_intel_dp: Demote one unworthy header " Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 18/29] drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp' Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 19/29] drm/gma500/oaktrail_lvds: Demote one documentation header fix another Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 20/29] drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 21/29] drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting abuses Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 22/29] drm/gma500/mdfld_intel_display: Demote three " Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 23/29] drm/drm_agpsupport: Strip out obviously wrong descriptions and demote to standard headers Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 24/29] drm/i915/gvt/handlers: Remove kernel-doc formatting from non-kernel-doc header Lee Jones 2021-01-15 18:15 ` [Intel-gfx] " Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 25/29] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 26/29] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:15 ` [PATCH 27/29] drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from 'nouveau_bios_init()' Lee Jones 2021-01-15 18:15 ` Lee Jones 2021-01-15 18:16 ` [PATCH 28/29] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones 2021-01-15 18:16 ` Lee Jones 2021-01-15 18:16 ` [PATCH 29/29] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones 2021-01-15 18:16 ` Lee Jones 2021-01-15 18:27 ` [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU! Zack Rusin 2021-01-15 18:27 ` [Intel-gfx] " Zack Rusin 2021-01-15 18:27 ` Zack Rusin 2021-01-15 18:27 ` Zack Rusin 2021-01-18 9:49 ` Daniel Vetter 2021-01-18 9:49 ` [Intel-gfx] " Daniel Vetter 2021-01-18 9:49 ` Daniel Vetter 2021-01-18 9:49 ` Daniel Vetter 2021-01-18 14:54 ` Daniel Vetter 2021-01-18 14:54 ` [Intel-gfx] " Daniel Vetter 2021-01-18 14:54 ` Daniel Vetter 2021-01-18 14:54 ` Daniel Vetter [not found] ` <YAWhDRkSOHbJ+2Le-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2021-01-18 15:09 ` Lee Jones 2021-01-18 15:09 ` Lee Jones 2021-01-18 15:09 ` [Intel-gfx] " Lee Jones 2021-01-18 15:09 ` Lee Jones 2021-01-18 17:21 ` Daniel Vetter 2021-01-18 17:21 ` [Intel-gfx] " Daniel Vetter 2021-01-18 17:21 ` Daniel Vetter 2021-01-18 17:21 ` Daniel Vetter 2021-01-19 8:29 ` Lee Jones 2021-01-19 8:29 ` [Intel-gfx] " Lee Jones 2021-01-19 8:29 ` Lee Jones 2021-01-19 19:27 ` Zack Rusin 2021-01-19 19:27 ` [Intel-gfx] " Zack Rusin 2021-01-19 19:27 ` Zack Rusin 2021-01-19 19:27 ` Zack Rusin 2021-01-20 8:05 ` Lee Jones 2021-01-20 8:05 ` [Intel-gfx] " Lee Jones 2021-01-20 8:05 ` Lee Jones 2021-01-20 8:05 ` Lee Jones [not found] ` <YAXDgmWMR9s4OgxN-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> 2021-01-19 8:29 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210115181601.3432599-9-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-graphics-maintainer@vmware.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sroland@vmware.com \ --cc=zackr@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.