From: Emmanuel Vadot <manu@bidouilliste.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
devicetree@vger.kernel.org, bcousson@baylibre.com,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2
Date: Fri, 15 Jan 2021 19:02:01 +0100 [thread overview]
Message-ID: <20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com> (raw)
In-Reply-To: <20200701013320.130441-3-drew@beagleboard.org>
Hello Drew,
On Wed, 1 Jul 2020 03:33:20 +0200
Drew Fustini <drew@beagleboard.org> wrote:
> Increase #pinctrl-cells to 2 so that mux and conf be kept separate. This
> requires the AM33XX_PADCONF macro in omap.h to also be modified to keep pin
> conf and pin mux values separate.
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> arch/arm/boot/dts/am33xx-l4.dtsi | 2 +-
> include/dt-bindings/pinctrl/omap.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index a9cbefc80c0c..3141590e5889 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -278,7 +278,7 @@ scm: scm@0 {
> am33xx_pinmux: pinmux@800 {
> compatible = "pinctrl-single";
> reg = <0x800 0x238>;
> - #pinctrl-cells = <1>;
> + #pinctrl-cells = <2>;
> pinctrl-single,register-width = <32>;
> pinctrl-single,function-mask = <0x7f>;
> };
> diff --git a/include/dt-bindings/pinctrl/omap.h b/include/dt-bindings/pinctrl/omap.h
> index 625718042413..2d2a8c737822 100644
> --- a/include/dt-bindings/pinctrl/omap.h
> +++ b/include/dt-bindings/pinctrl/omap.h
> @@ -65,7 +65,7 @@
> #define DM814X_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> #define DM816X_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> #define AM33XX_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> -#define AM33XX_PADCONF(pa, dir, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) ((dir) | (mux))
> +#define AM33XX_PADCONF(pa, conf, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) (conf) (mux)
>
> /*
> * Macros to allow using the offset from the padconf physical address
> --
> 2.25.1
Based on the bindings doc a value of 2 is only acceptable if one uses
pinctrl-single,bits but all the am33xx pins still uses
pinctrl-single,pins.
I noticed this because this breaks FreeBSD when I tried with 5.9 dts.
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
WARNING: multiple messages have this Message-ID (diff)
From: Emmanuel Vadot <manu@bidouilliste.com>
To: Drew Fustini <drew@beagleboard.org>
Cc: devicetree@vger.kernel.org,
Jason Kridner <jkridner@beagleboard.org>,
Tony Lindgren <tony@atomide.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2
Date: Fri, 15 Jan 2021 19:02:01 +0100 [thread overview]
Message-ID: <20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com> (raw)
In-Reply-To: <20200701013320.130441-3-drew@beagleboard.org>
Hello Drew,
On Wed, 1 Jul 2020 03:33:20 +0200
Drew Fustini <drew@beagleboard.org> wrote:
> Increase #pinctrl-cells to 2 so that mux and conf be kept separate. This
> requires the AM33XX_PADCONF macro in omap.h to also be modified to keep pin
> conf and pin mux values separate.
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> arch/arm/boot/dts/am33xx-l4.dtsi | 2 +-
> include/dt-bindings/pinctrl/omap.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
> index a9cbefc80c0c..3141590e5889 100644
> --- a/arch/arm/boot/dts/am33xx-l4.dtsi
> +++ b/arch/arm/boot/dts/am33xx-l4.dtsi
> @@ -278,7 +278,7 @@ scm: scm@0 {
> am33xx_pinmux: pinmux@800 {
> compatible = "pinctrl-single";
> reg = <0x800 0x238>;
> - #pinctrl-cells = <1>;
> + #pinctrl-cells = <2>;
> pinctrl-single,register-width = <32>;
> pinctrl-single,function-mask = <0x7f>;
> };
> diff --git a/include/dt-bindings/pinctrl/omap.h b/include/dt-bindings/pinctrl/omap.h
> index 625718042413..2d2a8c737822 100644
> --- a/include/dt-bindings/pinctrl/omap.h
> +++ b/include/dt-bindings/pinctrl/omap.h
> @@ -65,7 +65,7 @@
> #define DM814X_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> #define DM816X_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> #define AM33XX_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val)
> -#define AM33XX_PADCONF(pa, dir, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) ((dir) | (mux))
> +#define AM33XX_PADCONF(pa, conf, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) (conf) (mux)
>
> /*
> * Macros to allow using the offset from the padconf physical address
> --
> 2.25.1
Based on the bindings doc a value of 2 is only acceptable if one uses
pinctrl-single,bits but all the am33xx pins still uses
pinctrl-single,pins.
I noticed this because this breaks FreeBSD when I tried with 5.9 dts.
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-15 18:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 1:33 [PATCH v4 0/2] pinctrl: single: support #pinctrl-cells = 2 Drew Fustini
2020-07-01 1:33 ` Drew Fustini
2020-07-01 1:33 ` [PATCH v4 1/2] pinctrl: single: parse " Drew Fustini
2020-07-01 1:33 ` Drew Fustini
2020-09-08 23:52 ` Trent Piepho
2020-09-08 23:52 ` Trent Piepho
2020-09-13 19:42 ` Drew Fustini
2020-09-13 19:42 ` Drew Fustini
2020-09-13 23:27 ` Drew Fustini
2020-09-13 23:27 ` Drew Fustini
2020-07-01 1:33 ` [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 Drew Fustini
2020-07-01 1:33 ` Drew Fustini
2020-09-09 0:34 ` Trent Piepho
2020-09-09 0:34 ` Trent Piepho
2021-01-15 18:02 ` Emmanuel Vadot [this message]
2021-01-15 18:02 ` Emmanuel Vadot
2021-01-15 21:40 ` Drew Fustini
2021-01-15 21:40 ` Drew Fustini
2021-01-18 7:41 ` Tony Lindgren
2021-01-18 7:41 ` Tony Lindgren
2020-07-02 17:36 ` [PATCH v4 0/2] pinctrl: single: support #pinctrl-cells = 2 Tony Lindgren
2020-07-02 17:36 ` Tony Lindgren
2020-07-05 9:01 ` Haojian Zhuang
2020-07-05 9:01 ` Haojian Zhuang
2020-07-07 10:59 ` Linus Walleij
2020-07-07 10:59 ` Linus Walleij
2020-07-07 11:02 ` Drew Fustini
2020-07-07 11:02 ` Drew Fustini
2020-07-11 21:12 ` Linus Walleij
2020-07-11 21:12 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com \
--to=manu@bidouilliste.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=haojian.zhuang@linaro.org \
--cc=jkridner@beagleboard.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.