From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Marek Vasut <marex@denx.de>, Stefan Agner <stefan@agner.ch>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
Martin Kepplinger <martin.kepplinger@puri.sm>
Subject: [PATCH v3 2/3] dt-bindings: display: mxsfb: Add and fix compatible strings
Date: Sat, 16 Jan 2021 00:23:03 +0200 [thread overview]
Message-ID: <20210115222304.5427-3-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20210115222304.5427-1-laurent.pinchart@ideasonboard.com>
Additional compatible strings have been added in DT source for the
i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
Most of the upstream DT sources use the fsl,imx28-lcdif compatible
string, which mostly predates the realization that the LCDIF in the
i.MX6 and newer SoCs have extra features compared to the i.MX28.
Update the bindings to add the missing compatible strings, with the
correct fallback values. This fails to validate some of the upstream DT
sources. Instead of adding the incorrect compatible fallback to the
binding, the sources should be updated separately.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v2:
- Fix indentation under items too
Changes since v1:
- Fix indentation under enum
---
.../devicetree/bindings/display/fsl,lcdif.yaml | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index bbd47d80d253..4fc24d482b1c 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -15,11 +15,19 @@ description: |
properties:
compatible:
- enum:
- - fsl,imx23-lcdif
- - fsl,imx28-lcdif
- - fsl,imx6sx-lcdif
- - fsl,imx8mq-lcdif
+ oneOf:
+ - enum:
+ - fsl,imx23-lcdif
+ - fsl,imx28-lcdif
+ - fsl,imx6sx-lcdif
+ - items:
+ - enum:
+ - fsl,imx6sl-lcdif
+ - fsl,imx6sll-lcdif
+ - fsl,imx6ul-lcdif
+ - fsl,imx7d-lcdif
+ - fsl,imx8mq-lcdif
+ - const: fsl,imx6sx-lcdif
reg:
maxItems: 1
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org,
Martin Kepplinger <martin.kepplinger@puri.sm>,
Stefan Agner <stefan@agner.ch>, Rob Herring <robh+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] dt-bindings: display: mxsfb: Add and fix compatible strings
Date: Sat, 16 Jan 2021 00:23:03 +0200 [thread overview]
Message-ID: <20210115222304.5427-3-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20210115222304.5427-1-laurent.pinchart@ideasonboard.com>
Additional compatible strings have been added in DT source for the
i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
Most of the upstream DT sources use the fsl,imx28-lcdif compatible
string, which mostly predates the realization that the LCDIF in the
i.MX6 and newer SoCs have extra features compared to the i.MX28.
Update the bindings to add the missing compatible strings, with the
correct fallback values. This fails to validate some of the upstream DT
sources. Instead of adding the incorrect compatible fallback to the
binding, the sources should be updated separately.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v2:
- Fix indentation under items too
Changes since v1:
- Fix indentation under enum
---
.../devicetree/bindings/display/fsl,lcdif.yaml | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index bbd47d80d253..4fc24d482b1c 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -15,11 +15,19 @@ description: |
properties:
compatible:
- enum:
- - fsl,imx23-lcdif
- - fsl,imx28-lcdif
- - fsl,imx6sx-lcdif
- - fsl,imx8mq-lcdif
+ oneOf:
+ - enum:
+ - fsl,imx23-lcdif
+ - fsl,imx28-lcdif
+ - fsl,imx6sx-lcdif
+ - items:
+ - enum:
+ - fsl,imx6sl-lcdif
+ - fsl,imx6sll-lcdif
+ - fsl,imx6ul-lcdif
+ - fsl,imx7d-lcdif
+ - fsl,imx8mq-lcdif
+ - const: fsl,imx6sx-lcdif
reg:
maxItems: 1
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org,
Martin Kepplinger <martin.kepplinger@puri.sm>,
Rob Herring <robh+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] dt-bindings: display: mxsfb: Add and fix compatible strings
Date: Sat, 16 Jan 2021 00:23:03 +0200 [thread overview]
Message-ID: <20210115222304.5427-3-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20210115222304.5427-1-laurent.pinchart@ideasonboard.com>
Additional compatible strings have been added in DT source for the
i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings.
Most of the upstream DT sources use the fsl,imx28-lcdif compatible
string, which mostly predates the realization that the LCDIF in the
i.MX6 and newer SoCs have extra features compared to the i.MX28.
Update the bindings to add the missing compatible strings, with the
correct fallback values. This fails to validate some of the upstream DT
sources. Instead of adding the incorrect compatible fallback to the
binding, the sources should be updated separately.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes since v2:
- Fix indentation under items too
Changes since v1:
- Fix indentation under enum
---
.../devicetree/bindings/display/fsl,lcdif.yaml | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index bbd47d80d253..4fc24d482b1c 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -15,11 +15,19 @@ description: |
properties:
compatible:
- enum:
- - fsl,imx23-lcdif
- - fsl,imx28-lcdif
- - fsl,imx6sx-lcdif
- - fsl,imx8mq-lcdif
+ oneOf:
+ - enum:
+ - fsl,imx23-lcdif
+ - fsl,imx28-lcdif
+ - fsl,imx6sx-lcdif
+ - items:
+ - enum:
+ - fsl,imx6sl-lcdif
+ - fsl,imx6sll-lcdif
+ - fsl,imx6ul-lcdif
+ - fsl,imx7d-lcdif
+ - fsl,imx8mq-lcdif
+ - const: fsl,imx6sx-lcdif
reg:
maxItems: 1
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-15 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 22:23 [PATCH v3 0/3] dt-bindings: display: Convert mxsfb DT bindings to YAML Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` [PATCH v3 1/3] dt-bindings: display: mxsfb: Convert binding " Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart [this message]
2021-01-15 22:23 ` [PATCH v3 2/3] dt-bindings: display: mxsfb: Add and fix compatible strings Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` [PATCH v3 3/3] dt-bindings: display: mxsfb: Add compatible for i.MX8MM Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-15 22:23 ` Laurent Pinchart
2021-01-22 15:06 ` [PATCH v3 0/3] dt-bindings: display: Convert mxsfb DT bindings to YAML Rob Herring
2021-01-22 15:06 ` Rob Herring
2021-01-22 15:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115222304.5427-3-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=martin.kepplinger@puri.sm \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.