From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de
Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
wahrenst@gmx.net, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, p.zabel@pengutronix.de,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
linux-clk@vger.kernel.org, sboyd@kernel.org,
linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com,
andy.shevchenko@gmail.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: [PATCH v7 08/11] input: raspberrypi-ts: Release firmware handle when not needed
Date: Mon, 18 Jan 2021 13:32:41 +0100 [thread overview]
Message-ID: <20210118123244.13669-9-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20210118123244.13669-1-nsaenzjulienne@suse.de>
There is no use for the firmware interface after getting the touch
buffer address, so release it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes since v5:
- Correct commit message
Changes since v3:
- Release firmware handle in probe function
Changes since v2:
- Use devm_rpi_firmware_get(), instead of remove function
drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c
index ef6aaed217cf..5000f5fd9ec3 100644
--- a/drivers/input/touchscreen/raspberrypi-ts.c
+++ b/drivers/input/touchscreen/raspberrypi-ts.c
@@ -160,7 +160,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
touchbuf = (u32)ts->fw_regs_phys;
error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
&touchbuf, sizeof(touchbuf));
-
+ rpi_firmware_put(fw);
if (error || touchbuf != 0) {
dev_warn(dev, "Failed to set touchbuf, %d\n", error);
return error;
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, devicetree@vger.kernel.org,
sboyd@kernel.org, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
andy.shevchenko@gmail.com, bcm-kernel-feedback-list@broadcom.com,
wahrenst@gmx.net, p.zabel@pengutronix.de,
linux-input@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bgolaszewski@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v7 08/11] input: raspberrypi-ts: Release firmware handle when not needed
Date: Mon, 18 Jan 2021 13:32:41 +0100 [thread overview]
Message-ID: <20210118123244.13669-9-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20210118123244.13669-1-nsaenzjulienne@suse.de>
There is no use for the firmware interface after getting the touch
buffer address, so release it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes since v5:
- Correct commit message
Changes since v3:
- Release firmware handle in probe function
Changes since v2:
- Use devm_rpi_firmware_get(), instead of remove function
drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c
index ef6aaed217cf..5000f5fd9ec3 100644
--- a/drivers/input/touchscreen/raspberrypi-ts.c
+++ b/drivers/input/touchscreen/raspberrypi-ts.c
@@ -160,7 +160,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
touchbuf = (u32)ts->fw_regs_phys;
error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
&touchbuf, sizeof(touchbuf));
-
+ rpi_firmware_put(fw);
if (error || touchbuf != 0) {
dev_warn(dev, "Failed to set touchbuf, %d\n", error);
return error;
--
2.29.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
f.fainelli@gmail.com, devicetree@vger.kernel.org,
sboyd@kernel.org, gregkh@linuxfoundation.org,
linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
andy.shevchenko@gmail.com, bcm-kernel-feedback-list@broadcom.com,
wahrenst@gmx.net, p.zabel@pengutronix.de,
linux-input@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bgolaszewski@baylibre.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v7 08/11] input: raspberrypi-ts: Release firmware handle when not needed
Date: Mon, 18 Jan 2021 13:32:41 +0100 [thread overview]
Message-ID: <20210118123244.13669-9-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20210118123244.13669-1-nsaenzjulienne@suse.de>
There is no use for the firmware interface after getting the touch
buffer address, so release it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes since v5:
- Correct commit message
Changes since v3:
- Release firmware handle in probe function
Changes since v2:
- Use devm_rpi_firmware_get(), instead of remove function
drivers/input/touchscreen/raspberrypi-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c
index ef6aaed217cf..5000f5fd9ec3 100644
--- a/drivers/input/touchscreen/raspberrypi-ts.c
+++ b/drivers/input/touchscreen/raspberrypi-ts.c
@@ -160,7 +160,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
touchbuf = (u32)ts->fw_regs_phys;
error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
&touchbuf, sizeof(touchbuf));
-
+ rpi_firmware_put(fw);
if (error || touchbuf != 0) {
dev_warn(dev, "Failed to set touchbuf, %d\n", error);
return error;
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-18 13:18 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 12:32 [PATCH v7 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 01/11] firmware: raspberrypi: Keep count of all consumers Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 03/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 04/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 05/11] reset: raspberrypi: " Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 06/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 07/11] staging: vchiq: " Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-26 17:47 ` Greg KH
2021-01-26 17:47 ` Greg KH
2021-01-26 17:47 ` Greg KH
2021-01-18 12:32 ` Nicolas Saenz Julienne [this message]
2021-01-18 12:32 ` [PATCH v7 08/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` [PATCH v7 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-01-18 12:32 ` Nicolas Saenz Julienne
2021-02-08 20:53 ` Nicolas Saenz Julienne
2021-02-08 20:53 ` Nicolas Saenz Julienne
2021-02-08 20:53 ` Nicolas Saenz Julienne
2021-03-09 9:59 ` Nicolas Saenz Julienne
2021-03-09 9:59 ` Nicolas Saenz Julienne
2021-03-09 9:59 ` Nicolas Saenz Julienne
2021-03-10 11:50 ` Uwe Kleine-König
2021-03-10 11:50 ` Uwe Kleine-König
2021-03-10 11:50 ` Uwe Kleine-König
2021-03-11 13:01 ` Nicolas Saenz Julienne
2021-03-11 13:01 ` Nicolas Saenz Julienne
2021-03-11 13:01 ` Nicolas Saenz Julienne
2021-03-11 13:18 ` Uwe Kleine-König
2021-03-11 13:18 ` Uwe Kleine-König
2021-03-11 13:18 ` Uwe Kleine-König
2021-03-11 13:41 ` Nicolas Saenz Julienne
2021-03-11 13:41 ` Nicolas Saenz Julienne
2021-03-11 13:41 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118123244.13669-9-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.