From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation
Date: Tue, 19 Jan 2021 09:17:27 +0300 [thread overview]
Message-ID: <20210119061726.GD2696@kadam> (raw)
In-Reply-To: <20210113211410.917108-10-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]
Hi Marc,
url: https://github.com/0day-ci/linux/commits/Marc-Kleine-Budde/MAINTAINERS-adjust-entry-to-tcan4x5x-file-split/20210114-102248
base: f50e2f9f791647aa4e5b19d0064f5cabf630bf6e
config: i386-randconfig-m021-20210114 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/dev/length.c:38 can_fd_len2dlc() error: buffer overflow 'len2dlc' 49 <= 49
vim +/len2dlc +38 drivers/net/can/dev/length.c
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 32 /* map the sanitized data length to an appropriate data length code */
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 33 u8 can_fd_len2dlc(u8 len)
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 34 {
6ae761ad6c0557f0 Marc Kleine-Budde 2021-01-13 35 if (len > ARRAY_SIZE(len2dlc))
^
This should be >=
6ae761ad6c0557f0 Marc Kleine-Budde 2021-01-13 36 return CANFD_MAX_DLC;
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 37
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 @38 return len2dlc[len];
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32926 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation
Date: Tue, 19 Jan 2021 09:17:27 +0300 [thread overview]
Message-ID: <20210119061726.GD2696@kadam> (raw)
In-Reply-To: <20210113211410.917108-10-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]
Hi Marc,
url: https://github.com/0day-ci/linux/commits/Marc-Kleine-Budde/MAINTAINERS-adjust-entry-to-tcan4x5x-file-split/20210114-102248
base: f50e2f9f791647aa4e5b19d0064f5cabf630bf6e
config: i386-randconfig-m021-20210114 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/can/dev/length.c:38 can_fd_len2dlc() error: buffer overflow 'len2dlc' 49 <= 49
vim +/len2dlc +38 drivers/net/can/dev/length.c
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 32 /* map the sanitized data length to an appropriate data length code */
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 33 u8 can_fd_len2dlc(u8 len)
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 34 {
6ae761ad6c0557f0 Marc Kleine-Budde 2021-01-13 35 if (len > ARRAY_SIZE(len2dlc))
^
This should be >=
6ae761ad6c0557f0 Marc Kleine-Budde 2021-01-13 36 return CANFD_MAX_DLC;
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 37
d4b90befe4bfafa1 Marc Kleine-Budde 2021-01-13 @38 return len2dlc[len];
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32926 bytes --]
next prev parent reply other threads:[~2021-01-19 6:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 21:13 pull-request: can-next 2021-01-13 Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 01/17] MAINTAINERS: adjust entry to tcan4x5x file split Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 02/17] MAINTAINERS: CAN network layer: add missing header file can-ml.h Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 03/17] can: dev: move driver related infrastructure into separate subdir Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 04/17] can: dev: move bittiming related code into seperate file Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 05/17] can: dev: move length " Marc Kleine-Budde
2021-01-13 21:13 ` [net-next 06/17] can: dev: move skb related " Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 07/17] can: dev: move netlink related code " Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 08/17] can: length: convert to kernel coding style Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation Marc Kleine-Budde
2021-01-14 1:59 ` Vincent MAILHOL
2021-01-14 7:34 ` Marc Kleine-Budde
2021-01-14 8:23 ` Oliver Hartkopp
2021-01-14 9:16 ` Vincent MAILHOL
2021-01-14 17:03 ` Oliver Hartkopp
2021-01-15 1:57 ` Vincent MAILHOL
2021-01-15 12:38 ` Oliver Hartkopp
2021-01-15 13:20 ` Vincent MAILHOL
2021-01-15 13:51 ` Marc Kleine-Budde
2021-01-15 14:18 ` Vincent MAILHOL
2021-01-15 14:50 ` Marc Kleine-Budde
2021-01-16 10:23 ` Oliver Hartkopp
2021-01-17 22:16 ` Marc Kleine-Budde
2021-01-19 6:17 ` Dan Carpenter [this message]
2021-01-19 6:17 ` Dan Carpenter
2021-01-19 7:46 ` Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 10/17] can: length: canfd_sanitize_len(): add function to sanitize CAN-FD data length Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 11/17] can: length: can_skb_get_frame_len(): introduce function to get data length of frame in data link layer Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 12/17] can: dev: extend struct can_skb_priv to hold CAN frame length Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 13/17] can: dev: can_put_echo_skb(): extend to handle frame_len Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 14/17] can: dev: can_get_echo_skb(): extend to return can frame length Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 15/17] can: dev: can_rx_offload_get_echo_skb(): " Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 16/17] can: dev: can_put_echo_skb(): add software tx timestamps Marc Kleine-Budde
2021-01-13 21:14 ` [net-next 17/17] can: tcan4x5x: remove __packed attribute from struct tcan4x5x_map_buf Marc Kleine-Budde
2021-01-14 7:32 ` pull-request: can-next 2021-01-13 Marc Kleine-Budde
2021-01-14 5:34 [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation kernel test robot
2021-01-14 7:56 pull-request: can-next 2021-01-14 Marc Kleine-Budde
2021-01-14 7:56 ` [net-next 09/17] can: length: can_fd_len2dlc(): simplify length calculcation Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119061726.GD2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.