All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, kraxel@redhat.com
Subject: [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help"
Date: Wed, 20 Jan 2021 15:42:32 +0100	[thread overview]
Message-ID: <20210120144235.345983-1-pbonzini@redhat.com> (raw)

The real driver for these patches is to send all QemuOpts user input
to qemu_opts_parse_noisily, for consistency in the command line
parsing code and to effectively outlaw "help" and "?" QemuOpts
suboptions.  vnc_parse is the only function that is still using
qemu_opts_parse.

In order to remove the non-command-line callers of vnc_parse,
I am removing the deprecated QMP change command but also its HMP
veneer "change vnc TARGET", whose usecase is somewhat unclear to
me.  "change vnc password" is still supported.

Finally, by switching to qemu_opts_parse_noisily, it is easy to
print a help message on "-vnc help".


Paolo Bonzini (3):
  hmp: remove "change vnc TARGET" command
  qmp: remove deprecated "change" command
  vnc: support "-vnc help"

 docs/system/deprecated.rst       |  5 ----
 docs/system/removed-features.rst | 11 +++++++
 hmp-commands.hx                  |  6 ----
 include/ui/console.h             |  2 +-
 monitor/hmp-cmds.c               |  7 +++--
 monitor/qmp-cmds.c               | 51 --------------------------------
 qapi/misc.json                   | 49 ------------------------------
 softmmu/vl.c                     |  6 ++--
 ui/vnc-stubs.c                   |  7 ++---
 ui/vnc.c                         |  8 ++---
 10 files changed, 27 insertions(+), 125 deletions(-)

-- 
2.29.2



             reply	other threads:[~2021-01-20 14:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 14:42 Paolo Bonzini [this message]
2021-01-20 14:42 ` [PATCH 1/3] hmp: remove "change vnc TARGET" command Paolo Bonzini
2021-01-20 15:24   ` Eric Blake
2021-01-20 14:42 ` [PATCH 2/3] qmp: remove deprecated "change" command Paolo Bonzini
2021-01-20 15:21   ` Philippe Mathieu-Daudé
2021-01-20 15:31   ` Eric Blake
2021-01-20 14:42 ` [PATCH 3/3] vnc: support "-vnc help" Paolo Bonzini
2021-01-20 15:44   ` Eric Blake
2021-01-21 10:38 ` [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, " Gerd Hoffmann
2021-01-21 10:52   ` Daniel P. Berrangé
2021-01-21 11:13     ` Gerd Hoffmann
2021-01-21 12:02       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120144235.345983-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.