All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help"
Date: Thu, 21 Jan 2021 12:13:17 +0100	[thread overview]
Message-ID: <20210121111317.p7vwmau52odrrtwf@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210121105204.GI3125227@redhat.com>

  Hi,

> > So, all in all I feel a bit uncomfortable dropping this without the
> > usual deprecation period.  No strong objections though.
> 
> Well we did deprecate the "change" command in general in 2.5.0.
> 
>   https://qemu.readthedocs.io/en/latest/system/deprecated.html#change-since-2-5-0
> 
> We gave illustrations for replacement for vnc password and CD
> media change, but no replacement was provided for changing
> VNC server config.  That's ok though, as there's no requirement
> that we provide a replacement when deprecating stuff.

Fair enough.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

(assuming you want queue that with other qemu-opts changes,
 but I can also take this through ui queue if you want).

take care,
  Gerd



  reply	other threads:[~2021-01-21 11:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 14:42 [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help" Paolo Bonzini
2021-01-20 14:42 ` [PATCH 1/3] hmp: remove "change vnc TARGET" command Paolo Bonzini
2021-01-20 15:24   ` Eric Blake
2021-01-20 14:42 ` [PATCH 2/3] qmp: remove deprecated "change" command Paolo Bonzini
2021-01-20 15:21   ` Philippe Mathieu-Daudé
2021-01-20 15:31   ` Eric Blake
2021-01-20 14:42 ` [PATCH 3/3] vnc: support "-vnc help" Paolo Bonzini
2021-01-20 15:44   ` Eric Blake
2021-01-21 10:38 ` [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, " Gerd Hoffmann
2021-01-21 10:52   ` Daniel P. Berrangé
2021-01-21 11:13     ` Gerd Hoffmann [this message]
2021-01-21 12:02       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121111317.p7vwmau52odrrtwf@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.