From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org,
heiko.stuebner@theobroma-systems.com, heiko@sntech.de
Cc: laurent.pinchart@ideasonboard.com,
dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com,
dafna3@gmail.com, sakari.ailus@linux.intel.com,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
tfiga@chromium.org
Subject: [PATCH v7 2/5] media: rkisp1: stats: remove a wrong cast to u8
Date: Wed, 20 Jan 2021 17:44:43 +0100 [thread overview]
Message-ID: <20210120164446.1220-3-dafna.hirschfeld@collabora.com> (raw)
In-Reply-To: <20210120164446.1220-1-dafna.hirschfeld@collabora.com>
hist_bins is an array of type __u32. Each entry represent
a 20 bit fixed point value as documented inline.
The cast to u8 when setting the values is wrong. Remove it.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
index 3ddab8fa8f2d..4cdb180fa64d 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
@@ -235,8 +235,7 @@ static void rkisp1_stats_get_hst_meas(struct rkisp1_stats *stats,
pbuf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
for (i = 0; i < RKISP1_CIF_ISP_HIST_BIN_N_MAX; i++)
pbuf->params.hist.hist_bins[i] =
- (u8)rkisp1_read(rkisp1,
- RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
+ rkisp1_read(rkisp1, RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
}
static void rkisp1_stats_get_bls_meas(struct rkisp1_stats *stats,
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org,
heiko.stuebner@theobroma-systems.com, heiko@sntech.de
Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com,
dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl,
linux-rockchip@lists.infradead.org, helen.koike@collabora.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, ezequiel@collabora.com
Subject: [PATCH v7 2/5] media: rkisp1: stats: remove a wrong cast to u8
Date: Wed, 20 Jan 2021 17:44:43 +0100 [thread overview]
Message-ID: <20210120164446.1220-3-dafna.hirschfeld@collabora.com> (raw)
In-Reply-To: <20210120164446.1220-1-dafna.hirschfeld@collabora.com>
hist_bins is an array of type __u32. Each entry represent
a 20 bit fixed point value as documented inline.
The cast to u8 when setting the values is wrong. Remove it.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
index 3ddab8fa8f2d..4cdb180fa64d 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
@@ -235,8 +235,7 @@ static void rkisp1_stats_get_hst_meas(struct rkisp1_stats *stats,
pbuf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
for (i = 0; i < RKISP1_CIF_ISP_HIST_BIN_N_MAX; i++)
pbuf->params.hist.hist_bins[i] =
- (u8)rkisp1_read(rkisp1,
- RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
+ rkisp1_read(rkisp1, RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
}
static void rkisp1_stats_get_bls_meas(struct rkisp1_stats *stats,
--
2.17.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-01-20 16:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 16:44 [PATCH v7 0/5] Fix the rkisp1 userspace API for later IP versions Dafna Hirschfeld
2021-01-20 16:44 ` Dafna Hirschfeld
2021-01-20 16:44 ` [PATCH v7 1/5] media: rkisp1: uapi: change hist_bins array type from __u16 to __u32 Dafna Hirschfeld
2021-01-20 16:44 ` Dafna Hirschfeld
2021-01-20 21:32 ` Sakari Ailus
2021-01-20 21:32 ` Sakari Ailus
2021-01-21 12:48 ` Dafna Hirschfeld
2021-01-21 12:48 ` Dafna Hirschfeld
2021-01-21 13:01 ` Sakari Ailus
2021-01-21 13:01 ` Sakari Ailus
2021-01-20 16:44 ` Dafna Hirschfeld [this message]
2021-01-20 16:44 ` [PATCH v7 2/5] media: rkisp1: stats: remove a wrong cast to u8 Dafna Hirschfeld
2021-01-21 9:31 ` Heiko Stuebner
2021-01-21 9:31 ` Heiko Stuebner
2021-01-21 10:07 ` Tomasz Figa
2021-01-21 10:07 ` Tomasz Figa
2021-01-21 11:47 ` Dafna Hirschfeld
2021-01-21 11:47 ` Dafna Hirschfeld
2021-01-20 16:44 ` [PATCH v7 3/5] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi Dafna Hirschfeld
2021-01-20 16:44 ` Dafna Hirschfeld
2021-01-20 16:44 ` [PATCH v7 4/5] media: rockchip: rkisp1: carry ip version information Dafna Hirschfeld
2021-01-20 16:44 ` Dafna Hirschfeld
2021-01-20 16:44 ` [PATCH v7 5/5] media: rockchip: rkisp1: extend uapi array sizes Dafna Hirschfeld
2021-01-20 16:44 ` Dafna Hirschfeld
2021-01-21 10:16 ` Tomasz Figa
2021-01-21 10:16 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120164446.1220-3-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.