From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
linux-can@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH can tree] can: dev: prevent potential information leak in can_fill_info()
Date: Thu, 21 Jan 2021 08:37:20 +0100 [thread overview]
Message-ID: <20210121073720.zlskqgitnod3w6hf@hardanger.blackshift.org> (raw)
In-Reply-To: <YAkaRdRJncsJO8Ve@mwanda>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Hey Dan,
On Thu, Jan 21, 2021 at 09:08:05AM +0300, Dan Carpenter wrote:
> The "bec" struct isn't necessarily always initialized. For example,
> the mcp251xfd_get_berr_counter() function doesn't initialize anything
> if the interface is down.
>
> Fixes: 52c793f24054 ("can: netlink support for bus-error reporting and counters")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch. As this is a fix, I've backported it to net/master, which
is before the split of the dev.c into separate files. Applied to
linux-can/testing.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
linux-can@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH can tree] can: dev: prevent potential information leak in can_fill_info()
Date: Thu, 21 Jan 2021 07:37:20 +0000 [thread overview]
Message-ID: <20210121073720.zlskqgitnod3w6hf@hardanger.blackshift.org> (raw)
In-Reply-To: <YAkaRdRJncsJO8Ve@mwanda>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
Hey Dan,
On Thu, Jan 21, 2021 at 09:08:05AM +0300, Dan Carpenter wrote:
> The "bec" struct isn't necessarily always initialized. For example,
> the mcp251xfd_get_berr_counter() function doesn't initialize anything
> if the interface is down.
>
> Fixes: 52c793f24054 ("can: netlink support for bus-error reporting and counters")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the patch. As this is a fix, I've backported it to net/master, which
is before the split of the dev.c into separate files. Applied to
linux-can/testing.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-21 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:08 [PATCH can tree] can: dev: prevent potential information leak in can_fill_info() Dan Carpenter
2021-01-21 6:08 ` Dan Carpenter
2021-01-21 7:37 ` Marc Kleine-Budde [this message]
2021-01-21 7:37 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121073720.zlskqgitnod3w6hf@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.