From: Christoph Hellwig <hch@lst.de> To: Frederic Barrat <fbarrat@linux.ibm.com>, Andrew Donnellan <ajd@linux.ibm.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jessica Yu <jeyu@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com> Cc: Masahiro Yamada <masahiroy@kernel.org>, Michal Marek <michal.lkml@markovi.net>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Date: Thu, 21 Jan 2021 08:49:51 +0100 [thread overview] Message-ID: <20210121074959.313333-6-hch@lst.de> (raw) In-Reply-To: <20210121074959.313333-1-hch@lst.de> Require an explicit cll to module_kallsyms_on_each_symbol to look for symbols in modules instead of the call from kallsyms_on_each_symbol, and acquire module_mutex inside of module_kallsyms_on_each_symbol instead of leaving that up to the caller. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/kallsyms.c | 6 +++++- kernel/livepatch/core.c | 6 +----- kernel/module.c | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index fe9de067771c34..a0d3f0865916f9 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -177,6 +177,10 @@ unsigned long kallsyms_lookup_name(const char *name) return module_kallsyms_lookup_name(name); } +/* + * Iterate over all symbols in vmlinux. For symbols from modules use + * module_kallsyms_on_each_symbol instead. + */ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, unsigned long), void *data) @@ -192,7 +196,7 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, if (ret != 0) return ret; } - return module_kallsyms_on_each_symbol(fn, data); + return 0; } static unsigned long get_symbol_pos(unsigned long addr, diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 878759baadd81c..8063b9089bd2f8 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -135,12 +135,8 @@ static int klp_find_object_symbol(const char *objname, const char *name, .pos = sympos, }; - mutex_lock(&module_mutex); - if (objname) + if (objname || !kallsyms_on_each_symbol(klp_find_callback, &args)) module_kallsyms_on_each_symbol(klp_find_callback, &args); - else - kallsyms_on_each_symbol(klp_find_callback, &args); - mutex_unlock(&module_mutex); /* * Ensure an address was found. If sympos is 0, ensure symbol is unique; diff --git a/kernel/module.c b/kernel/module.c index 299cbac0775cf2..885feec64c1b6f 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4407,8 +4407,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, unsigned int i; int ret; - module_assert_mutex(); - + mutex_lock(&module_mutex); list_for_each_entry(mod, &modules, list) { /* We hold module_mutex: no need for rcu_dereference_sched */ struct mod_kallsyms *kallsyms = mod->kallsyms; @@ -4424,10 +4423,11 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, ret = fn(data, kallsyms_symbol_name(kallsyms, i), mod, kallsyms_symbol_value(sym)); if (ret != 0) - return ret; + break; } } - return 0; + mutex_unlock(&module_mutex); + return ret; } #endif /* CONFIG_KALLSYMS */ -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Frederic Barrat <fbarrat@linux.ibm.com>, Andrew Donnellan <ajd@linux.ibm.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jessica Yu <jeyu@kernel.org>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com> Cc: Michal Marek <michal.lkml@markovi.net>, linux-kbuild@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, live-patching@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Date: Thu, 21 Jan 2021 08:49:51 +0100 [thread overview] Message-ID: <20210121074959.313333-6-hch@lst.de> (raw) In-Reply-To: <20210121074959.313333-1-hch@lst.de> Require an explicit cll to module_kallsyms_on_each_symbol to look for symbols in modules instead of the call from kallsyms_on_each_symbol, and acquire module_mutex inside of module_kallsyms_on_each_symbol instead of leaving that up to the caller. Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/kallsyms.c | 6 +++++- kernel/livepatch/core.c | 6 +----- kernel/module.c | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index fe9de067771c34..a0d3f0865916f9 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -177,6 +177,10 @@ unsigned long kallsyms_lookup_name(const char *name) return module_kallsyms_lookup_name(name); } +/* + * Iterate over all symbols in vmlinux. For symbols from modules use + * module_kallsyms_on_each_symbol instead. + */ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, unsigned long), void *data) @@ -192,7 +196,7 @@ int kallsyms_on_each_symbol(int (*fn)(void *, const char *, struct module *, if (ret != 0) return ret; } - return module_kallsyms_on_each_symbol(fn, data); + return 0; } static unsigned long get_symbol_pos(unsigned long addr, diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 878759baadd81c..8063b9089bd2f8 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -135,12 +135,8 @@ static int klp_find_object_symbol(const char *objname, const char *name, .pos = sympos, }; - mutex_lock(&module_mutex); - if (objname) + if (objname || !kallsyms_on_each_symbol(klp_find_callback, &args)) module_kallsyms_on_each_symbol(klp_find_callback, &args); - else - kallsyms_on_each_symbol(klp_find_callback, &args); - mutex_unlock(&module_mutex); /* * Ensure an address was found. If sympos is 0, ensure symbol is unique; diff --git a/kernel/module.c b/kernel/module.c index 299cbac0775cf2..885feec64c1b6f 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -4407,8 +4407,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, unsigned int i; int ret; - module_assert_mutex(); - + mutex_lock(&module_mutex); list_for_each_entry(mod, &modules, list) { /* We hold module_mutex: no need for rcu_dereference_sched */ struct mod_kallsyms *kallsyms = mod->kallsyms; @@ -4424,10 +4423,11 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, ret = fn(data, kallsyms_symbol_name(kallsyms, i), mod, kallsyms_symbol_value(sym)); if (ret != 0) - return ret; + break; } } - return 0; + mutex_unlock(&module_mutex); + return ret; } #endif /* CONFIG_KALLSYMS */ -- 2.29.2
next prev parent reply other threads:[~2021-01-21 20:10 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 7:49 module loader dead code removal and cleanusp Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 9:09 ` Andrew Donnellan 2021-01-21 9:09 ` Andrew Donnellan 2021-01-21 9:09 ` Andrew Donnellan 2021-01-21 7:49 ` [PATCH 02/13] module: add a module_loaded helper Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 9:59 ` Christophe Leroy 2021-01-21 10:13 ` David Laight 2021-01-21 10:17 ` Christophe Leroy 2021-01-21 10:00 ` Christophe Leroy 2021-01-21 10:00 ` Christophe Leroy 2021-01-21 17:11 ` Christoph Hellwig 2021-01-21 17:11 ` Christoph Hellwig 2021-01-21 17:44 ` David Laight 2021-01-21 17:44 ` David Laight 2021-01-21 17:44 ` David Laight 2021-01-21 7:49 ` [PATCH 03/13] livepatch: refactor klp_init_object Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-27 12:58 ` Petr Mladek 2021-01-27 12:58 ` Petr Mladek 2021-01-27 12:58 ` Petr Mladek 2021-01-28 16:22 ` Christoph Hellwig 2021-01-28 16:22 ` Christoph Hellwig 2021-01-28 16:24 ` Christoph Hellwig 2021-01-28 16:24 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 04/13] livepatch: move klp_find_object_module to module.c Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 21:45 ` Josh Poimboeuf 2021-01-21 21:45 ` Josh Poimboeuf 2021-01-21 21:45 ` Josh Poimboeuf 2021-01-26 14:25 ` Jessica Yu 2021-01-26 14:25 ` Jessica Yu 2021-01-26 14:25 ` Jessica Yu 2021-01-27 11:55 ` Petr Mladek 2021-01-27 11:55 ` Petr Mladek 2021-01-27 11:55 ` Petr Mladek 2021-01-21 7:49 ` Christoph Hellwig [this message] 2021-01-21 7:49 ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig 2021-01-21 7:49 ` [PATCH 06/13] kallsyms: only build {,module_}kallsyms_on_each_symbol when required Christoph Hellwig 2021-01-21 7:49 ` [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol " Christoph Hellwig 2021-01-21 7:49 ` [PATCH 07/13] module: mark module_mutex static Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 08/13] drm: remove drm_fb_helper_modinit Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 8:25 ` Daniel Vetter 2021-01-21 8:25 ` Daniel Vetter 2021-01-21 8:25 ` Daniel Vetter 2021-01-21 8:28 ` Christoph Hellwig 2021-01-21 8:28 ` Christoph Hellwig 2021-01-21 8:39 ` Daniel Vetter 2021-01-21 8:39 ` Daniel Vetter 2021-01-21 8:39 ` Daniel Vetter 2021-01-21 7:49 ` [PATCH 09/13] module: remove each_symbol_in_section Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 10/13] module: merge each_symbol_section into find_symbol Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 11/13] module: pass struct find_symbol_args to find_symbol Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-21 7:49 ` [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL* Christoph Hellwig 2021-01-21 7:49 ` Christoph Hellwig 2021-01-27 13:49 ` Jessica Yu 2021-01-27 13:49 ` Jessica Yu 2021-01-27 13:49 ` Jessica Yu 2021-01-28 16:09 ` Christoph Hellwig 2021-01-28 16:09 ` Christoph Hellwig 2021-01-28 18:14 module loader dead code removal and cleanups v2 Christoph Hellwig 2021-01-28 18:14 ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig 2021-01-29 9:43 ` Petr Mladek 2021-02-01 11:47 ` Christoph Hellwig 2021-02-01 11:47 ` Christoph Hellwig 2021-02-01 13:37 ` Miroslav Benes 2021-02-01 13:37 ` Miroslav Benes 2021-02-01 13:37 ` Miroslav Benes 2021-02-01 16:28 ` Christoph Hellwig 2021-02-01 16:28 ` Christoph Hellwig 2021-02-02 10:45 ` Miroslav Benes 2021-02-02 10:45 ` Miroslav Benes 2021-02-02 10:45 ` Miroslav Benes 2021-02-01 14:02 ` Miroslav Benes 2021-02-01 14:02 ` Miroslav Benes 2021-02-01 14:02 ` Miroslav Benes 2021-02-02 12:13 module loader dead code removal and cleanups v3 Christoph Hellwig 2021-02-02 12:13 ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Christoph Hellwig 2021-02-02 12:13 ` Christoph Hellwig 2021-02-03 8:58 ` Petr Mladek 2021-02-03 8:58 ` Petr Mladek 2021-02-03 8:58 ` Petr Mladek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210121074959.313333-6-hch@lst.de \ --to=hch@lst.de \ --cc=airlied@linux.ie \ --cc=ajd@linux.ibm.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=fbarrat@linux.ibm.com \ --cc=jeyu@kernel.org \ --cc=jikos@kernel.org \ --cc=joe.lawrence@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=live-patching@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=masahiroy@kernel.org \ --cc=mbenes@suse.cz \ --cc=michal.lkml@markovi.net \ --cc=mripard@kernel.org \ --cc=pmladek@suse.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.